Migrate keyed service factories from Singleton to NoDestructor [chromium/src : main]

0 views
Skip to first unread message

Cliff Smolinsky (Gerrit)

unread,
Mar 31, 2026, 9:57:04 PM (2 days ago) Mar 31
to Tom Lukaszewicz, Andrew Rayskiy, Rijubrata Bhaumik, Simon Hangl, Lei Zhang, James Maclean, (Julie)Jeongeun Kim, Tommy Li, Kevin McNee, Raphael Kubo da Costa, Peter Beverloo, Todd Reifsteck, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, spang...@chromium.org, nona+...@chromium.org, cros-ed...@google.com, shuche...@chromium.org, tranbaod...@chromium.org, mfoltz+wa...@chromium.org, wfh+...@chromium.org, nicolas...@chromium.org, chfreme...@chromium.org, keithle...@chromium.org, tracing...@chromium.org, ydago...@chromium.org, chromeos-ca...@google.com, cc-...@chromium.org, dtraino...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, chrome-intelligence-te...@google.com, devtools...@chromium.org, chromiumme...@microsoft.com, akingsb+wat...@google.com, abigailbk...@google.com, nektar...@chromium.org, julietlevesque...@google.com, yhanad...@chromium.org, odejesu...@chromium.org, kyungjunle...@google.com, ajayramamurthy...@google.com, khmel...@chromium.org, djacob...@chromium.org, cros-enterpris...@chromium.org, msrame...@chromium.org, kinuko+...@chromium.org, feature-me...@chromium.org, jackshira+wa...@google.com, asvitki...@chromium.org, alandin...@chromium.org, josiah...@chromium.org, mtomas...@chromium.org, toyosh...@chromium.org, jackshira+wat...@google.com, francisjp...@google.com, hansberry+wa...@chromium.org, toshikikikuch...@chromium.org, dullweb...@chromium.org, phshah...@chromium.org, mattreyno...@chromium.org, dibyapal+wa...@chromium.org, crisrael+wa...@google.com, net-r...@chromium.org, hirokisa...@chromium.org, yuzo+...@chromium.org, oshima...@chromium.org, arc-review...@google.com, browser-comp...@chromium.org, cbe-cep-eng...@google.com, chromeos-kio...@google.com, chromium-a...@chromium.org, dmurph+wat...@chromium.org, dtseng...@chromium.org, eic+...@google.com, extension...@chromium.org, filesapp...@chromium.org, gcasto+w...@chromium.org, hidehik...@chromium.org, ios-revie...@chromium.org, ios-rev...@chromium.org, ios-r...@chromium.org, ios-web-view...@google.com, jdeblas...@chromium.org, jimmyxgong+watch-shor...@chromium.org, longbowei+watch-shor...@google.com, marq+...@chromium.org, rrsilva+wat...@google.com, sloboda...@chromium.org, tbarzi...@chromium.org, vasilii+watchlis...@chromium.org, webap...@microsoft.com, yhanada+...@chromium.org
Attention needed from Tom Lukaszewicz

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Lukaszewicz
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ib3ff075a891f8938283ef896c3b7cec05846177c
Gerrit-Change-Number: 7710574
Gerrit-PatchSet: 22
Gerrit-Owner: Cliff Smolinsky <clif...@microsoft.com>
Gerrit-Reviewer: Cliff Smolinsky <clif...@microsoft.com>
Gerrit-Reviewer: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-CC: Andrew Rayskiy <green...@google.com>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: Kevin McNee <mc...@chromium.org>
Gerrit-CC: Lei Zhang <the...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Simon Hangl <sim...@google.com>
Gerrit-CC: Todd Reifsteck <todd...@microsoft.com>
Gerrit-CC: Tommy Li <tomm...@chromium.org>
Gerrit-Attention: Tom Lukaszewicz <tl...@chromium.org>
Gerrit-Comment-Date: Wed, 01 Apr 2026 01:56:51 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages