Properly typemap network.mojom.ConnectionType [chromium/src : main]

[Daniel Cheng (Gerrit)]

Attention needed from Avi Drissman

Daniel Cheng voted and added 3 comments

Votes added by Daniel Cheng

Auto-Submit

+1

3 comments

Patchset-level comments

File-level comment, Patchset 13 (Latest):

Daniel Cheng . resolved

@avi are you willing to help with OO+1 for this CL?

Commit Message

Line 11, Patchset 9:no longer needs to cast between two enums and hope the enuemrator values

Avi Drissman . resolved

```suggestion
no longer needs to cast between two enums and hope the enumerator values
```

Daniel Cheng

Done

Line 16, Patchset 12:deleted.

mmenke . resolved

Maybe mention somewhere that this does not touch network_interface_mojom_traits.cc, which does the actual conversion between the enums?

Daniel Cheng

Done

Open in Gerrit

Related details

Attention is currently required from:

• Avi Drissman

Submit Requirements:

• Code-Coverage
• Code-Owners
• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I22f77c46868b3da9ac2145a85403aacf4aa4353c

Gerrit-Change-Number: 7519815

Gerrit-PatchSet: 13

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>

Gerrit-CC: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-CC: Dirk Schulze <dsch...@chromium.org>

Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>

Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>

Gerrit-CC: Hu, Ningxin <ningx...@intel.com>

Gerrit-CC: Jiewei Qian <q...@chromium.org>

Gerrit-CC: Kevin Babbitt <kbab...@microsoft.com>

Gerrit-CC: Menard, Alexis <alexis...@intel.com>

Gerrit-CC: Nate Chapin <jap...@chromium.org>

Gerrit-CC: Nektarios Paisios <nek...@chromium.org>

Gerrit-CC: Peter Beverloo <pe...@chromium.org>

Gerrit-CC: Peter Williamson <pet...@chromium.org>

Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>

Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>

Gerrit-CC: Simon Hangl <sim...@google.com>

Gerrit-CC: Stephen Chenney <sche...@chromium.org>

Gerrit-CC: chromium...@chromium.org

Gerrit-CC: prerendering-reviews <prerenderi...@chromium.org>

Gerrit-Attention: Avi Drissman <a...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Feb 2026 05:42:45 +0000

Gerrit-HasComments: Yes

Gerrit-Has-Labels: Yes

Comment-In-Reply-To: mmenke <mme...@chromium.org>

Comment-In-Reply-To: Avi Drissman <a...@chromium.org>

[Avi Drissman (Gerrit)]

Attention needed from Daniel Cheng

Avi Drissman voted

Code-Review	+1
Owners-Override	+1

Open in Gerrit

Related details

Attention is currently required from:

• Daniel Cheng

Submit Requirements:

• Code-Coverage
• Code-Owners

• Code-Review
• Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: comment

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I22f77c46868b3da9ac2145a85403aacf4aa4353c

Gerrit-Change-Number: 7519815

Gerrit-PatchSet: 14

Gerrit-Attention: Daniel Cheng <dch...@chromium.org>

Gerrit-Comment-Date: Tue, 03 Feb 2026 16:08:23 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Daniel Cheng (Gerrit)]

Daniel Cheng voted Commit-Queue+2

Commit-Queue

+2

Open in Gerrit

Related details

Attention set is empty

Gerrit-Comment-Date: Tue, 03 Feb 2026 18:14:14 +0000

Gerrit-HasComments: No

Gerrit-Has-Labels: Yes

[Chromium LUCI CQ (Gerrit)]

Chromium LUCI CQ submitted the change

Change information

Commit message:

Properly typemap network.mojom.ConnectionType

The EnumTraits that defines this conversion was added a long time ago in
network_interface_mojom_traits.{cc,h}, but no one ever set up the
C++ typemap for the Mojo enum. This resulted in only a limited amount of
code taking advantage of these conversions, while the rest of the
codebase made assumptions about the underlying values of the enumerators
and casted back and forth.

This CL sets up the typemap to use the pre-existing EnumTraits, so all
the C++ code now uses a single consistent type for the enum. Everything
else just works-the existing traits needed no modification. This also
obsoletes the content.mojom.NetworkConnectionType enum in //content,
which in turns means that native_types.mojom can be wholly deleted.

Bug: 393179188

Change-Id: I22f77c46868b3da9ac2145a85403aacf4aa4353c

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7519815

Owners-Override: Avi Drissman <a...@chromium.org>

Auto-Submit: Daniel Cheng <dch...@chromium.org>

Reviewed-by: mmenke <mme...@chromium.org>

Commit-Queue: Daniel Cheng <dch...@chromium.org>

Reviewed-by: Avi Drissman <a...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1578900}

Files:

• M chrome/browser/ash/app_list/app_service/app_service_app_model_builder_unittest.cc
• M chrome/browser/ash/borealis/borealis_installer_unittest.cc
• M chrome/browser/ash/child_accounts/event_based_status_reporting_service.cc
• M chrome/browser/ash/child_accounts/event_based_status_reporting_service.h
• M chrome/browser/ash/child_accounts/event_based_status_reporting_service_unittest.cc
• M chrome/browser/ash/crostini/crostini_browser_test_util.cc
• M chrome/browser/ash/crostini/crostini_browser_test_util.h
• M chrome/browser/ash/crostini/termina_installer_unittest.cc
• M chrome/browser/ash/extensions/file_manager/event_router.cc
• M chrome/browser/ash/extensions/file_manager/event_router.h
• M chrome/browser/ash/file_manager/file_manager_browsertest_base.cc
• M chrome/browser/ash/file_manager/file_tasks_browsertest.cc
• M chrome/browser/ash/guest_os/guest_os_dlc_helper_unittest.cc
• M chrome/browser/ash/login/app_mode/network_ui_controller.cc
• M chrome/browser/ash/login/session/user_session_manager.cc
• M chrome/browser/ash/login/session/user_session_manager.h
• M chrome/browser/ash/network_change_manager/network_change_manager_client.cc
• M chrome/browser/ash/network_change_manager/network_change_manager_client_browsertest.cc
• M chrome/browser/ash/policy/reporting/arc_app_install_event_log_collector.cc
• M chrome/browser/ash/policy/reporting/arc_app_install_event_log_collector.h
• M chrome/browser/ash/policy/reporting/arc_app_install_event_log_collector_unittest.cc
• M chrome/browser/ash/policy/reporting/install_event_log_collector_base.cc
• M chrome/browser/ash/policy/reporting/install_event_log_collector_base.h
• M chrome/browser/ash/policy/skyvault/odfs_skyvault_uploader.cc
• M chrome/browser/ash/policy/skyvault/odfs_skyvault_uploader.h
• M chrome/browser/ash/policy/skyvault/odfs_skyvault_uploader_browsertest.cc
• M chrome/browser/compose/chrome_compose_client_unittest.cc
• M chrome/browser/glic/glic_profile_manager.cc
• M chrome/browser/glic/glic_profile_manager.h
• M chrome/browser/glic/glic_profile_manager_browsertest.cc
• M chrome/browser/glic/glic_profile_manager_interactive_uitest.cc
• M chrome/browser/glic/host/glic_api_browsertest.cc
• M chrome/browser/intranet_redirect_detector.cc
• M chrome/browser/intranet_redirect_detector.h
• M chrome/browser/local_discovery/service_discovery_client_mdns.cc
• M chrome/browser/local_discovery/service_discovery_client_mdns.h
• M chrome/browser/media/android/cdm/media_drm_origin_id_manager.cc
• M chrome/browser/media/android/cdm/media_drm_origin_id_manager_unittest.cc
• M chrome/browser/media/router/discovery/access_code/access_code_cast_sink_service_unittest.cc
• M chrome/browser/media/router/discovery/dial/dial_registry.cc
• M chrome/browser/media/router/discovery/dial/dial_registry.h
• M chrome/browser/media/router/discovery/dial/dial_registry_unittest.cc
• M chrome/browser/media/router/discovery/discovery_network_monitor.cc
• M chrome/browser/media/router/discovery/discovery_network_monitor.h
• M chrome/browser/media/router/discovery/discovery_network_monitor_unittest.cc
• M chrome/browser/media/router/discovery/mdns/cast_media_sink_service_impl_unittest.cc
• M chrome/browser/media/webrtc/webrtc_event_log_manager_remote.cc
• M chrome/browser/media/webrtc/webrtc_event_log_manager_remote.h
• M chrome/browser/media/webrtc/webrtc_event_log_manager_unittest.cc
• M chrome/browser/metrics/variations/variations_http_headers_browsertest.cc
• M chrome/browser/net/network_connection_tracker_browsertest.cc
• M chrome/browser/net/network_context_configuration_browsertest.cc
• M chrome/browser/net/sandboxed_network_change_notifier_win_browsertest.cc
• M chrome/browser/offline_pages/android/offline_test_util_jni.cc
• M chrome/browser/optimization_guide/hints_fetcher_browsertest.cc
• M chrome/browser/optimization_guide/optimization_guide_keyed_service_browsertest.cc
• M chrome/browser/signin/bound_session_credentials/bound_session_cookie_controller_impl.cc
• M chrome/browser/signin/bound_session_credentials/bound_session_cookie_controller_impl.h
• M chrome/browser/signin/bound_session_credentials/bound_session_cookie_controller_impl_unittest.cc
• M chrome/browser/signin/force_signin_verifier.cc
• M chrome/browser/signin/force_signin_verifier.h
• M chrome/browser/signin/force_signin_verifier_unittest.cc
• M chrome/browser/signin/wait_for_network_callback_helper_chrome.cc
• M chrome/browser/signin/wait_for_network_callback_helper_chrome.h
• M chrome/browser/signin/wait_for_network_callback_helper_chrome_unittest.cc
• M chrome/browser/sync/test/integration/sync_test.cc
• M chrome/browser/sync_file_system/drive_backend/sync_engine.cc
• M chrome/browser/sync_file_system/drive_backend/sync_engine.h
• M chrome/browser/translate/translate_manager_render_view_host_android_unittest.cc
• M chrome/browser/translate/translate_manager_render_view_host_unittest.cc
• M chrome/browser/translate/translate_service.cc
• M chrome/browser/translate/translate_service.h
• M chrome/browser/translate/translate_service_unittest.cc
• M chrome/browser/ui/ash/shelf/chrome_shelf_controller_unittest.cc
• M chrome/browser/ui/views/crostini/crostini_uninstaller_view_browsertest.cc
• M chrome/browser/ui/views/plugin_vm/plugin_vm_installer_view_browsertest.cc
• M chrome/browser/ui/webui/access_code_cast/access_code_cast_handler_browsertest.cc
• M chrome/browser/web_applications/web_app_run_on_os_login_manager.cc
• M chrome/browser/web_applications/web_app_run_on_os_login_manager.h
• M chrome/browser/web_applications/web_app_run_on_os_login_manager_browsertest.cc
• M chrome/test/media_router/access_code_cast/access_code_cast_integration_browsertest.cc
• M chromecast/net/connectivity_checker_impl.cc
• M chromecast/net/connectivity_checker_impl.h
• M chromecast/net/connectivity_checker_impl_unittest.cc
• M chromeos/ash/components/drivefs/drivefs_search_unittest.cc
• M chromeos/ash/components/nearby/common/scheduling/nearby_expiration_scheduler_unittest.cc
• M chromeos/ash/components/nearby/common/scheduling/nearby_on_demand_scheduler_unittest.cc
• M chromeos/ash/components/nearby/common/scheduling/nearby_periodic_scheduler_unittest.cc
• M chromeos/ash/components/nearby/common/scheduling/nearby_scheduler_base.cc
• M chromeos/ash/components/nearby/common/scheduling/nearby_scheduler_base.h
• M chromeos/ash/components/nearby/common/scheduling/nearby_scheduler_base_unittest.cc
• M components/affiliations/core/browser/affiliation_backend_unittest.cc
• M components/affiliations/core/browser/affiliation_fetch_throttler.cc
• M components/affiliations/core/browser/affiliation_fetch_throttler.h
• M components/affiliations/core/browser/affiliation_fetch_throttler_unittest.cc
• M components/affiliations/core/browser/affiliation_service_impl_unittest.cc
• M components/download/internal/background_service/scheduler/device_status_listener.cc
• M components/download/internal/background_service/scheduler/device_status_listener.h
• M components/download/internal/background_service/scheduler/device_status_listener_unittest.cc
• M components/download/network/android/network_status_listener_android.cc
• M components/download/network/android/network_status_listener_android.h
• M components/download/network/network_status_listener.cc
• M components/download/network/network_status_listener.h
• M components/download/network/network_status_listener_impl.cc
• M components/download/network/network_status_listener_impl.h
• M components/download/public/common/android/auto_resumption_handler.cc
• M components/download/public/common/android/auto_resumption_handler.h
• M components/download/public/common/android/auto_resumption_handler_unittest.cc
• M components/error_page/content/browser/net_error_auto_reloader.cc
• M components/error_page/content/browser/net_error_auto_reloader.h
• M components/error_page/content/browser/net_error_auto_reloader_browsertest.cc
• M components/metrics/net/network_metrics_provider.cc
• M components/metrics/net/network_metrics_provider.h
• M components/metrics/net/network_metrics_provider_unittest.cc
• M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc
• M components/policy/core/common/cloud/cloud_policy_refresh_scheduler.h
• M components/policy/core/common/cloud/cloud_policy_refresh_scheduler_unittest.cc
• M components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc
• M components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.h
• M components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate_unittest.cc
• M components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos.cc
• M components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos.h
• M components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_chromeos_unittest.cc
• M components/sync/engine/sync_manager_impl.cc
• M components/sync/engine/sync_manager_impl.h
• M components/sync/engine/sync_scheduler.h
• M components/sync/engine/sync_scheduler_impl.cc
• M components/sync/engine/sync_scheduler_impl.h
• M components/sync/engine/sync_scheduler_impl_unittest.cc
• M components/sync/test/fake_sync_scheduler.cc
• M components/sync/test/fake_sync_scheduler.h
• M components/variations/service/variations_service_unittest.cc
• M components/web_resource/resource_request_allowed_notifier.cc
• M components/web_resource/resource_request_allowed_notifier.h
• M components/web_resource/resource_request_allowed_notifier_unittest.cc
• M content/browser/aggregation_service/aggregatable_report_scheduler_unittest.cc
• M content/browser/aggregation_service/report_scheduler_timer.cc
• M content/browser/aggregation_service/report_scheduler_timer.h
• M content/browser/aggregation_service/report_scheduler_timer_unittest.cc
• M content/browser/android/background_sync_network_observer_android.cc
• M content/browser/android/background_sync_network_observer_android.h
• M content/browser/attribution_reporting/attribution_manager_impl_unittest.cc
• M content/browser/background_sync/background_sync_manager_unittest.cc
• M content/browser/background_sync/background_sync_network_observer.cc
• M content/browser/background_sync/background_sync_network_observer.h
• M content/browser/background_sync/background_sync_network_observer_unittest.cc
• M content/browser/background_sync/background_sync_service_impl_test_harness.cc
• M content/browser/network/address_map_linux_browsertest.cc
• M content/browser/network_service_browsertest.cc
• M content/browser/network_service_client.cc
• M content/browser/network_service_instance_impl.cc
• M content/browser/preloading/prefetch/prefetch_canary_checker.cc
• M content/browser/preloading/prefetch/prefetch_canary_checker_unittest.cc
• M content/common/BUILD.gn
• D content/common/native_types.mojom
• M content/common/renderer.mojom
• M content/public/test/background_sync_test_util.cc
• M content/public/test/network_connection_change_simulator.cc
• M content/public/test/network_connection_change_simulator.h
• M content/public/test/network_service_test_helper.cc
• M content/renderer/render_thread_impl.cc
• M extensions/browser/api/networking_private/networking_private_service_client.cc
• M extensions/browser/api/networking_private/networking_private_service_client.h
• M google_apis/gcm/engine/connection_factory_impl.cc
• M google_apis/gcm/engine/connection_factory_impl.h
• M google_apis/gcm/engine/connection_factory_impl_unittest.cc
• M google_apis/gcm/tools/mcs_probe.cc
• M ios/chrome/browser/reading_list/model/reading_list_download_service.h
• M ios/chrome/browser/reading_list/model/reading_list_download_service.mm
• M mojo/public/tools/bindings/checks/mojom_attributes_check.py
• M services/device/geolocation/public_ip_address_location_notifier.cc
• M services/device/geolocation/public_ip_address_location_notifier.h
• M services/device/geolocation/public_ip_address_location_notifier_unittest.cc
• M services/network/network_change_manager.cc
• M services/network/network_change_manager.h
• M services/network/network_change_manager_unittest.cc
• M services/network/network_service_unittest.cc
• M services/network/public/cpp/network_connection_tracker.cc
• M services/network/public/cpp/network_connection_tracker.h
• M services/network/public/cpp/network_connection_tracker_unittest.cc
• M services/network/public/cpp/p2p_param_traits.h
• M services/network/public/mojom/BUILD.gn
• M services/network/test/test_network_connection_tracker.cc
• M services/network/test/test_network_connection_tracker.h

Change size: XL

Delta: 184 files changed, 1012 insertions(+), 836 deletions(-)

Branch: refs/heads/main

Submit Requirements:

• Code-Review: +1 by mmenke, +1 by Avi Drissman

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: chromium/src

Gerrit-Branch: main

Gerrit-Change-Id: I22f77c46868b3da9ac2145a85403aacf4aa4353c

Gerrit-Change-Number: 7519815

Gerrit-PatchSet: 15

Gerrit-Owner: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: Avi Drissman <a...@chromium.org>

Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>

Gerrit-Reviewer: mmenke <mme...@chromium.org>

Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>

Gerrit-CC: Akihiro Ota <akihi...@chromium.org>

Gerrit-CC: Andrew Rayskiy <green...@google.com>