[tracing] Fix "seek penalty" in trace metadata. [chromium/src : main]

0 views

Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,

Jan 23, 2026, 11:29:34 AMJan 23

to Francois Pierre Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org

Attention needed from Francois Pierre Doray

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review	+1
Commit-Queue	+2

1 comment

Patchset-level comments

File-level comment, Patchset 3 (Latest):

Etienne Pierre-Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:

Francois Pierre Doray

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Jan 23, 2026, 12:57:09 PMJan 23

to Francois Pierre Doray, Etienne Pierre-Doray, AyeAye, chromium...@chromium.org, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

[tracing] Fix "seek penalty" in trace metadata.

The "drive-has_seek_penalty" key in trace metadata is not populated
correctly by this code:
https://source.chromium.org/chromium/chromium/src/+/main:components/tracing/common/system_profile_metadata_recorder.cc;l=136-137;drc=f0f66c80e992e8d84dc43cfda8bf85adf1f10b7c.
This is because the DriveMetricsProvider which populates the system
profile
(https://source.chromium.org/chromium/chromium/src/+/main:chrome/browser/tracing/chrome_background_tracing_metrics_provider.cc;l=66-68;drc=4c93ed0d23357a4687e109be9403ac2c60982d41)
is never initialized. This CL fixes the issue by invoking AsyncInit() on
all `system_profile_providers_`. It was previously only called for the
AntiVirusMetricsProvider.

Change-Id: If5fa039a2ac44a7d2df5a2486ed369101122d854

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7505950

Auto-Submit: Francois Pierre Doray <fdo...@chromium.org>

Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>

Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>

Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1573768}

Files:

M chrome/browser/tracing/chrome_background_tracing_metrics_provider.cc
M chrome/browser/tracing/chrome_background_tracing_metrics_provider.h
M components/tracing/common/background_tracing_metrics_provider.cc
M components/tracing/common/background_tracing_metrics_provider.h

Change size: S

Delta: 4 files changed, 11 insertions(+), 11 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Etienne Pierre-Doray

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages