Refactor: Use uintptr_t for opaque event/task identifiers [chromium/src : main]

2 views
Skip to first unread message

Gabriel Charette (Gerrit)

unread,
Mar 11, 2026, 5:58:31 PMMar 11
to Gabriel Charette, Elly FJ, Etienne Pierre-Doray, Hu, Ningxin, Sam Zackrisson, Jiewei Qian, Kentaro Hara, Per Åhgren, Raphael Kubo da Costa, Ale Bzk, Chromium Metrics Reviews, Chromium LUCI CQ, Sadrul Chowdhury, AyeAye, scheduler...@chromium.org, jophba...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blink-re...@chromium.org, omnibox-...@chromium.org, blink-revie...@chromium.org, srahim...@chromium.org, net-r...@chromium.org, browser-comp...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, asvitki...@chromium.org, sloboda...@chromium.org, android-web...@chromium.org, wnwen...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, niharm...@google.com, blink-revie...@chromium.org, spang...@chromium.org, jmedle...@chromium.org, feature-me...@chromium.org, peilinwa...@google.com, fenced-fra...@chromium.org, network-ser...@chromium.org, ananyasee...@google.com, cc-...@chromium.org, ios-revie...@chromium.org, blink-...@chromium.org, telemetr...@chromium.org, mac-r...@chromium.org, scheduler-b...@chromium.org
Attention needed from Elly FJ and Etienne Pierre-Doray

Gabriel Charette added 1 comment

Patchset-level comments
File-level comment, Patchset 29 (Latest):
Gabriel Charette . resolved

+elly for Mac specific content/public side-effects

Open in Gerrit

Related details

Attention is currently required from:
  • Elly FJ
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I708d056ea93eb19a7010882c9847e97c902dcda1
Gerrit-Change-Number: 7621317
Gerrit-PatchSet: 29
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-Attention: Elly FJ <elly...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Mar 2026 21:58:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Elly FJ (Gerrit)

unread,
Mar 11, 2026, 6:53:06 PMMar 11
to Gabriel Charette, Elly FJ, Etienne Pierre-Doray, Hu, Ningxin, Sam Zackrisson, Jiewei Qian, Kentaro Hara, Per Åhgren, Raphael Kubo da Costa, Ale Bzk, Chromium Metrics Reviews, Chromium LUCI CQ, Sadrul Chowdhury, AyeAye, scheduler...@chromium.org, jophba...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blink-re...@chromium.org, omnibox-...@chromium.org, blink-revie...@chromium.org, srahim...@chromium.org, net-r...@chromium.org, browser-comp...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, asvitki...@chromium.org, sloboda...@chromium.org, android-web...@chromium.org, wnwen...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, niharm...@google.com, blink-revie...@chromium.org, spang...@chromium.org, jmedle...@chromium.org, feature-me...@chromium.org, peilinwa...@google.com, fenced-fra...@chromium.org, network-ser...@chromium.org, ananyasee...@google.com, cc-...@chromium.org, ios-revie...@chromium.org, blink-...@chromium.org, telemetr...@chromium.org, mac-r...@chromium.org, scheduler-b...@chromium.org
Attention needed from Etienne Pierre-Doray and Gabriel Charette

Elly FJ voted and added 1 comment

Votes added by Elly FJ

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
  • Gabriel Charette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I708d056ea93eb19a7010882c9847e97c902dcda1
Gerrit-Change-Number: 7621317
Gerrit-PatchSet: 30
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-Attention: Gabriel Charette <g...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Mar 2026 22:52:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Mar 11, 2026, 10:24:16 PMMar 11
to Gabriel Charette, Elly FJ, Hu, Ningxin, Sam Zackrisson, Jiewei Qian, Kentaro Hara, Per Åhgren, Raphael Kubo da Costa, Ale Bzk, Chromium Metrics Reviews, Chromium LUCI CQ, Sadrul Chowdhury, AyeAye, scheduler...@chromium.org, jophba...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blink-re...@chromium.org, omnibox-...@chromium.org, blink-revie...@chromium.org, srahim...@chromium.org, net-r...@chromium.org, browser-comp...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, asvitki...@chromium.org, sloboda...@chromium.org, android-web...@chromium.org, wnwen...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, niharm...@google.com, blink-revie...@chromium.org, spang...@chromium.org, jmedle...@chromium.org, feature-me...@chromium.org, peilinwa...@google.com, fenced-fra...@chromium.org, network-ser...@chromium.org, ananyasee...@google.com, cc-...@chromium.org, ios-revie...@chromium.org, blink-...@chromium.org, telemetr...@chromium.org, mac-r...@chromium.org, scheduler-b...@chromium.org
Attention needed from Gabriel Charette

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review+1

1 comment

Patchset-level comments
Etienne Pierre-Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Gabriel Charette
Gerrit-Comment-Date: Thu, 12 Mar 2026 02:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Gabriel Charette (Gerrit)

unread,
Mar 20, 2026, 11:52:19 AM (13 days ago) Mar 20
to Gabriel Charette, Etienne Pierre-Doray, Elly FJ, Hu, Ningxin, Sam Zackrisson, Jiewei Qian, Kentaro Hara, Per Åhgren, Raphael Kubo da Costa, Ale Bzk, Chromium Metrics Reviews, Chromium LUCI CQ, Sadrul Chowdhury, AyeAye, scheduler...@chromium.org, jophba...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blink-re...@chromium.org, omnibox-...@chromium.org, blink-revie...@chromium.org, srahim...@chromium.org, net-r...@chromium.org, browser-comp...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, asvitki...@chromium.org, sloboda...@chromium.org, android-web...@chromium.org, wnwen...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, niharm...@google.com, blink-revie...@chromium.org, spang...@chromium.org, jmedle...@chromium.org, feature-me...@chromium.org, peilinwa...@google.com, fenced-fra...@chromium.org, network-ser...@chromium.org, ananyasee...@google.com, cc-...@chromium.org, ios-revie...@chromium.org, blink-...@chromium.org, telemetr...@chromium.org, mac-r...@chromium.org, scheduler-b...@chromium.org

Gabriel Charette voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Fri, 20 Mar 2026 15:52:10 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Mar 20, 2026, 1:19:36 PM (13 days ago) Mar 20
to Gabriel Charette, Etienne Pierre-Doray, Elly FJ, Hu, Ningxin, Sam Zackrisson, Jiewei Qian, Kentaro Hara, Per Åhgren, Raphael Kubo da Costa, Ale Bzk, Chromium Metrics Reviews, Sadrul Chowdhury, AyeAye, scheduler...@chromium.org, jophba...@chromium.org, tracing...@chromium.org, agriev...@chromium.org, blink-re...@chromium.org, omnibox-...@chromium.org, blink-revie...@chromium.org, srahim...@chromium.org, net-r...@chromium.org, browser-comp...@chromium.org, devtools...@chromium.org, asvitkine...@chromium.org, bnc+...@chromium.org, kinuko...@chromium.org, hanxi...@chromium.org, wfh+...@chromium.org, asvitki...@chromium.org, sloboda...@chromium.org, android-web...@chromium.org, wnwen...@chromium.org, marq+...@chromium.org, ios-r...@chromium.org, niharm...@google.com, blink-revie...@chromium.org, spang...@chromium.org, jmedle...@chromium.org, feature-me...@chromium.org, peilinwa...@google.com, fenced-fra...@chromium.org, network-ser...@chromium.org, ananyasee...@google.com, cc-...@chromium.org, ios-revie...@chromium.org, blink-...@chromium.org, telemetr...@chromium.org, mac-r...@chromium.org, scheduler-b...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Refactor: Use uintptr_t for opaque event/task identifiers

This change updates the responsiveness monitoring system to use
uintptr_t instead of const void* for opaque identifiers of tasks and
native events. This adds the ability to cover event id's that aren't
inherited from pointers.

Also rename NativeEventObserver::Will/DidDispatchMSG to
Will/DidRunNativeEvent as we will expand coverage beyond DispatchMessage
in a follow-up. This aligns with naming on Mac.
Bug: 488393677
Change-Id: I708d056ea93eb19a7010882c9847e97c902dcda1
Reviewed-by: Elly FJ <elly...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Gabriel Charette <g...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1602702}
Files:
  • M base/message_loop/message_pump_win.cc
  • M base/message_loop/message_pump_win.h
  • M content/browser/scheduler/responsiveness/jank_monitor_impl.cc
  • M content/browser/scheduler/responsiveness/jank_monitor_impl.h
  • M content/browser/scheduler/responsiveness/metric_source.h
  • M content/browser/scheduler/responsiveness/metric_source_unittest.cc
  • M content/browser/scheduler/responsiveness/native_event_observer.cc
  • M content/browser/scheduler/responsiveness/native_event_observer.h
  • M content/browser/scheduler/responsiveness/native_event_observer_browsertest.mm
  • M content/browser/scheduler/responsiveness/native_event_observer_browsertest_win.cc
  • M content/browser/scheduler/responsiveness/native_event_observer_mac.mm
  • M content/browser/scheduler/responsiveness/watcher.cc
  • M content/browser/scheduler/responsiveness/watcher.h
  • M content/browser/scheduler/responsiveness/watcher_unittest.cc
  • M content/public/browser/native_event_processor_observer_mac.h
  • M content/public/browser/native_event_processor_observer_mac.mm
Change size: M
Delta: 16 files changed, 114 insertions(+), 98 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray, +1 by Elly FJ
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I708d056ea93eb19a7010882c9847e97c902dcda1
Gerrit-Change-Number: 7621317
Gerrit-PatchSet: 31
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Elly FJ <elly...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages