partition_alloc: merge buildflags.h #cleanup [chromium/src : main]

0 views
Skip to first unread message

danakj (Gerrit)

unread,
Jun 20, 2024, 11:39:32 AM (11 days ago) Jun 20
to Arthur Sonzogni, Keishi Hattori, Tricium, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Zijie He, alexmo...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, chromiumme...@microsoft.com, kinuko...@chromium.org, creis...@chromium.org, ios-r...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, net-r...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, grt+...@chromium.org, ios-revie...@chromium.org, bartek...@chromium.org, blundell+...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, glazuno...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Arthur Sonzogni and Keishi Hattori

danakj voted and added 1 comment

Votes added by danakj

Code-Review+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
  • Keishi Hattori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Gerrit-Change-Number: 5630428
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Thu, 20 Jun 2024 15:39:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

danakj (Gerrit)

unread,
Jun 20, 2024, 11:39:52 AM (11 days ago) Jun 20
to Arthur Sonzogni, Keishi Hattori, Tricium, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Zijie He, alexmo...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, chromiumme...@microsoft.com, kinuko...@chromium.org, creis...@chromium.org, ios-r...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, net-r...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, grt+...@chromium.org, ios-revie...@chromium.org, bartek...@chromium.org, blundell+...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, glazuno...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Arthur Sonzogni and Keishi Hattori

danakj voted and added 1 comment

Votes added by danakj

Code-Review+0
Owners-Override+1

1 comment

Patchset-level comments
danakj . resolved

OO for non-PA parts. Keishi can review PA parts

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
  • Keishi Hattori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Gerrit-Change-Number: 5630428
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Thu, 20 Jun 2024 15:39:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Jun 25, 2024, 4:06:40 AM (6 days ago) Jun 25
to danakj, Keishi Hattori, Tricium, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Zijie He, alexmo...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, chromiumme...@microsoft.com, kinuko...@chromium.org, creis...@chromium.org, ios-r...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, net-r...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, grt+...@chromium.org, ios-revie...@chromium.org, bartek...@chromium.org, blundell+...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, glazuno...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Keishi Hattori

Arthur Sonzogni added 1 comment

Patchset-level comments
Arthur Sonzogni . resolved

Keishi, gentle ping ;-)

Open in Gerrit

Related details

Attention is currently required from:
  • Keishi Hattori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Gerrit-Change-Number: 5630428
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: Keishi Hattori <kei...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 08:06:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Keishi Hattori (Gerrit)

unread,
Jun 25, 2024, 1:53:25 PM (6 days ago) Jun 25
to Arthur Sonzogni, danakj, Tricium, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Zijie He, alexmo...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, chromiumme...@microsoft.com, kinuko...@chromium.org, creis...@chromium.org, ios-r...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, net-r...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, grt+...@chromium.org, ios-revie...@chromium.org, bartek...@chromium.org, blundell+...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, glazuno...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Arthur Sonzogni and danakj

Keishi Hattori voted and added 1 comment

Votes added by Keishi Hattori

Code-Review+1
Owners-Override+1

1 comment

Patchset-level comments
File-level comment, Patchset 9 (Latest):
Keishi Hattori . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Arthur Sonzogni
  • danakj
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Gerrit-Change-Number: 5630428
Gerrit-PatchSet: 9
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: danakj <dan...@chromium.org>
Gerrit-Attention: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 17:53:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Jun 25, 2024, 2:12:17 PM (6 days ago) Jun 25
to Keishi Hattori, danakj, Tricium, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Zijie He, alexmo...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, chromiumme...@microsoft.com, kinuko...@chromium.org, creis...@chromium.org, ios-r...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, net-r...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, grt+...@chromium.org, ios-revie...@chromium.org, bartek...@chromium.org, blundell+...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, glazuno...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from danakj

Arthur Sonzogni voted and added 1 comment

Votes added by Arthur Sonzogni

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Arthur Sonzogni . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • danakj
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Gerrit-Change-Number: 5630428
Gerrit-PatchSet: 10
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: danakj <dan...@chromium.org>
Gerrit-Comment-Date: Tue, 25 Jun 2024 18:12:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Arthur Sonzogni (Gerrit)

unread,
Jun 26, 2024, 4:13:18 AM (5 days ago) Jun 26
to Keishi Hattori, danakj, Tricium, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Zijie He, alexmo...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, chromiumme...@microsoft.com, kinuko...@chromium.org, creis...@chromium.org, ios-r...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, net-r...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, grt+...@chromium.org, ios-revie...@chromium.org, bartek...@chromium.org, blundell+...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, glazuno...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from danakj

Arthur Sonzogni voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • danakj
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Gerrit-Change-Number: 5630428
Gerrit-PatchSet: 11
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Zijie He <zij...@google.com>
Gerrit-Attention: danakj <dan...@chromium.org>
Gerrit-Comment-Date: Wed, 26 Jun 2024 08:13:01 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 26, 2024, 4:16:52 AM (5 days ago) Jun 26
to Arthur Sonzogni, Keishi Hattori, danakj, Tricium, AyeAye, chromium...@chromium.org, Kentaro Hara, Zijie He, alexmo...@chromium.org, blink-re...@chromium.org, feature-me...@chromium.org, chromiumme...@microsoft.com, kinuko...@chromium.org, creis...@chromium.org, ios-r...@chromium.org, oshima...@chromium.org, asvitki...@chromium.org, net-r...@chromium.org, marq+...@chromium.org, blink-...@chromium.org, navigation...@chromium.org, grt+...@chromium.org, ios-revie...@chromium.org, bartek...@chromium.org, blundell+...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, gavinp...@chromium.org, glazuno...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, mac-r...@chromium.org, mpdento...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change with unreviewed changes

Unreviewed changes

9 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
partition_alloc: merge buildflags.h #cleanup

partition_alloc has 5 different buildflags headers, but there isn't a
need to maintain multiple:
- All of them were anyway grouped under the "buildflags" target.
- All of them are included in every files via the `raw_ptr.h` file.

To keep things simpler to maintain, this merges them all.

This is #cleanup.

Why No-Try: It seems touching some PA files causes the CQ to run too
many tests and they are slower on the CQ due to option gathering code
coverage. As an example, adding empty lines causes the same failure:
https://chromium-review.googlesource.com/c/chromium/src/+/5513777
Feel free to revert this patch if some a bots fails two consecutive
run.
No-try: true
Bug: 41481467
Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Reviewed-by: Keishi Hattori <kei...@chromium.org>
Owners-Override: Keishi Hattori <kei...@chromium.org>
Commit-Queue: Arthur Sonzogni <arthurs...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1319627}
Files:
  • M base/allocator/allocator_check.cc
  • M base/allocator/dispatcher/dispatcher.cc
  • M base/allocator/dispatcher/dispatcher_unittest.cc
  • M base/allocator/dispatcher/internal/dispatch_data.cc
  • M base/allocator/dispatcher/internal/dispatch_data.h
  • M base/allocator/dispatcher/internal/dispatcher_internal.h
  • M base/allocator/dispatcher/internal/dispatcher_internal_unittest.cc
  • M base/allocator/dispatcher/notification_data.h
  • M base/allocator/early_zone_registration_apple.cc
  • M base/allocator/partition_alloc_features.cc
  • M base/allocator/partition_alloc_features.h
  • M base/allocator/partition_alloc_support.cc
  • M base/allocator/partition_alloc_support.h
  • M base/allocator/partition_alloc_support_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/BUILD.gn
  • M base/allocator/partition_allocator/src/partition_alloc/aarch64_support.h
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager.cc
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager.h
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager_bitmap.cc
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager_bitmap.h
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/address_space_randomization.cc
  • M base/allocator/partition_allocator/src/partition_alloc/address_space_randomization_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/address_space_stats.h
  • M base/allocator/partition_allocator/src/partition_alloc/build_config.h
  • M base/allocator/partition_allocator/src/partition_alloc/buildflag_header.gni
  • M base/allocator/partition_allocator/src/partition_alloc/compressed_pointer.cc
  • M base/allocator/partition_allocator/src/partition_alloc/compressed_pointer.h
  • M base/allocator/partition_allocator/src/partition_alloc/compressed_pointer_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/encoded_next_freelist.h
  • M base/allocator/partition_allocator/src/partition_alloc/extended_api.cc
  • M base/allocator/partition_allocator/src/partition_alloc/extended_api.h
  • M base/allocator/partition_allocator/src/partition_alloc/freeslot_bitmap.h
  • M base/allocator/partition_allocator/src/partition_alloc/freeslot_bitmap_constants.h
  • M base/allocator/partition_allocator/src/partition_alloc/freeslot_bitmap_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/gwp_asan_support.h
  • M base/allocator/partition_allocator/src/partition_alloc/in_slot_metadata.h
  • M base/allocator/partition_allocator/src/partition_alloc/memory_reclaimer.cc
  • M base/allocator/partition_allocator/src/partition_alloc/memory_reclaimer_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/page_allocator.h
  • M base/allocator/partition_allocator/src/partition_alloc/page_allocator_internals_posix.cc
  • M base/allocator/partition_allocator/src/partition_alloc/page_allocator_internals_posix.h
  • M base/allocator/partition_allocator/src/partition_alloc/page_allocator_internals_win.h
  • M base/allocator/partition_allocator/src/partition_alloc/page_allocator_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_address_space.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_address_space.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc-inl.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_allocation_data.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/apple/mach_logging.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/check.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace_linux.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/debug/stack_trace_mac.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/fuchsia/fuchsia_logging.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/fuchsia/fuchsia_logging_pa_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/log_message.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/logging.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/logging_pa_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/memory/ref_counted.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/memory/ref_counted.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/strings/cstring_builder.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/thread_annotations.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_posix.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_posix_for_testing.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/threading/platform_thread_win_for_testing.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/time/time.h
  • A base/allocator/partition_allocator/src/partition_alloc/partition_alloc_buildflags.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_check.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_config.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_constants.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_forward.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_bucket.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_bucket_lookup.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_cookie.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_freelist_entry.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_lock.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_lock_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_page.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_page.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_root.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_root.h
  • M base/allocator/partition_allocator/src/partition_alloc/partition_stats.h
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/instance_tracer.h
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr.h
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_asan_unowned_impl.h
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_backup_ref_impl.cc
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_backup_ref_impl.h
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_exclusion.h
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_hookable_impl.h
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_nocompile.nc
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ptr_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ref.h
  • M base/allocator/partition_allocator/src/partition_alloc/pointers/raw_ref_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/pool_offset_freelist.h
  • M base/allocator/partition_allocator/src/partition_alloc/reservation_offset_table.cc
  • M base/allocator/partition_allocator/src/partition_alloc/reservation_offset_table.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_interception_apple.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_interception_apple.mm
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_interception_apple_unittest.mm
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_android.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_apple.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_partition_alloc.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_partition_alloc.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_default_dispatch_to_partition_alloc_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_override_apple_default_zone.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_override_apple_symbols.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_override_cpp_symbols.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_override_glibc_weak_symbols.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_override_libc_symbols.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_override_linker_wrapped_symbols.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_override_ucrt_symbols_win.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_win_component.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/allocator_shim_win_static.cc
  • M base/allocator/partition_allocator/src/partition_alloc/shim/malloc_zone_functions_apple.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/nonscannable_allocator.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/shim_alloc_functions.h
  • M base/allocator/partition_allocator/src/partition_alloc/shim/winheap_stubs_win.h
  • M base/allocator/partition_allocator/src/partition_alloc/stack/stack.cc
  • M base/allocator/partition_allocator/src/partition_alloc/starscan/pcscan_internal.cc
  • M base/allocator/partition_allocator/src/partition_alloc/starscan/pcscan_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/starscan/scan_loop.h
  • M base/allocator/partition_allocator/src/partition_alloc/starscan/scan_loop_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/tagging.cc
  • M base/allocator/partition_allocator/src/partition_alloc/tagging.h
  • M base/allocator/partition_allocator/src/partition_alloc/tagging_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/thread_cache.cc
  • M base/allocator/partition_allocator/src/partition_alloc/thread_cache.h
  • M base/allocator/partition_allocator/src/partition_alloc/thread_cache_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/thread_isolation/alignment.h
  • M base/allocator/partition_allocator/src/partition_alloc/thread_isolation/pkey.h
  • M base/allocator/partition_allocator/src/partition_alloc/thread_isolation/pkey_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/thread_isolation/thread_isolation.h
  • M base/functional/bind_internal.h
  • M base/functional/bind_unittest.cc
  • M base/memory/nonscannable_memory.cc
  • M base/memory/raw_ptr_asan_bound_arg_tracker.cc
  • M base/memory/raw_ptr_asan_bound_arg_tracker.h
  • M base/memory/raw_ptr_asan_hooks.h
  • M base/memory/raw_ptr_asan_service.h
  • M base/memory/raw_ptr_asan_unittest.cc
  • M base/memory/safety_checks.h
  • M base/process/memory.cc
  • M base/process/memory_fuchsia.cc
  • M base/process/memory_linux.cc
  • M base/process/memory_mac.mm
  • M base/process/memory_unittest.cc
  • M base/process/memory_win.cc
  • M base/security_unittest.cc
  • M base/task/thread_pool/worker_thread.cc
  • M base/task/thread_pool/worker_thread_waitable_event_unittest.cc
  • M base/test/test_suite.cc
  • M base/threading/platform_thread_posix.cc
  • M base/threading/platform_thread_win.cc
  • M base/threading/sequence_local_storage_map_unittest.cc
  • M base/trace_event/address_space_dump_provider.cc
  • M base/trace_event/malloc_dump_provider.cc
  • M base/trace_event/malloc_dump_provider.h
  • M base/trace_event/memory_dump_manager.cc
  • M base/trace_event/memory_infra_background_allowlist.cc
  • M build/rust/tests/test_cpp_including_rust/shared_unittests.cc
  • M build/rust/tests/test_cpp_including_rust/static_unittests.cc
  • M chrome/app/chrome_main.cc
  • M chrome/browser/metrics/process_memory_metrics_emitter.cc
  • M chrome/browser/metrics/process_memory_metrics_emitter_browsertest.cc
  • M chrome/browser/profiling_host/memlog_browsertest.cc
  • M chrome/browser/ui/webui/memory_internals_ui.cc
  • M chrome/installer/setup/memory_unittest.cc
  • M chromeos/ash/components/memory/userspace_swap/userspace_swap.cc
  • M chromeos/ash/components/memory/userspace_swap/userspace_swap_unittest.cc
  • M components/crash/core/app/crashpad_android.cc
  • M components/cronet/native/test/buffer_test.cc
  • M components/gwp_asan/client/extreme_lightweight_detector_malloc_shims_unittest.cc
  • M components/gwp_asan/client/guarded_page_allocator.cc
  • M components/gwp_asan/client/gwp_asan.cc
  • M components/gwp_asan/client/lightweight_detector/partitionalloc_shims_unittest.cc
  • M components/gwp_asan/client/sampling_malloc_shims_unittest.cc
  • M components/memory_system/memory_system.cc
  • M components/services/heap_profiling/public/cpp/profiling_client.cc
  • M components/services/heap_profiling/public/cpp/settings.cc
  • M components/services/heap_profiling/public/cpp/switches_unittest.cc
  • M content/app/content_main.cc
  • M content/browser/web_contents/web_contents_impl.cc
  • M content/browser/web_contents/web_contents_impl.h
  • M content/browser/web_contents/web_contents_impl_browsertest.cc
  • M gin/public/v8_platform.h
  • M gin/thread_isolation.h
  • M gin/v8_platform.cc
  • M gin/v8_platform_page_allocator.h
  • M gin/v8_platform_thread_isolated_allocator.h
  • M ios/chrome/app/early_pa_registration.cc
  • M media/base/media.cc
  • M third_party/blink/renderer/platform/wtf/allocator/partitions.cc
  • M third_party/crashpad/crashpad/test/multiprocess_exec_test.cc
  • M third_party/crashpad/crashpad/util/linux/memory_map_test.cc
  • M tools/memory/partition_allocator/pa_dump_heap.cc
Change size: L
Delta: 200 files changed, 322 insertions(+), 375 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Keishi Hattori
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56a30e5bb453c19a8d262f7a19b3d76ecae23a26
Gerrit-Change-Number: 5630428
Gerrit-PatchSet: 12
Gerrit-Owner: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Arthur Sonzogni <arthurs...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Keishi Hattori <kei...@chromium.org>
Gerrit-Reviewer: danakj <dan...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages