[tracing] Add Etw scenario to default scenario presets [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Feb 10, 2026, 2:04:17 PMFeb 10
to Etienne Bergeron, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Bergeron
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Etienne Bergeron
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Bergeron (Gerrit)
Feb 10, 2026, 2:09:18 PMFeb 10
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Etienne Bergeron voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Feb 10, 2026, 2:10:40 PMFeb 10
to Etienne Bergeron, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Feb 10, 2026, 2:39:39 PMFeb 10
to Etienne Bergeron, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 10, 2026, 4:58:17 PMFeb 10
to Etienne Pierre-Doray, Etienne Bergeron, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
3 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: components/tracing/common/tracing_scenarios_config.cc
Insertions: 3, Deletions: 2.
@@ -263,10 +263,11 @@
*config.add_scenarios() = CreateDefaultPresetTracingScenarioConfig(
"AlwaysOnScenario", kAlwaysOnScenarioDescription,
CreateDefaultPresetTracingConfig());
-#if BUILDFLAG(IS_WIN)
- *config.add_scenarios() = CreateDefaultPresetTracingScenarioConfig(
+ [[maybe_unused]] auto etw_config = CreateDefaultPresetTracingScenarioConfig(
"AlwaysOnScenarioWithEtw", kAlwaysOnScenarioWithEtwDescription,
CreatePresetTracingConfigWithEtw());
+#if BUILDFLAG(IS_WIN)
+ *config.add_scenarios() = etw_config;
#endif // BUILDFLAG(IS_WIN)
return config;
}
```
Change information
Commit message:
[tracing] Add Etw scenario to default scenario presets
This adds config for AlwaysOnScenarioWithEtw in chrome://traces
on Windows.
Change-Id: I921416a66ad3a15fa024696dde112e291349cd6f
Reviewed-by: Etienne Bergeron <etie...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1582797}
Files:
- M components/tracing/common/tracing_scenarios_config.cc
Change size: M
Delta: 1 file changed, 104 insertions(+), 65 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Bergeron
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages