[tracing] Fold file tracing directly into base/ using Perfetto Flows. [chromium/src : main]
3 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
May 21, 2026, 5:38:53 PMMay 21
to Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Gabriel Charette
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Gabriel Charette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Gabriel Charette (Gerrit)
May 21, 2026, 9:02:17 PMMay 21
to Etienne Pierre-Doray, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Gabriel Charette voted and added 1 comment![]( "Open in Gerrit")
Votes added by Gabriel Charette
| Code-Review | +1 |
1 comment
Patchset-level comments
Gabriel Charette . resolved
I think I like it, can you add screenshot links (e.g. snipboard.io) of before/after in the Perfetto UI to the CL desc?
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 22, 2026, 10:15:25 AMMay 22
to Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +2 |
Gabriel Charette . resolved
I think I like it, can you add screenshot links (e.g. snipboard.io) of before/after in the Perfetto UI to the CL desc?
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 22, 2026, 10:19:10 AMMay 22
to Etienne Pierre-Doray, Gabriel Charette, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
[tracing] Fold file tracing directly into base/ using Perfetto Flows.
Track::FromPointer is problematic because they alias due to
pointer reuse. Meanwhile, those events are synchronous.
This CL simplifies file tracing to emit events directly,
on-thread, and uses flow to link operations for the same file.
ScopedEnabler events are removed because they are redundant.
Before: https://screenshot.googleplex.com/8gPBRVaoYatjQj4
After: https://screenshot.googleplex.com/6WoJ9yRwnYWrrtY
Change-Id: Ieca84bc9f27c68eddf92e701a85521f59c123c24
Reviewed-by: Gabriel Charette <g...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1634927}
Files:
- M base/BUILD.gn
- M base/files/file.cc
- M base/files/file.h
- M base/files/file_posix.cc
- D base/files/file_tracing.cc
- M base/files/file_tracing.h
- M base/files/file_win.cc
- M content/browser/BUILD.gn
- D content/browser/tracing/file_tracing_provider_impl.cc
- D content/browser/tracing/file_tracing_provider_impl.h
- M content/browser/tracing/tracing_controller_impl.cc
Change size: L
Delta: 11 files changed, 10 insertions(+), 242 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Gabriel Charette
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages