[base] Add feature to group MemoryDumpProviders which can run on same sequence. [chromium/src : main]
0 views
Skip to first unread message
Francois Pierre Doray (Gerrit)
Feb 2, 2026, 1:33:39 PMFeb 2
to Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Joe Mason
Francois Pierre Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Feb 2, 2026, 4:46:29 PMFeb 2
to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Francois Pierre Doray
Joe Mason voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Feb 2, 2026, 4:46:46 PMFeb 2
to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Francois Pierre Doray
Joe Mason voted Code-Review+0![]( "Open in Gerrit")
| Code-Review | +0 |
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Feb 2, 2026, 4:48:38 PMFeb 2
to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Francois Pierre Doray
Joe Mason voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Francois Pierre Doray (Gerrit)
Feb 2, 2026, 4:52:54 PMFeb 2
to Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Francois Pierre Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 2, 2026, 5:01:05 PMFeb 2
to Francois Pierre Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[base] Add feature to group MemoryDumpProviders which can run on same sequence.
Previously, MemoryDumpManager::CreateProcessDump ran this algorithm:
1. Group all MemoryDumpProviders by TaskRunner.
2. Get the next MemoryDumpProvider.
3. Is it bound to a TaskRunner which RunsTasksInCurrentSequence?
If yes: Go to step 4.
If no: Go to step 5.
4. Run the MemoryDumpProvider, remove it from the list,
and go back to step 2.
5. Post a task to the MemoryDumpProvider's TaskRunner,
and go back to step 2.
This algorithm did not attempt to group MemoryDumpProviders associated
with different TaskRunners which can run on the same sequence. This
could result in:
- More task posting than necessary
- If a MemoryDumpProvider is associated with a frozen TaskRunner,
it would not run, even if its TaskRunner indicates that it
could have run synchronously as part of the initial
MemoryDumpManager::CreateProcessDump call.
This CL solves these problem by introducing a feature which groups
MemoryDumpProvider which can run on the same sequence together (even if
that's through different TaskRunners).
Bug: 450929521
Change-Id: Id2a7e6fa147ce663d44f921c7a9c646e09f78f9f
Reviewed-by: Joe Mason <joenot...@google.com>
Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1578380}
Files:
- M base/trace_event/measured_memory_dump_provider_info.cc
- M base/trace_event/measured_memory_dump_provider_info.h
- M base/trace_event/memory_dump_manager.cc
Change size: M
Delta: 3 files changed, 65 insertions(+), 36 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Mason
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Robert Liao (Gerrit)
Feb 23, 2026, 4:45:01 PM (4 days ago) Feb 23
to Chromium LUCI CQ, Francois Pierre Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Francois Pierre Doray
Robert Liao added 2 comments![]( "Open in Gerrit")
File base/trace_event/measured_memory_dump_provider_info.cc
Line 28, Patchset 9 (Latest):
CHECK(num_following_providers_.has_value());Robert Liao . unresolved
This CL would be safer to merge without this CHECK. Have a graceful failure or some way of indicating an error condition for `Memory.DumpProvider.FollowingProviders3.`
File base/trace_event/memory_dump_manager.cc
Line 372, Patchset 9 (Latest):
auto get_effective_task_runner = [&](const MeasuredMemoryDumpProviderInfo&
mdpinfo) {Robert Liao . unresolved
Are these changes absolutely required to gather metrics?
This sort of structural change dramatically increases the risk.
For a metrics FP++ merge, keep the changes as minimal as possible, excluding any proactive cleanup as well.
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Feb 24, 2026, 11:09:00 AM (4 days ago) Feb 24
to Chromium LUCI CQ, Francois Pierre Doray, Robert Liao, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Francois Pierre Doray
Joe Mason added 1 comment![]( "Open in Gerrit")
File base/trace_event/memory_dump_manager.cc
Line 372, Patchset 9 (Latest):
auto get_effective_task_runner = [&](const MeasuredMemoryDumpProviderInfo&
mdpinfo) {Robert Liao . unresolved
Are these changes absolutely required to gather metrics?
This sort of structural change dramatically increases the risk.
For a metrics FP++ merge, keep the changes as minimal as possible, excluding any proactive cleanup as well.
Joe Mason
Ack, withdrew the FP++ request.
Related details
Attention is currently required from:
- Francois Pierre Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages