Convert remaining base/ API's to ByteSize [chromium/src : main]

0 views
Skip to first unread message

Joe Mason (Gerrit)

unread,
Dec 18, 2025, 1:35:34 PM (2 days ago) Dec 18
to chromium...@chromium.org, agriev...@chromium.org, cblume...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Joe Mason voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a92572cf7c088a8c5ebfeee2ee70414c53928e6
Gerrit-Change-Number: 7275528
Gerrit-PatchSet: 1
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Thu, 18 Dec 2025 18:35:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Francois Pierre Doray (Gerrit)

unread,
Dec 19, 2025, 10:59:45 AM (yesterday) Dec 19
to Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, cblume...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Joe Mason

Francois Pierre Doray voted and added 2 comments

Votes added by Francois Pierre Doray

Code-Review+1
Commit-Queue+2
Owners-Override+1

2 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Francois Pierre Doray . resolved

LGTM with comment
OO+1 for mechanical changes outside of //base to adapt to a //base API change

File base/android/pmf_utils.cc
Line 62, Patchset 2 (Latest):
Francois Pierre Doray . resolved

Follow-up: 

```
  const uint64_t private_pages = resident_pages - shared_pages;
  return ByteSize(page_size) * private_pages + KiBU(swap_footprint_kb);
```

Reason: `private_pages` is expressed in pages, not bytes, so it shouldn't use the ByteSize or ByteSizeDelta type.

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a92572cf7c088a8c5ebfeee2ee70414c53928e6
Gerrit-Change-Number: 7275528
Gerrit-PatchSet: 2
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Fri, 19 Dec 2025 15:59:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Dec 19, 2025, 11:08:36 AM (yesterday) Dec 19
to Francois Pierre Doray, chromium...@chromium.org, agriev...@chromium.org, cblume...@chromium.org, chrome-gr...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, penghuan...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Convert remaining base/ API's to ByteSize

Converts the following API's to use ByteCount instead of ByteSize, and
updates all callers:

base::android::PmfUtils::GetPrivateMemoryFootprintForCurrentProcess
base::android::PreFreezeMetric::Measure
base::debug::ReadAndParseSmapsRollup
base::trace_event::GetTraceBufferSizeInBytes
base::trace_event::SetTraceBufferSizeInBytes

Also converts misc uses of ByteCount in .cc files to ByteSize.

With this, the only uses of ByteCount in base/ are
SysInfo::AmountOfPhysicalMemory(), which is marked deprecated
(AmountOfTotalPhysicalMemory() is the ByteSize alternative), and
UmaHistogramMemory functions that have ByteSize and ByteCount overloads.
Bug: 448661443
Change-Id: I7a92572cf7c088a8c5ebfeee2ee70414c53928e6
Reviewed-by: Francois Pierre Doray <fdo...@chromium.org>
Owners-Override: Francois Pierre Doray <fdo...@chromium.org>
Auto-Submit: Joe Mason <joenot...@google.com>
Commit-Queue: Francois Pierre Doray <fdo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1561159}
Files:
  • M base/android/pmf_utils.cc
  • M base/android/pmf_utils.h
  • M base/android/pmf_utils_unittest.cc
  • M base/android/pre_freeze_background_memory_trimmer.cc
  • M base/android/pre_freeze_background_memory_trimmer.h
  • M base/android/pre_freeze_background_memory_trimmer_unittest.cc
  • M base/android/self_compaction_manager.cc
  • M base/android/self_compaction_manager.h
  • M base/debug/proc_maps_linux.cc
  • M base/debug/proc_maps_linux.h
  • M base/debug/stack_trace.cc
  • M base/nix/mime_util_xdg.cc
  • M base/trace_event/trace_config.cc
  • M base/trace_event/trace_config.h
  • M base/trace_event/trace_log.cc
  • M gpu/vulkan/vulkan_device_queue.cc
  • M services/resource_coordinator/public/cpp/memory_instrumentation/os_metrics_linux.cc
  • M services/tracing/public/cpp/perfetto/perfetto_config.cc
Change size: M
Delta: 18 files changed, 83 insertions(+), 75 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Francois Pierre Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a92572cf7c088a8c5ebfeee2ee70414c53928e6
Gerrit-Change-Number: 7275528
Gerrit-PatchSet: 3
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages