[tracing] Add synchronization on EtwSystemDataSource tear down [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Oct 15, 2025, 4:10:34 PMOct 15
to Sean Maher, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Sean Maher
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Sean Maher
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Maher (Gerrit)
Oct 15, 2025, 4:43:20 PMOct 15
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Sean Maher added 1 comment![]( "Open in Gerrit")
File components/tracing/common/etw_consumer_win.h
Line 56, Patchset 3 (Latest):
void Flush(std::function<void()> callback);Sean Maher . unresolved
Can you add a few docs as to how it's expected to be used?
it's a little confusing if Flush() both isn't commonly called and expectations aren't specified as to why it might be necessary
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Maher (Gerrit)
Oct 15, 2025, 4:45:38 PMOct 15
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Sean Maher voted![]( "Open in Gerrit")
| Code-Review | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Sean Maher (Gerrit)
Oct 15, 2025, 4:46:24 PMOct 15
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Sean Maher added 1 comment![]( "Open in Gerrit")
Commit Message
Line 9, Patchset 3 (Latest):
This CL ensures EtwConsumer flushes data when a tracing session ends.Sean Maher . unresolved
maybe specify that Perfetto takes a `std::function`, and that's why we need the presubmit change
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Oct 16, 2025, 9:55:06 AMOct 16
to Daniel Cheng, Sean Maher, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng
Etienne Pierre-Doray added 3 comments![]( "Open in Gerrit")
Patchset-level comments
Commit Message
Line 9, Patchset 3:
This CL ensures EtwConsumer flushes data when a tracing session ends.Sean Maher . resolved
maybe specify that Perfetto takes a `std::function`, and that's why we need the presubmit change
Etienne Pierre-Doray
Done
File components/tracing/common/etw_consumer_win.h
Can you add a few docs as to how it's expected to be used?
it's a little confusing if Flush() both isn't commonly called and expectations aren't specified as to why it might be necessary
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Oct 16, 2025, 4:35:17 PMOct 16
to Etienne Pierre-Doray, Daniel Cheng, Sean Maher, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Daniel Cheng voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Oct 16, 2025, 5:12:02 PMOct 16
to Daniel Cheng, Sean Maher, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Oct 16, 2025, 6:22:39 PMOct 16
to Etienne Pierre-Doray, Daniel Cheng, Sean Maher, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Add synchronization on EtwSystemDataSource tear down
This CL ensures EtwConsumer flushes data when a tracing session ends.
Perfetto API forces us to use std::function, which requires a change in
PRESUBMIT.py
Change-Id: Ia3d346521feaa309f828a713b5b9384abbebb23b
Reviewed-by: Sean Maher <sp...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1531101}
Files:
- M PRESUBMIT.py
- M components/tracing/common/etw_consumer_win.cc
- M components/tracing/common/etw_consumer_win.h
- M components/tracing/common/etw_system_data_source_win.cc
Change size: S
Delta: 4 files changed, 19 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Sean Maher, +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages