[tracing] Only record app package name for system or Play Store apps [chromium/src : main]

1 view
Skip to first unread message

Sayed Elabady (Gerrit)

unread,
Apr 22, 2026, 11:29:44 AM (4 days ago) Apr 22
to Andrew Grieve, Chromium IPC Reviews, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, ipc-securi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Andrew Grieve, Chromium IPC Reviews and Eric Seckler

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Chromium IPC Reviews
  • Eric Seckler
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I153c4bc0e25c426abd233fb8c801eed88956f693
Gerrit-Change-Number: 7785952
Gerrit-PatchSet: 2
Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-Attention: Eric Seckler <esec...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Apr 2026 15:29:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

gwsq (Gerrit)

unread,
Apr 22, 2026, 11:31:31 AM (4 days ago) Apr 22
to Sayed Elabady, Chromium IPC Reviews, Mike West, Andrew Grieve, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, ipc-securi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Andrew Grieve, Eric Seckler and Mike West

Message from gwsq

From googleclient/chrome/chromium_gwsq/ipc/config.gwsq:
IPC: mk...@chromium.org

📎 It looks like you’re making a possibly security-sensitive change! 📎 IPC security review isn’t a rubberstamp, so your friendly security reviewer will need a fair amount of context to review your CL effectively. Please review your CL description and code comments to make sure they provide context for someone unfamiliar with your project/area. Pay special attention to where data comes from and which processes it flows between (and their privilege levels). Feel free to point your security reviewer at design docs, bugs, or other links if you can’t reasonably make a self-contained CL description. (Also see https://cbea.ms/git-commit/).

IPC reviewer(s): mk...@chromium.org


Reviewer source(s):
mk...@chromium.org is from context(googleclient/chrome/chromium_gwsq/ipc/config.gwsq)

Open in Gerrit

Related details

Attention is currently required from:
  • Andrew Grieve
  • Eric Seckler
  • Mike West
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I153c4bc0e25c426abd233fb8c801eed88956f693
Gerrit-Change-Number: 7785952
Gerrit-PatchSet: 2
Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Mike West <mk...@chromium.org>
Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
Gerrit-CC: gwsq
Gerrit-Attention: Andrew Grieve <agr...@chromium.org>
Gerrit-Attention: Mike West <mk...@chromium.org>
Gerrit-Attention: Eric Seckler <esec...@chromium.org>
Gerrit-Comment-Date: Wed, 22 Apr 2026 15:31:23 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Andrew Grieve (Gerrit)

unread,
Apr 22, 2026, 11:32:45 AM (4 days ago) Apr 22
to Sayed Elabady, Andrew Grieve, Chromium IPC Reviews, Mike West, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, ipc-securi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Eric Seckler, Mike West and Sayed Elabady

Andrew Grieve voted and added 1 comment

Votes added by Andrew Grieve

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Andrew Grieve . resolved

base things lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Eric Seckler
  • Mike West
  • Sayed Elabady
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I153c4bc0e25c426abd233fb8c801eed88956f693
    Gerrit-Change-Number: 7785952
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Mike West <mk...@chromium.org>
    Gerrit-Attention: Sayed Elabady <elabad...@chromium.org>
    Gerrit-Attention: Eric Seckler <esec...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Apr 2026 15:32:38 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Mike West (Gerrit)

    unread,
    Apr 23, 2026, 1:20:45 AM (4 days ago) Apr 23
    to Sayed Elabady, Andrew Grieve, Chromium IPC Reviews, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, ipc-securi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
    Attention needed from Eric Seckler and Sayed Elabady

    Mike West voted and added 1 comment

    Votes added by Mike West

    Code-Review+1

    1 comment

    Patchset-level comments
    Mike West . resolved

    ipc lgtm

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Eric Seckler
    • Sayed Elabady
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I153c4bc0e25c426abd233fb8c801eed88956f693
    Gerrit-Change-Number: 7785952
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Sayed Elabady <elabad...@chromium.org>
    Gerrit-Attention: Eric Seckler <esec...@chromium.org>
    Gerrit-Comment-Date: Thu, 23 Apr 2026 05:20:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Eric Seckler (Gerrit)

    unread,
    Apr 24, 2026, 6:48:02 AM (2 days ago) Apr 24
    to Sayed Elabady, Mike West, Andrew Grieve, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, ipc-securi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
    Attention needed from Sayed Elabady

    Eric Seckler voted Code-Review+1

    Code-Review+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Sayed Elabady
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I153c4bc0e25c426abd233fb8c801eed88956f693
    Gerrit-Change-Number: 7785952
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Attention: Sayed Elabady <elabad...@chromium.org>
    Gerrit-Comment-Date: Fri, 24 Apr 2026 10:47:46 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Sayed Elabady (Gerrit)

    unread,
    Apr 24, 2026, 7:39:27 AM (2 days ago) Apr 24
    to Eric Seckler, Mike West, Andrew Grieve, Chromium IPC Reviews, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, ipc-securi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

    Sayed Elabady voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I153c4bc0e25c426abd233fb8c801eed88956f693
    Gerrit-Change-Number: 7785952
    Gerrit-PatchSet: 2
    Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    Gerrit-Comment-Date: Fri, 24 Apr 2026 11:39:09 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Apr 24, 2026, 9:26:34 AM (2 days ago) Apr 24
    to Sayed Elabady, Eric Seckler, Mike West, Andrew Grieve, Chromium IPC Reviews, chromium...@chromium.org, agriev...@chromium.org, ipc-securi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Only record app package name for system or Play Store apps

    MetadataDataSource now filters the application package name to only
    include it when the app is installed as a system app or via the Google
    Play Store. This matches the behavior of AwMetricsServiceClient and
    ensures consistent metadata collection across the codebase.

    To support this, base::android::apk_info is extended to provide the
    is_system_app status in C++, along with test utilities to simulate
    different installation states.

    Changes:
    - base: Add is_system_app and testing utilities to apk_info.
    - tracing: Implement filtering for app package name in MetadataDataSource.
    - tracing: Add MetadataDataSourceTest to verify filtering logic.
    Bug: b:465694294
    Change-Id: I153c4bc0e25c426abd233fb8c801eed88956f693
    Commit-Queue: Sayed Elabady <elabad...@chromium.org>
    Reviewed-by: Andrew Grieve <agr...@chromium.org>
    Reviewed-by: Mike West <mk...@chromium.org>
    Reviewed-by: Eric Seckler <esec...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1620127}
    Files:
    • M base/android/apk_info.cc
    • M base/android/apk_info.h
    • M base/android/java/src/org/chromium/base/ApkInfo.java
    • M base/android/java/src/org/chromium/base/IApkInfo.aidl
    • M services/tracing/BUILD.gn
    • M services/tracing/public/cpp/perfetto/metadata_data_source.cc
    • M services/tracing/public/cpp/perfetto/metadata_data_source.h
    • A services/tracing/public/cpp/perfetto/metadata_data_source_unittest.cc
    Change size: M
    Delta: 8 files changed, 123 insertions(+), 16 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mike West, +1 by Andrew Grieve, +1 by Eric Seckler
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I153c4bc0e25c426abd233fb8c801eed88956f693
    Gerrit-Change-Number: 7785952
    Gerrit-PatchSet: 3
    Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
    Gerrit-Reviewer: Andrew Grieve <agr...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-Reviewer: Mike West <mk...@chromium.org>
    Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
    Gerrit-CC: Chromium IPC Reviews <chrome-ip...@google.com>
    Gerrit-CC: gwsq
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages