Revert "Remove some deprecated base::JSONWriter::Write() calls in //base" [chromium/src : main]

1 view
Skip to first unread message

luci-bisection@appspot.gserviceaccount.com (Gerrit)

unread,
Sep 5, 2025, 3:22:15 AM (4 days ago) Sep 5
to Rubber Stamper, Chromium LUCI CQ, Lei Zhang, Alan Cutter, chromium...@chromium.org, AyeAye, fut...@google.com, scheduler...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Alan Cutter and Lei Zhang

Message from luci-bi...@appspot.gserviceaccount.com

LUCI Bisection could not automatically submit this revert because LUCI Bisection has not yet support auto-commit of revert CL for test failure.

Open in Gerrit

Related details

Attention is currently required from:
  • Alan Cutter
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8430267a298e76fa00c9fccd0eb8397951fcf17a
Gerrit-Change-Number: 6918575
Gerrit-PatchSet: 1
Gerrit-Reviewer: Alan Cutter <alanc...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Alan Cutter <alanc...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Sep 2025 07:22:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rubber Stamper (Gerrit)

unread,
Sep 5, 2025, 3:22:19 AM (4 days ago) Sep 5
to luci-bi...@appspot.gserviceaccount.com, Chromium LUCI CQ, Lei Zhang, Alan Cutter, chromium...@chromium.org, AyeAye, fut...@google.com, scheduler...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Alan Cutter and Lei Zhang

Rubber Stamper voted Bot-Commit+1

Bot-Commit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Alan Cutter
  • Lei Zhang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8430267a298e76fa00c9fccd0eb8397951fcf17a
    Gerrit-Change-Number: 6918575
    Gerrit-PatchSet: 1
    Gerrit-Reviewer: Alan Cutter <alanc...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
    Gerrit-Attention: Lei Zhang <the...@chromium.org>
    Gerrit-Attention: Alan Cutter <alanc...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Sep 2025 07:22:08 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Lei Zhang (Gerrit)

    unread,
    Sep 5, 2025, 1:48:49 PM (4 days ago) Sep 5
    to luci-bi...@appspot.gserviceaccount.com, Lei Zhang, Rubber Stamper, Chromium LUCI CQ, Alan Cutter, chromium...@chromium.org, AyeAye, fut...@google.com, scheduler...@chromium.org, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
    Attention needed from Alan Cutter

    Lei Zhang voted and added 1 comment

    Votes added by Lei Zhang

    Code-Review-1

    1 comment

    Patchset-level comments
    File-level comment, Patchset 1 (Latest):
    Lei Zhang . resolved

    I don't think this CL is responsible. The bot that turned red already went back to green.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Alan Cutter
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is blockingCode-Review
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I8430267a298e76fa00c9fccd0eb8397951fcf17a
      Gerrit-Change-Number: 6918575
      Gerrit-PatchSet: 1
      Gerrit-Reviewer: Alan Cutter <alanc...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
      Gerrit-Reviewer: Rubber Stamper <rubber-...@appspot.gserviceaccount.com>
      Gerrit-Attention: Alan Cutter <alanc...@chromium.org>
      Gerrit-Comment-Date: Fri, 05 Sep 2025 17:48:39 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      blocking_requirement
      open
      diffy
      Reply all
      Reply to author
      Forward
      0 new messages