PA: Report LeakedSecurityObject's type id and total leaked size with MallocDumpProvider [chromium/src : main]
4 views
Skip to first unread message
Takashi Sakamoto (Gerrit)
Jun 30, 2026, 12:12:42 AM (4 days ago) Jun 30
to Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Attention needed from Keishi Hattori
Takashi Sakamoto added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File base/trace_event/malloc_dump_provider.cc
Line 811, Patchset 7 (Latest):
MemoryDumpPartitionStatsDumper::kPartitionsDumpName, type_id);Takashi Sakamoto . unresolved
```
"malloc/partitions/leaked/LeakedSecurityObject/%08x": { "size": ... }
```
Related details
Attention is currently required from:
- Keishi Hattori
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Keishi Hattori (Gerrit)
Jun 30, 2026, 12:21:37 AM (4 days ago) Jun 30
to Takashi Sakamoto, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Attention needed from Takashi Sakamoto
Keishi Hattori voted and added 1 comment![]( "Open in Gerrit")
Votes added by Keishi Hattori
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Takashi Sakamoto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Sakamoto (Gerrit)
Jun 30, 2026, 12:36:00 AM (4 days ago) Jun 30
to Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Takashi Sakamoto added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Takashi Sakamoto . resolved
Thank you for the review.
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Sakamoto (Gerrit)
Jun 30, 2026, 12:36:38 AM (4 days ago) Jun 30
to Lei Zhang, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Attention needed from Lei Zhang
Takashi Sakamoto added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Takashi Sakamoto . resolved
thestig@, would you review this CL?
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 30, 2026, 12:46:41 AM (4 days ago) Jun 30
to Takashi Sakamoto, Lei Zhang, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Attention needed from Takashi Sakamoto
Lei Zhang voted and added 3 comments![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
3 comments
File base/memory/safety_checks_unittest.cc
Line 7, Patchset 7 (Latest):
#include <unordered_map>Lei Zhang . unresolved
Is there a special need to use std::unordered_map instead of a std::map?
Line 310, Patchset 7 (Latest):
reported_leaks.find(TestClass1::kPartitionAllocSanitizedObjectTypeId));Lei Zhang . unresolved
Take the resulting iterator and use ASSERT_NE() here. Then reuse the iterator on line 321.
Line 323, Patchset 7 (Latest):
EXPECT_EQ(1u, reported_leaks.size());Lei Zhang . unresolved
Maybe do this check earlier?
Related details
Attention is currently required from:
- Takashi Sakamoto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Sakamoto (Gerrit)
Jun 30, 2026, 1:13:59 AM (4 days ago) Jun 30
to Lei Zhang, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Attention needed from Lei Zhang
Takashi Sakamoto voted and added 4 comments![]( "Open in Gerrit")
Votes added by Takashi Sakamoto
| Commit-Queue | +1 |
Takashi Sakamoto . resolved
Thank you for the review.
File base/memory/safety_checks_unittest.cc
Line 7, Patchset 7:
#include <unordered_map>Lei Zhang . unresolved
Is there a special need to use std::unordered_map instead of a std::map?
Takashi Sakamoto
No special need, because it's just for testing and the map will contain very few items.
I replaced it with `base::flat_map`. Is it ok? Or `std::map` is better?
Line 310, Patchset 7:
reported_leaks.find(TestClass1::kPartitionAllocSanitizedObjectTypeId));Lei Zhang . resolved
Take the resulting iterator and use ASSERT_NE() here. Then reuse the iterator on line 321.
Takashi Sakamoto
I see. Done
Maybe do this check earlier?
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Jun 30, 2026, 1:19:23 AM (4 days ago) Jun 30
to Takashi Sakamoto, Lei Zhang, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Attention needed from Takashi Sakamoto
Lei Zhang voted and added 1 comment![]( "Open in Gerrit")
Votes added by Lei Zhang
| Code-Review | +1 |
1 comment
File base/memory/safety_checks_unittest.cc
Line 7, Patchset 7:
#include <unordered_map>Lei Zhang . resolved
Takashi SakamotoIs there a special need to use std::unordered_map instead of a std::map?
No special need, because it's just for testing and the map will contain very few items.
I replaced it with `base::flat_map`. Is it ok? Or `std::map` is better?
Attention is currently required from:
- Takashi Sakamoto
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Sakamoto (Gerrit)
Jul 1, 2026, 1:11:57 AM (3 days ago) Jul 1
to Lei Zhang, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Takashi Sakamoto added 2 comments![]( "Open in Gerrit")
Patchset-level comments
Takashi Sakamoto . resolved
Thank you for the review.
File base/trace_event/malloc_dump_provider.cc
Line 811, Patchset 7:
MemoryDumpPartitionStatsDumper::kPartitionsDumpName, type_id);Takashi Sakamoto . resolved
Takashi Sakamoto```
"malloc/partitions/leaked/LeakedSecurityObject/%08x": { "size": ... }
```
Acknowledged
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Takashi Sakamoto (Gerrit)
Jul 1, 2026, 1:11:58 AM (3 days ago) Jul 1
to Lei Zhang, Keishi Hattori, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Takashi Sakamoto voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 1, 2026, 2:39:57 AM (3 days ago) Jul 1
to Takashi Sakamoto, Lei Zhang, Keishi Hattori, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, spang...@chromium.org, gavinp...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
PA: Report LeakedSecurityObject's type id and total leaked size with MallocDumpProvider
MallocDumpProvider uses partition_alloc::DumpIntendedLeakStats() to
report leaked size per each LeakedSecurityObject's type_id. The reported
sizes are based on `slot_size`, not `requested size`. We can see the
data by using tracing with memory-infra.
Bug: 501113274
Change-Id: I5cfd717a6ac75f7fd935c191cdab641bb3a3d7b8
Reviewed-by: Keishi Hattori <kei...@chromium.org>
Reviewed-by: Lei Zhang <the...@chromium.org>
Commit-Queue: Takashi Sakamoto <ta...@google.com>
Cr-Commit-Position: refs/heads/main@{#1655293}
Files:
- M base/memory/safety_checks_unittest.cc
- M base/trace_event/malloc_dump_provider.cc
- M base/trace_event/malloc_dump_provider.h
Change size: M
Delta: 3 files changed, 85 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Lei Zhang, +1 by Keishi Hattori
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages