Record MemoryDumpProvider name in traces [chromium/src : main]

0 views
Skip to first unread message

Joe Mason (Gerrit)

unread,
Feb 19, 2026, 3:39:04 PM (8 days ago) Feb 19
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Joe Mason voted and added 1 comment

Votes added by Joe Mason

Commit-Queue+1

1 comment

Patchset-level comments
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia0757bf803ed354b45c9fe69f5630a1a0fb9e388
Gerrit-Change-Number: 7595714
Gerrit-PatchSet: 3
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Thu, 19 Feb 2026 20:38:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Feb 19, 2026, 4:07:19 PM (8 days ago) Feb 19
to Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Joe Mason

Etienne Pierre-Doray voted and added 2 comments

Votes added by Etienne Pierre-Doray

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 3:
Etienne Pierre-Doray . resolved

LGTM

File base/tracing/protos/chrome_track_event.proto
Line 2814, Patchset 3: // The name of the MemoryDumpProvider object, from the static list in
// `kMemoryDumpProviderNameAllowList` (see
// https://source.chromium.org/chromium/chromium/src/+/main:out/android-Debug/gen/base/trace_event/memory_dump_provider_name_variants.h).
// The provider name is validated against the static list at compile time, at
// https://source.chromium.org/chromium/chromium/src/+/main:base/trace_event/memory_dump_provider.h;l=65;drc=d36832392d30b9cbbd3a6ae8a37e11b92853f041.
optional string name = 1;
Etienne Pierre-Doray . unresolved

That's fine for me, but you'll have to ask review for the gwslog.
If a string here turns out to be an issue, you could use a hash, but IMO you could also just use the static_name as the trace event name for less boilerplate.

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia0757bf803ed354b45c9fe69f5630a1a0fb9e388
Gerrit-Change-Number: 7595714
Gerrit-PatchSet: 3
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Thu, 19 Feb 2026 21:07:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Mason (Gerrit)

unread,
Feb 20, 2026, 12:30:42 PM (7 days ago) Feb 20
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Joe Mason voted and added 1 comment

Votes added by Joe Mason

Commit-Queue+2

1 comment

File base/tracing/protos/chrome_track_event.proto
Line 2814, Patchset 3: // The name of the MemoryDumpProvider object, from the static list in
// `kMemoryDumpProviderNameAllowList` (see
// https://source.chromium.org/chromium/chromium/src/+/main:out/android-Debug/gen/base/trace_event/memory_dump_provider_name_variants.h).
// The provider name is validated against the static list at compile time, at
// https://source.chromium.org/chromium/chromium/src/+/main:base/trace_event/memory_dump_provider.h;l=65;drc=d36832392d30b9cbbd3a6ae8a37e11b92853f041.
optional string name = 1;
Etienne Pierre-Doray . resolved

That's fine for me, but you'll have to ask review for the gwslog.
If a string here turns out to be an issue, you could use a hash, but IMO you could also just use the static_name as the trace event name for less boilerplate.

Joe Mason

I got the privacy approval, so I'll just submit this as-is to avoid more refactoring delays.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0757bf803ed354b45c9fe69f5630a1a0fb9e388
    Gerrit-Change-Number: 7595714
    Gerrit-PatchSet: 4
    Gerrit-Owner: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-Comment-Date: Fri, 20 Feb 2026 17:30:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Feb 20, 2026, 12:37:55 PM (7 days ago) Feb 20
    to Etienne Pierre-Doray, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Unreviewed changes

    3 is the latest approved patch-set.
    No files were changed between the latest approved patch-set and the submitted one.

    Change information

    Commit message:
    Record MemoryDumpProvider name in traces

    PERFETTO_TESTS=`autoninja -C out/Default perfetto_diff_tests && out/Default/bin/run_perfetto_diff_tests`
    Bug: 450929521
    Change-Id: Ia0757bf803ed354b45c9fe69f5630a1a0fb9e388
    Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
    Commit-Queue: Joe Mason <joenot...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1587907}
    Files:
    • M base/trace_event/memory_dump_manager.cc
    • M base/tracing/protos/chrome_track_event.proto
    Change size: S
    Delta: 2 files changed, 21 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia0757bf803ed354b45c9fe69f5630a1a0fb9e388
    Gerrit-Change-Number: 7595714
    Gerrit-PatchSet: 5
    Gerrit-Owner: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages