[tracing] Remove support for kTraceToConsole switch [chromium/src : main]
3 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Aug 25, 2025, 4:20:06 PMAug 25
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Aug 26, 2025, 7:07:02 AMAug 26
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov added 3 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 3 (Latest):
Mikhail Khokhlov . resolved
Should we remove the switch itself as well?
There are a couple more usages of it in the code:
https://source.chromium.org/search?q=kTraceToConsole
Commit Message
Line 11, Patchset 3 (Latest):
kTraceToConsole has subtle dependancy on code that'sMikhail Khokhlov . unresolved
Please fix this WARNING reported by Spellchecker: "dependancy" is a possible misspelling of "dependency".
To bypass Spellchecker,...
"dependancy" is a possible misspelling of "dependency".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 26, 2025, 9:14:35 AMAug 26
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray added 4 comments![]( "Open in Gerrit")
Patchset-level comments
Mikhail Khokhlov . resolved
Should we remove the switch itself as well?
There are a couple more usages of it in the code:
https://source.chromium.org/search?q=kTraceToConsole
Etienne Pierre-Doray
Done.
Commit Message
Please fix this WARNING reported by Spellchecker: "dependancy" is a possible misspelling of "dependency".
To bypass Spellchecker,...
"dependancy" is a possible misspelling of "dependency".
To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
Aug 26, 2025, 9:17:49 AMAug 26
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted and added 1 comment![]( "Open in Gerrit")
Votes added by Mikhail Khokhlov
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 26, 2025, 9:20:26 AMAug 26
to Dave Tapuska, Kramer Ge, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska and Kramer Ge
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Etienne Pierre-Doray . resolved
+dtapuska@ for content/
+fangzhoug@ for ui/ozone/demo
Related details
Attention is currently required from:
- Dave Tapuska
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 26, 2025, 9:21:10 AMAug 26
to Achuith Bhandarkar, Dave Tapuska, Kramer Ge, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Achuith Bhandarkar, Dave Tapuska and Kramer Ge
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Attention is currently required from:
- Achuith Bhandarkar
- Dave Tapuska
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
Aug 26, 2025, 10:04:58 AMAug 26
to Etienne Pierre-Doray, AyeAye, Achuith Bhandarkar, Kramer Ge, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, navigation...@chromium.org, creis...@chromium.org, rrsilva+wat...@google.com, alexmo...@chromium.org, tbarzi...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Achuith Bhandarkar, Etienne Pierre-Doray and Kramer Ge
Dave Tapuska voted and added 2 comments![]( "Open in Gerrit")
Votes added by Dave Tapuska
| Code-Review | +1 |
| Owners-Override | +1 |
2 comments
File ui/ozone/demo/ozone_demo.cc
Line 19, Patchset 6 (Latest):
#include "components/tracing/common/tracing_switches.h"Dave Tapuska . unresolved
I think this can be removed.
File ui/ozone/demo/skia/skia_demo.cc
Line 18, Patchset 6 (Latest):
#include "components/tracing/common/tracing_switches.h"Dave Tapuska . unresolved
remove?
Related details
Attention is currently required from:
- Achuith Bhandarkar
- Etienne Pierre-Doray
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 26, 2025, 10:23:00 AMAug 26
to Dave Tapuska, AyeAye, Achuith Bhandarkar, Kramer Ge, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, navigation...@chromium.org, creis...@chromium.org, rrsilva+wat...@google.com, alexmo...@chromium.org, tbarzi...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Achuith Bhandarkar and Kramer Ge
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
File ui/ozone/demo/ozone_demo.cc
I think this can be removed.
Etienne Pierre-Doray
Done
File ui/ozone/demo/skia/skia_demo.cc
Line 18, Patchset 6:
#include "components/tracing/common/tracing_switches.h"Dave Tapuska . resolved
Etienne Pierre-Dorayremove?
Done
Related details
Attention is currently required from:
- Achuith Bhandarkar
- Kramer Ge
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 26, 2025, 10:23:03 AMAug 26
to Dave Tapuska, AyeAye, Achuith Bhandarkar, Kramer Ge, Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, navigation...@chromium.org, creis...@chromium.org, rrsilva+wat...@google.com, alexmo...@chromium.org, tbarzi...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Achuith Bhandarkar and Kramer Ge
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Chromium LUCI CQ (Gerrit)
Aug 26, 2025, 11:20:41 AMAug 26
to Etienne Pierre-Doray, Dave Tapuska, AyeAye, Achuith Bhandarkar, Kramer Ge, Mikhail Khokhlov, chromium...@chromium.org, navigation...@chromium.org, creis...@chromium.org, rrsilva+wat...@google.com, alexmo...@chromium.org, tbarzi...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: ui/ozone/demo/ozone_demo.cc
Insertions: 0, Deletions: 1.
@@ -16,7 +16,6 @@
#include "base/task/thread_pool/thread_pool_instance.h"
#include "base/trace_event/trace_event.h"
#include "build/build_config.h"
-#include "components/tracing/common/tracing_switches.h"
#include "mojo/core/embedder/embedder.h"
#include "ui/events/ozone/layout/keyboard_layout_engine.h"
#include "ui/events/ozone/layout/keyboard_layout_engine_manager.h"
```
```
The name of the file: ui/ozone/demo/skia/skia_demo.cc
Insertions: 0, Deletions: 1.
@@ -15,7 +15,6 @@
#include "base/task/single_thread_task_executor.h"
#include "base/task/thread_pool/thread_pool_instance.h"
#include "base/trace_event/trace_event.h"
-#include "components/tracing/common/tracing_switches.h"
#include "mojo/core/embedder/embedder.h"
#include "ui/events/ozone/layout/keyboard_layout_engine.h"
#include "ui/events/ozone/layout/keyboard_layout_engine_manager.h"
```
```
The name of the file: content/app/content_main.cc
Insertions: 0, Deletions: 1.
@@ -34,7 +34,6 @@
#include "base/trace_event/trace_log.h"
#include "build/build_config.h"
#include "components/embedder_support/switches.h"
-#include "components/tracing/common/tracing_switches.h"
#include "content/app/content_main_runner_impl.h"
#include "content/public/app/content_main_delegate.h"
#include "content/public/common/content_switches.h"
```
Change information
Commit message:
[tracing] Remove support for kTraceToConsole switch
This has been broken ToT for a few years now, due
to initialization order.
kTraceToConsole has subtle dependency on code that's
meant to be for testing, see:
https://source.chromium.org/chromium/chromium/src/+/main:base/trace_event/trace_log.cc;l=486;drc=48f660fbabd7ec824f280cbdf7f33dac87ef37dc
There is limited use case for this, as traces have been getting
richer with perfetto, so I don't think it's worth fixing, and
I'm removing the code instead to unblock other work.
Bug: 40114725
Change-Id: I930d2cc9c2a90e22c222f9ba79ad37eaf7380c2d
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Owners-Override: Dave Tapuska <dtap...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1506513}
Files:
- M chrome/browser/ash/login/chrome_restart_request.cc
- M components/tracing/BUILD.gn
- D components/tracing/common/trace_to_console.cc
- D components/tracing/common/trace_to_console.h
- M components/tracing/common/tracing_switches.cc
- M components/tracing/common/tracing_switches.h
- M content/app/content_main.cc
- M content/browser/browser_child_process_host_impl.cc
- M content/browser/gpu/gpu_process_host.cc
- M content/browser/renderer_host/render_process_host_impl.cc
- M content/browser/tracing/tracing_controller_impl.cc
- M services/tracing/public/cpp/trace_startup.cc
- M ui/ozone/demo/ozone_demo.cc
- M ui/ozone/demo/skia/skia_demo.cc
Change size: M
Delta: 14 files changed, 0 insertions(+), 95 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mikhail Khokhlov, +1 by Dave Tapuska
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Kramer Ge (Gerrit)
Aug 26, 2025, 11:27:02 AMAug 26
to Etienne Pierre-Doray, Chromium LUCI CQ, Dave Tapuska, AyeAye, Achuith Bhandarkar, Mikhail Khokhlov, chromium...@chromium.org, navigation...@chromium.org, creis...@chromium.org, rrsilva+wat...@google.com, alexmo...@chromium.org, tbarzi...@chromium.org, ozone-...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Kramer Ge voted and added 1 comment![]( "Open in Gerrit")
Votes added by Kramer Ge
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages