Remove superfluous <map> includes from //content and Blink headers [chromium/src : main]

4 views
Skip to first unread message

Nico Weber (Gerrit)

unread,
Dec 4, 2025, 8:58:47 PMDec 4
to Lei Zhang, Nico Weber, AyeAye, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Kaan Icer, Nate Chapin, Hiroki Nakagawa, Peter Beverloo, James Su, James Maclean, Chromium LUCI CQ, alexmo...@chromium.org, amaliev+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chikamu...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jbauma...@chromium.org, jdh+wa...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, njeunje+...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, ortuno+w...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, spang...@chromium.org, storage...@chromium.org, svend+w...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, video-networking...@google.com, wfh+...@chromium.org, yhanad...@chromium.org, yigu+...@chromium.org
Attention needed from Lei Zhang

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Owners-Override+1

1 comment

Commit Message
Line 15, Patchset 1 (Latest): xargs tools/add_header.py --remove --header '<map>'
Nico Weber . resolved

nice!

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I78e9ece27bbc60e790e575b9a32e0f5514cc6a64
Gerrit-Change-Number: 7228976
Gerrit-PatchSet: 1
Gerrit-Owner: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
Gerrit-CC: James Maclean <wjma...@chromium.org>
Gerrit-CC: James Su <su...@chromium.org>
Gerrit-CC: Kaan Icer <ic...@chromium.org>
Gerrit-CC: Nate Chapin <jap...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Dec 2025 01:58:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 4, 2025, 9:27:15 PMDec 4
to Lei Zhang, Nico Weber, AyeAye, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Kaan Icer, Nate Chapin, Hiroki Nakagawa, Peter Beverloo, James Su, James Maclean, Chromium LUCI CQ, alexmo...@chromium.org, amaliev+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chikamu...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jbauma...@chromium.org, jdh+wa...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, njeunje+...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, ortuno+w...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, spang...@chromium.org, storage...@chromium.org, svend+w...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, video-networking...@google.com, wfh+...@chromium.org, yhanad...@chromium.org, yigu+...@chromium.org

Lei Zhang voted and added 1 comment

Votes added by Lei Zhang

Auto-Submit+1

1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
Lei Zhang . resolved

Needs CR+1.

Open in Gerrit

Related details

Attention set is empty
Gerrit-Comment-Date: Fri, 05 Dec 2025 02:27:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Dec 4, 2025, 9:27:42 PMDec 4
to Lei Zhang, Nico Weber, AyeAye, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Kaan Icer, Nate Chapin, Hiroki Nakagawa, Peter Beverloo, James Su, James Maclean, Chromium LUCI CQ, alexmo...@chromium.org, amaliev+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chikamu...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jbauma...@chromium.org, jdh+wa...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, njeunje+...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, ortuno+w...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, spang...@chromium.org, storage...@chromium.org, svend+w...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, video-networking...@google.com, wfh+...@chromium.org, yhanad...@chromium.org, yigu+...@chromium.org

Lei Zhang removed a vote from this change

Removed Auto-Submit+1 by Lei Zhang <the...@chromium.org>
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: deleteVote
satisfied_requirement
unsatisfied_requirement
open
diffy

Nico Weber (Gerrit)

unread,
Dec 5, 2025, 8:27:33 AMDec 5
to Lei Zhang, Nico Weber, AyeAye, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Kaan Icer, Nate Chapin, Hiroki Nakagawa, Peter Beverloo, James Su, James Maclean, Chromium LUCI CQ, alexmo...@chromium.org, amaliev+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chikamu...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jbauma...@chromium.org, jdh+wa...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, njeunje+...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, ortuno+w...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, spang...@chromium.org, storage...@chromium.org, svend+w...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, video-networking...@google.com, wfh+...@chromium.org, yhanad...@chromium.org, yigu+...@chromium.org
Attention needed from Lei Zhang

Nico Weber voted and added 1 comment

Votes added by Nico Weber

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
Nico Weber . resolved

😬

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I78e9ece27bbc60e790e575b9a32e0f5514cc6a64
    Gerrit-Change-Number: 7228976
    Gerrit-PatchSet: 1
    Gerrit-Owner: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
    Gerrit-Reviewer: Nico Weber <tha...@chromium.org>
    Gerrit-CC: Christian Biesinger <cbies...@chromium.org>
    Gerrit-CC: Hiroki Nakagawa <nhi...@chromium.org>
    Gerrit-CC: James Maclean <wjma...@chromium.org>
    Gerrit-CC: James Su <su...@chromium.org>
    Gerrit-CC: Kaan Icer <ic...@chromium.org>
    Gerrit-CC: Nate Chapin <jap...@chromium.org>
    Gerrit-CC: Peter Beverloo <pe...@chromium.org>
    Gerrit-Attention: Lei Zhang <the...@chromium.org>
    Gerrit-Comment-Date: Fri, 05 Dec 2025 13:27:23 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 5, 2025, 8:31:59 AMDec 5
    to Lei Zhang, Nico Weber, AyeAye, bfcach...@chromium.org, Christian Biesinger, chromium...@chromium.org, devtools...@chromium.org, Kaan Icer, Nate Chapin, Hiroki Nakagawa, Peter Beverloo, James Su, James Maclean, alexmo...@chromium.org, amaliev+...@chromium.org, blink-re...@chromium.org, blink-...@chromium.org, blink-work...@chromium.org, chikamu...@chromium.org, creis...@chromium.org, dmurph+wa...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-me...@chromium.org, feature-v...@chromium.org, gavinp...@chromium.org, horo+...@chromium.org, iclella...@chromium.org, jbauma...@chromium.org, jdh+wa...@chromium.org, jophba...@chromium.org, keithle...@chromium.org, kinuko+...@chromium.org, kinuko+ser...@chromium.org, kinuko...@chromium.org, liu+wa...@chromium.org, loading-re...@chromium.org, loading...@chromium.org, mattreyno...@chromium.org, mfoltz+wa...@chromium.org, nator...@chromium.org, navigation...@chromium.org, njeunje+...@chromium.org, nona+...@chromium.org, npm+...@chromium.org, odejesu...@chromium.org, ortuno+w...@chromium.org, rayanka...@chromium.org, servicewor...@chromium.org, shimazu+se...@chromium.org, shuche...@chromium.org, spang...@chromium.org, storage...@chromium.org, svend+w...@chromium.org, tommyw+w...@chromium.org, tracing...@chromium.org, tranbaod...@chromium.org, video-networking...@google.com, wfh+...@chromium.org, yhanad...@chromium.org, yigu+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Remove superfluous <map> includes from //content and Blink headers

    Remove unnecessary includes. Then do IWYU to fix the build. Removal
    automated with:

    git ls-files content third_party/blink | grep '\.h$' | \
      xargs grep -l '<map>$' | xargs grep -L std::map | \
      xargs grep -L std::multimap | \

      xargs tools/add_header.py --remove --header '<map>'
    Bug: 40318405
    Change-Id: I78e9ece27bbc60e790e575b9a32e0f5514cc6a64
    Owners-Override: Nico Weber <tha...@chromium.org>
    Commit-Queue: Nico Weber <tha...@chromium.org>
    Reviewed-by: Nico Weber <tha...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1554605}
    Files:
    • M content/browser/background_sync/background_sync_op_scheduler.h
    • M content/browser/broadcast_channel/broadcast_channel_provider.h
    • M content/browser/btm/btm_storage.h
    • M content/browser/child_process_launcher_helper.h
    • M content/browser/devtools/devtools_session.h
    • M content/browser/devtools/protocol/page_handler.h
    • M content/browser/devtools/render_frame_devtools_agent_host.h
    • M content/browser/file_system/file_system_manager_impl.h
    • M content/browser/font_access/font_access_manager.h
    • M content/browser/gpu/gpu_process_host.h
    • M content/browser/indexed_db/instance/database.h
    • M content/browser/indexed_db/instance/index_writer.h
    • M content/browser/indexed_db/instance/transaction.h
    • M content/browser/interest_group/auction_runner.h
    • M content/browser/permissions/permission_controller_impl.h
    • M content/browser/picture_in_picture/document_picture_in_picture_window_controller_impl.h
    • M content/browser/picture_in_picture/video_picture_in_picture_window_controller_impl.h
    • M content/browser/renderer_host/clipboard_host_impl.h
    • M content/browser/renderer_host/commit_deferring_condition_runner.h
    • M content/browser/renderer_host/media/audio_input_device_manager.h
    • M content/browser/renderer_host/media/preferred_audio_output_device_manager.h
    • M content/browser/renderer_host/render_frame_host_manager.h
    • M content/browser/renderer_host/render_view_host_impl.h
    • M content/browser/renderer_host/render_widget_host_view_android.h
    • M content/browser/renderer_host/render_widget_host_view_aura.h
    • M content/browser/renderer_host/view_transition_commit_deferring_condition.h
    • M content/browser/service_worker/service_worker_cache_writer.h
    • M content/browser/shared_storage/shared_storage_header_observer.h
    • M content/browser/tracing/tracing_ui.h
    • M content/browser/usb/web_usb_service_impl.h
    • M content/browser/webid/delegation/email_verifier_impl.h
    • M content/browser/xr/service/vr_service_impl.h
    • M content/child/font_data/font_data_manager.h
    • M content/public/browser/back_forward_cache.h
    • M content/public/browser/browser_context.h
    • M content/public/browser/context_menu_params.h
    • M content/public/browser/host_zoom_map.h
    • M content/public/browser/presentation_service_delegate.h
    • M content/public/renderer/content_renderer_client.h
    • M content/renderer/render_frame_impl.h
    • M content/renderer/render_thread_impl.h
    • M content/renderer/service_worker/service_worker_context_client.h
    • M content/renderer/v8_value_converter_impl.cc
    • M content/renderer/v8_value_converter_impl.h
    • M content/services/auction_worklet/trusted_kvv2_signals.h
    • M content/web_test/browser/web_test_push_messaging_service.h
    • M third_party/blink/public/common/context_menu_data/untrustworthy_context_menu_params.h
    • M third_party/blink/public/platform/web_theme_engine.h
    • M third_party/blink/renderer/modules/mediastream/web_media_player_ms_compositor.h
    • M third_party/blink/renderer/modules/peerconnection/rtc_peer_connection_handler.h
    • M third_party/blink/renderer/platform/loader/fetch/url_loader/resource_request_sender.h
    Change size: M
    Delta: 51 files changed, 3 insertions(+), 51 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Nico Weber
     Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    


     Gerrit-MessageType: merged 
    

     Gerrit-Project: chromium/src 
    

     Gerrit-Branch: main 
    

     Gerrit-Change-Id: I78e9ece27bbc60e790e575b9a32e0f5514cc6a64 
    

     Gerrit-Change-Number: 7228976 
    

     Gerrit-PatchSet: 2 
    

     Gerrit-Owner: Lei Zhang <the...@chromium.org> 
    

     Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com> 
    

     Gerrit-Reviewer: Lei Zhang <the...@chromium.org> 
    

     Gerrit-Reviewer: Nico Weber <tha...@chromium.org> 
    


     Gerrit-CC: Christian Biesinger <cbies...@chromium.org> 
    

    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages