Add base/trace_event as OWNERS of base/test/test_trace_* [chromium/src : main]

0 views
Skip to first unread message

Michael Cui (Gerrit)

unread,
Feb 23, 2026, 6:49:28 PM (4 days ago) Feb 23
to Daniel Cheng, Etienne Pierre-Doray, tracing...@chromium.org, Michael Cui
Attention needed from Daniel Cheng

Michael Cui has uploaded the change for review

Michael Cui would like Daniel Cheng to review this change.

Commit message

Add base/trace_event as OWNERS of base/test/test_trace_*

Changes to base/trace_event often requires updating
base/test/test_trace_* files (e.g. https://crrev.com/c/7595197).

Update OWNERS so the owners of the former can approve changes to the
latter.
Bug: None
Change-Id: I6a6a2100a085f59bf7f8bb715701b68c0daf5f31

Change diff

diff --git a/base/test/OWNERS b/base/test/OWNERS
index 11bba8a..03b4a14 100644
--- a/base/test/OWNERS
+++ b/base/test/OWNERS
@@ -3,6 +3,7 @@
 
 # Tracing test utilities:
 per-file trace_*=file://base/trace_event/OWNERS
+per-file test_trace_*=file://base/trace_event/OWNERS
 
 #For Windows-specific test utilities:
 per-file *_win*=file://base/win/OWNERS

Change information

Files:
  • M base/test/OWNERS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: newchange
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a2100a085f59bf7f8bb715701b68c0daf5f31
Gerrit-Change-Number: 7601672
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Cui <ml...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Michael Cui <ml...@google.com>
Gerrit-CC: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Michael Cui (Gerrit)

unread,
Feb 23, 2026, 6:49:47 PM (4 days ago) Feb 23
to Michael Cui, Daniel Cheng, Etienne Pierre-Doray, tracing...@chromium.org
Attention needed from Daniel Cheng

Michael Cui voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Daniel Cheng
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a2100a085f59bf7f8bb715701b68c0daf5f31
Gerrit-Change-Number: 7601672
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Cui <ml...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Michael Cui <ml...@google.com>
Gerrit-CC: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Daniel Cheng <dch...@chromium.org>
Gerrit-Comment-Date: Mon, 23 Feb 2026 23:49:19 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Daniel Cheng (Gerrit)

unread,
Feb 24, 2026, 6:44:10 PM (3 days ago) Feb 24
to Michael Cui, Daniel Cheng, Etienne Pierre-Doray, tracing...@chromium.org
Attention needed from Michael Cui

Daniel Cheng voted

Code-Review+1
Commit-Queue+2
Open in Gerrit

Related details

Attention is currently required from:
  • Michael Cui
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a2100a085f59bf7f8bb715701b68c0daf5f31
Gerrit-Change-Number: 7601672
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Cui <ml...@google.com>
Gerrit-Reviewer: Daniel Cheng <dch...@chromium.org>
Gerrit-Reviewer: Michael Cui <ml...@google.com>
Gerrit-CC: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Michael Cui <ml...@google.com>
Gerrit-Comment-Date: Tue, 24 Feb 2026 23:44:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 24, 2026, 7:51:05 PM (3 days ago) Feb 24
to Michael Cui, Daniel Cheng, Etienne Pierre-Doray, tracing...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add base/trace_event as OWNERS of base/test/test_trace_*

Changes to base/trace_event often requires updating
base/test/test_trace_* files (e.g. https://crrev.com/c/7595197).

Update OWNERS so the owners of the former can approve changes to the
latter.
Bug: None
Change-Id: I6a6a2100a085f59bf7f8bb715701b68c0daf5f31
Auto-Submit: Michael Cui <ml...@google.com>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1589799}
Files:
  • M base/test/OWNERS
Change size: XS
Delta: 1 file changed, 1 insertion(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Daniel Cheng
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I6a6a2100a085f59bf7f8bb715701b68c0daf5f31
Gerrit-Change-Number: 7601672
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Cui <ml...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages