Migrate various base::Contains() to contains() in services [chromium/src : main]

0 views
Skip to first unread message

Victor Vianna (Gerrit)

unread,
Jan 6, 2026, 2:31:49 AM (6 days ago) Jan 6
to Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Łukasz Bendig, Rijubrata Bhaumik, Lin, Wanming, chrome-gr...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, jdeblas...@chromium.org, marinacio...@chromium.org, martijn...@martijnc.be, mattreyno...@chromium.org, msrame...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, rhalava...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Colin Blundell

Victor Vianna voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention is currently required from:
  • Colin Blundell
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I26079e443be8c721b0f134ca248bc49a953b657c
Gerrit-Change-Number: 7378863
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Lin, Wanming <wanmi...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wojciech Dzierżanowski <wdzierz...@opera.com>
Gerrit-CC: Łukasz Bendig <lbe...@opera.com>
Gerrit-Attention: Colin Blundell <blun...@chromium.org>
Gerrit-Comment-Date: Tue, 06 Jan 2026 07:31:32 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Colin Blundell (Gerrit)

unread,
Jan 6, 2026, 3:39:20 AM (6 days ago) Jan 6
to Victor Vianna, Colin Blundell, Chromium LUCI CQ, chromium...@chromium.org, Raphael Kubo da Costa, Łukasz Bendig, Rijubrata Bhaumik, Lin, Wanming, chrome-gr...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, jdeblas...@chromium.org, marinacio...@chromium.org, martijn...@martijnc.be, mattreyno...@chromium.org, msrame...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, rhalava...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Victor Vianna

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1
Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Victor Vianna
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I26079e443be8c721b0f134ca248bc49a953b657c
Gerrit-Change-Number: 7378863
Gerrit-PatchSet: 2
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
Gerrit-CC: Lin, Wanming <wanmi...@intel.com>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Rijubrata Bhaumik <rijubrat...@intel.com>
Gerrit-CC: Wojciech Dzierżanowski <wdzierz...@opera.com>
Gerrit-CC: Łukasz Bendig <lbe...@opera.com>
Gerrit-Attention: Victor Vianna <victor...@google.com>
Gerrit-Comment-Date: Tue, 06 Jan 2026 08:39:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jan 6, 2026, 5:37:29 AM (6 days ago) Jan 6
to Victor Vianna, Colin Blundell, chromium...@chromium.org, Raphael Kubo da Costa, Łukasz Bendig, Rijubrata Bhaumik, Lin, Wanming, chrome-gr...@chromium.org, dullweb...@chromium.org, feature-me...@chromium.org, jdeblas...@chromium.org, marinacio...@chromium.org, martijn...@martijnc.be, mattreyno...@chromium.org, msrame...@chromium.org, network-ser...@chromium.org, odejesu...@chromium.org, olka+...@chromium.org, rhalava...@chromium.org, rsleev...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Migrate various base::Contains() to contains() in services
Bug: 470391351
Change-Id: I26079e443be8c721b0f134ca248bc49a953b657c
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Victor Vianna <victor...@google.com>
Commit-Queue: Colin Blundell <blun...@chromium.org>
Auto-Submit: Victor Vianna <victor...@google.com>
Cr-Commit-Position: refs/heads/main@{#1564866}
Files:
  • M services/audio/loopback_signal_provider.cc
  • M services/audio/loopback_stream.cc
  • M services/audio/output_device_mixer_impl.cc
  • M services/device/generic_sensor/linux/sensor_device_manager.cc
  • M services/device/generic_sensor/platform_sensor_chromeos.cc
  • M services/device/generic_sensor/platform_sensor_fusion_algorithm.cc
  • M services/device/generic_sensor/platform_sensor_provider.cc
  • M services/device/generic_sensor/platform_sensor_provider_chromeos_unittest.cc
  • M services/device/generic_sensor/platform_sensor_provider_linux.cc
  • M services/device/generic_sensor/sensor_provider_impl.cc
  • M services/device/hid/hid_device_info.cc
  • M services/device/hid/hid_service.cc
  • M services/device/media_transfer_protocol/mtp_device_manager.cc
  • M services/device/public/cpp/test/fake_hid_manager.cc
  • M services/device/public/cpp/test/fake_usb_device.cc
  • M services/device/public/cpp/test/fake_usb_device_manager.cc
  • M services/device/serial/bluetooth_serial_device_enumerator.cc
  • M services/device/serial/bluetooth_serial_port_impl.cc
  • M services/device/usb/mojo/device_impl.cc
  • M services/device/usb/mojo/device_impl_unittest.cc
  • M services/device/usb/usb_device_handle_usbfs.cc
  • M services/device/usb/usb_service.cc
  • M services/device/usb/usb_service_linux.cc
  • M services/device/wake_lock/power_save_blocker/power_save_blocker_linux.cc
  • M services/media_session/media_controller.cc
  • M services/media_session/public/cpp/test/mock_media_session.cc
  • M services/media_session/public/cpp/test/test_media_controller.cc
  • M services/network/cookie_settings.cc
  • M services/network/network_context_unittest.cc
  • M services/network/network_service_proxy_delegate.cc
  • M services/network/orb/orb_impl.cc
  • M services/network/orb/orb_mimetypes.cc
  • M services/network/orb/orb_sniffers.cc
  • M services/network/p2p/socket_udp.cc
  • M services/network/public/cpp/cors/cors.cc
  • M services/network/public/cpp/permissions_policy/permissions_policy_declaration.cc
  • M services/network/public/cpp/permissions_policy/permissions_policy_unittest.cc
  • M services/network/public/cpp/unencoded_digests.cc
  • M services/network/resource_scheduler/resource_scheduler.cc
  • M services/network/sct_auditing/sct_auditing_reporter.cc
  • M services/network/shared_dictionary/shared_dictionary_manager_on_disk.cc
  • M services/network/shared_dictionary/shared_dictionary_storage.cc
  • M services/network/test/trust_token_test_server_handler_registration.cc
  • M services/network/web_bundle/web_bundle_manager.cc
  • M services/network/web_transport_unittest.cc
  • M services/preferences/tracked/pref_hash_filter_unittest.cc
  • M services/preferences/tracked/tracked_atomic_preference.cc
  • M services/preferences/tracked/tracked_split_preference.cc
  • M services/resource_coordinator/memory_instrumentation/coordinator_impl.cc
  • M services/screen_ai/proto/main_content_extractor_proto_convertor.cc
  • M services/screen_ai/screen_ai_service_impl.cc
  • M services/service_manager/public/cpp/connector.cc
  • M services/service_manager/service_instance.cc
  • M services/tracing/perfetto/consumer_host.cc
Change size: L
Delta: 54 files changed, 99 insertions(+), 158 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Colin Blundell
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I26079e443be8c721b0f134ca248bc49a953b657c
Gerrit-Change-Number: 7378863
Gerrit-PatchSet: 3
Gerrit-Owner: Victor Vianna <victor...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-Reviewer: Victor Vianna <victor...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages