Use scoped_refptr to transfer ownership of ProcessMemoryDumpAsyncState [chromium/src : main]
0 views
Skip to first unread message
Joe Mason (Gerrit)
Dec 2, 2025, 5:03:01 PMDec 2
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Joe Mason voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Dec 9, 2025, 12:57:39 PM (11 days ago) Dec 9
to Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Joe Mason
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Dec 9, 2025, 3:40:26 PM (11 days ago) Dec 9
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Joe Mason voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Dec 9, 2025, 3:43:06 PM (11 days ago) Dec 9
to Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Unreviewed changes
6 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Change information
Commit message:
Use scoped_refptr to transfer ownership of ProcessMemoryDumpAsyncState
Usually there will only be one scoped_refptr with a reference to the
state object, but ContinueAsyncProcessDump will briefly create a second
while calling PostTask. This lets the function keep the object alive if
PostTask returns false. Avoids a leak if the task is dropped without
running after the PostTask succeeds.
This will let an upcoming patch store a RAII object in
ProcessMemoryDumpAsyncState, knowing that the destructor will run in all
paths except abnormal termination.
Bug: 449150643
Change-Id: I71df5054fcc83cf6ee1e4319057deafbf11ff110
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Auto-Submit: Joe Mason <joenot...@google.com>
Commit-Queue: Joe Mason <joenot...@google.com>
Cr-Commit-Position: refs/heads/main@{#1556332}
Files:
- M base/trace_event/memory_dump_manager.cc
- M base/trace_event/memory_dump_manager.h
Change size: M
Delta: 2 files changed, 36 insertions(+), 25 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages