Fix some PA_UNSAFE_TODOs in //base/allocator/partition_allocator [chromium/src : main]

1 view
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Feb 5, 2026, 7:44:53 AM (2 days ago) Feb 5
to YISI YU, Kentaro Hara, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Kentaro Hara and YISI YU

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Etienne Pierre-Doray . resolved

base/trace_event LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Kentaro Hara
  • YISI YU
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I652094ad6a36c77bd9cfdd56e8afa772096f581a
Gerrit-Change-Number: 7547665
Gerrit-PatchSet: 4
Gerrit-Owner: YISI YU <hello...@gmail.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: YISI YU <hello...@gmail.com>
Gerrit-Attention: YISI YU <hello...@gmail.com>
Gerrit-Attention: Kentaro Hara <har...@chromium.org>
Gerrit-Comment-Date: Thu, 05 Feb 2026 12:44:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Kentaro Hara (Gerrit)

unread,
Feb 5, 2026, 12:30:48 PM (2 days ago) Feb 5
to YISI YU, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from YISI YU

Kentaro Hara voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • YISI YU
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I652094ad6a36c77bd9cfdd56e8afa772096f581a
Gerrit-Change-Number: 7547665
Gerrit-PatchSet: 4
Gerrit-Owner: YISI YU <hello...@gmail.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: YISI YU <hello...@gmail.com>
Gerrit-Attention: YISI YU <hello...@gmail.com>
Gerrit-Comment-Date: Thu, 05 Feb 2026 17:30:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

YISI YU (Gerrit)

unread,
Feb 5, 2026, 7:12:10 PM (2 days ago) Feb 5
to Kentaro Hara, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

YISI YU voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I652094ad6a36c77bd9cfdd56e8afa772096f581a
Gerrit-Change-Number: 7547665
Gerrit-PatchSet: 4
Gerrit-Owner: YISI YU <hello...@gmail.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: YISI YU <hello...@gmail.com>
Gerrit-Comment-Date: Fri, 06 Feb 2026 00:11:37 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 5, 2026, 7:25:25 PM (2 days ago) Feb 5
to YISI YU, Kentaro Hara, Etienne Pierre-Doray, chromium...@chromium.org, bartek...@chromium.org, lize...@chromium.org, lizeb...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Fix some PA_UNSAFE_TODOs in //base/allocator/partition_allocator

Use std::array instead of native array.
Bug: 40285824
Change-Id: I652094ad6a36c77bd9cfdd56e8afa772096f581a
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: YISI YU <hello...@gmail.com>
Reviewed-by: Kentaro Hara <har...@chromium.org>
Auto-Submit: YISI YU <hello...@gmail.com>
Cr-Commit-Position: refs/heads/main@{#1580490}
Files:
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager.cc
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager.h
  • M base/allocator/partition_allocator/src/partition_alloc/address_pool_manager_unittest.cc
  • M base/allocator/partition_allocator/src/partition_alloc/partition_stats.h
  • M base/allocator/partition_allocator/src/partition_alloc/thread_cache.cc
  • M base/allocator/partition_allocator/src/partition_alloc/thread_cache.h
  • M base/trace_event/malloc_dump_provider.cc
Change size: M
Delta: 7 files changed, 58 insertions(+), 67 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Kentaro Hara, +1 by Etienne Pierre-Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I652094ad6a36c77bd9cfdd56e8afa772096f581a
Gerrit-Change-Number: 7547665
Gerrit-PatchSet: 5
Gerrit-Owner: YISI YU <hello...@gmail.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Kentaro Hara <har...@chromium.org>
Gerrit-Reviewer: YISI YU <hello...@gmail.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages