Rename MessagePumpForUI::Observer to NativeEventObserver and make it a single observer. [chromium/src : main]

3 views
Skip to first unread message

Gabriel Charette (Gerrit)

unread,
Mar 11, 2026, 5:56:57 PMMar 11
to Gabriel Charette, Etienne Pierre-Doray, Ale Bzk, Chromium Metrics Reviews, Hu, Ningxin, Per Åhgren, Kentaro Hara, Sam Zackrisson, Raphael Kubo da Costa, Jiewei Qian, Chromium LUCI CQ, Sadrul Chowdhury, AyeAye, asvitki...@chromium.org, peilinwa...@google.com, browser-comp...@chromium.org, agriev...@chromium.org, cc-...@chromium.org, jophba...@chromium.org, wfh+...@chromium.org, srahim...@chromium.org, ananyasee...@google.com, omnibox-...@chromium.org, marq+...@chromium.org, hanxi...@chromium.org, blink-re...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, tracing...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, devtools...@chromium.org, wnwen...@chromium.org, blink-revie...@chromium.org, telemetr...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, sloboda...@chromium.org, fenced-fra...@chromium.org, spang...@chromium.org, android-web...@chromium.org, niharm...@google.com, mac-r...@chromium.org, scheduler...@chromium.org, scheduler-b...@chromium.org
Attention needed from Etienne Pierre-Doray

Gabriel Charette voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2091c41f512d346254d87facdcedd33c95eb5d54
Gerrit-Change-Number: 7617292
Gerrit-PatchSet: 33
Gerrit-Owner: Gabriel Charette <g...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
Gerrit-CC: Ale Bzk <ales...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
Gerrit-CC: Jiewei Qian <q...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Per Åhgren <pe...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 11 Mar 2026 21:56:53 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Mar 20, 2026, 10:18:43 AM (13 days ago) Mar 20
to Gabriel Charette, Ale Bzk, Chromium Metrics Reviews, Hu, Ningxin, Per Åhgren, Kentaro Hara, Sam Zackrisson, Raphael Kubo da Costa, Jiewei Qian, Chromium LUCI CQ, Sadrul Chowdhury, AyeAye, asvitki...@chromium.org, peilinwa...@google.com, browser-comp...@chromium.org, agriev...@chromium.org, cc-...@chromium.org, jophba...@chromium.org, wfh+...@chromium.org, srahim...@chromium.org, ananyasee...@google.com, omnibox-...@chromium.org, marq+...@chromium.org, hanxi...@chromium.org, blink-re...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, tracing...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, devtools...@chromium.org, wnwen...@chromium.org, blink-revie...@chromium.org, telemetr...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, sloboda...@chromium.org, fenced-fra...@chromium.org, spang...@chromium.org, android-web...@chromium.org, niharm...@google.com, mac-r...@chromium.org, scheduler...@chromium.org, scheduler-b...@chromium.org
Attention needed from Gabriel Charette

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 34 (Latest):
Etienne Pierre-Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Gabriel Charette
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2091c41f512d346254d87facdcedd33c95eb5d54
    Gerrit-Change-Number: 7617292
    Gerrit-PatchSet: 34
    Gerrit-Owner: Gabriel Charette <g...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
    Gerrit-CC: Ale Bzk <ales...@chromium.org>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-CC: Hu, Ningxin <ningx...@intel.com>
    Gerrit-CC: Jiewei Qian <q...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Per Åhgren <pe...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-CC: Sadrul Chowdhury <sad...@chromium.org>
    Gerrit-CC: Sam Zackrisson <sa...@chromium.org>
    Gerrit-Attention: Gabriel Charette <g...@chromium.org>
    Gerrit-Comment-Date: Fri, 20 Mar 2026 14:18:36 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gabriel Charette (Gerrit)

    unread,
    Mar 20, 2026, 10:24:36 AM (13 days ago) Mar 20
    to Gabriel Charette, Etienne Pierre-Doray, Ale Bzk, Chromium Metrics Reviews, Hu, Ningxin, Per Åhgren, Kentaro Hara, Sam Zackrisson, Raphael Kubo da Costa, Jiewei Qian, Chromium LUCI CQ, Sadrul Chowdhury, AyeAye, asvitki...@chromium.org, peilinwa...@google.com, browser-comp...@chromium.org, agriev...@chromium.org, cc-...@chromium.org, jophba...@chromium.org, wfh+...@chromium.org, srahim...@chromium.org, ananyasee...@google.com, omnibox-...@chromium.org, marq+...@chromium.org, hanxi...@chromium.org, blink-re...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, tracing...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, devtools...@chromium.org, wnwen...@chromium.org, blink-revie...@chromium.org, telemetr...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, sloboda...@chromium.org, fenced-fra...@chromium.org, spang...@chromium.org, android-web...@chromium.org, niharm...@google.com, mac-r...@chromium.org, scheduler...@chromium.org, scheduler-b...@chromium.org

    Gabriel Charette voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Gerrit-Comment-Date: Fri, 20 Mar 2026 14:24:28 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Gabriel Charette (Gerrit)

    unread,
    Mar 20, 2026, 11:18:47 AM (13 days ago) Mar 20
    to Gabriel Charette, Etienne Pierre-Doray, Ale Bzk, Chromium Metrics Reviews, Hu, Ningxin, Per Åhgren, Kentaro Hara, Sam Zackrisson, Raphael Kubo da Costa, Jiewei Qian, Chromium LUCI CQ, Sadrul Chowdhury, AyeAye, asvitki...@chromium.org, peilinwa...@google.com, browser-comp...@chromium.org, agriev...@chromium.org, cc-...@chromium.org, jophba...@chromium.org, wfh+...@chromium.org, srahim...@chromium.org, ananyasee...@google.com, omnibox-...@chromium.org, marq+...@chromium.org, hanxi...@chromium.org, blink-re...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, tracing...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, devtools...@chromium.org, wnwen...@chromium.org, blink-revie...@chromium.org, telemetr...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, sloboda...@chromium.org, fenced-fra...@chromium.org, spang...@chromium.org, android-web...@chromium.org, niharm...@google.com, mac-r...@chromium.org, scheduler...@chromium.org, scheduler-b...@chromium.org
    Gerrit-Comment-Date: Fri, 20 Mar 2026 15:18:39 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Mar 20, 2026, 11:34:04 AM (13 days ago) Mar 20
    to Gabriel Charette, Etienne Pierre-Doray, Ale Bzk, Chromium Metrics Reviews, Hu, Ningxin, Per Åhgren, Kentaro Hara, Sam Zackrisson, Raphael Kubo da Costa, Jiewei Qian, Sadrul Chowdhury, AyeAye, asvitki...@chromium.org, peilinwa...@google.com, browser-comp...@chromium.org, agriev...@chromium.org, cc-...@chromium.org, jophba...@chromium.org, wfh+...@chromium.org, srahim...@chromium.org, ananyasee...@google.com, omnibox-...@chromium.org, marq+...@chromium.org, hanxi...@chromium.org, blink-re...@chromium.org, bnc+...@chromium.org, jmedle...@chromium.org, blink-...@chromium.org, tracing...@chromium.org, kinuko...@chromium.org, ios-r...@chromium.org, network-ser...@chromium.org, asvitkine...@chromium.org, net-r...@chromium.org, devtools...@chromium.org, wnwen...@chromium.org, blink-revie...@chromium.org, telemetr...@chromium.org, ios-revie...@chromium.org, feature-me...@chromium.org, blink-revie...@chromium.org, sloboda...@chromium.org, fenced-fra...@chromium.org, spang...@chromium.org, android-web...@chromium.org, niharm...@google.com, mac-r...@chromium.org, scheduler...@chromium.org, scheduler-b...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Rename MessagePumpForUI::Observer to NativeEventObserver and make it a single observer.

    The MessagePumpForUI on Windows now only supports a single NativeEventObserver instead of a list. The interface is renamed from Observer to NativeEventObserver. Corresponding methods in MessagePumpForUI and CurrentUIThread are updated to Register/UnregisterNativeEventObserver. The content::responsiveness::NativeEventObserver is also renamed to BrowserUINativeEventObserver to avoid naming conflicts and clarify its role.

    This will enable a follow-up to also invoke the observer around
    PeekMessage without the overhead of invoking an ObserverList each
    time.

    Bug: 488393677
    Change-Id: I2091c41f512d346254d87facdcedd33c95eb5d54
    Commit-Queue: Gabriel Charette <g...@chromium.org>
    Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1602632}
    Files:
    • M base/message_loop/message_pump_win.cc
    • M base/message_loop/message_pump_win.h
    • M base/task/current_thread.cc
    • M base/task/current_thread.h
    • M content/browser/scheduler/responsiveness/jank_monitor_impl_unittest.cc
    • M content/browser/scheduler/responsiveness/metric_source.cc
    • M content/browser/scheduler/responsiveness/metric_source.h
    • M content/browser/scheduler/responsiveness/metric_source_unittest.cc
    • M content/browser/scheduler/responsiveness/native_event_observer.cc
    • M content/browser/scheduler/responsiveness/native_event_observer.h
    • M content/browser/scheduler/responsiveness/native_event_observer_browsertest.mm
    • M content/browser/scheduler/responsiveness/native_event_observer_browsertest_win.cc
    • M content/browser/scheduler/responsiveness/native_event_observer_mac.mm
    • M content/browser/scheduler/responsiveness/watcher_unittest.cc
    Change size: M
    Delta: 14 files changed, 135 insertions(+), 81 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2091c41f512d346254d87facdcedd33c95eb5d54
    Gerrit-Change-Number: 7617292
    Gerrit-PatchSet: 35
    Gerrit-Owner: Gabriel Charette <g...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Gabriel Charette <g...@chromium.org>
    Gerrit-CC: Ale Bzk <ales...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages