[tracing] Simplify startup field tracing [chromium/src : main]
1 view
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Jun 13, 2024, 5:32:05 PMJun 13
to Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Eric Seckler
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Eric Seckler
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Eric Seckler (Gerrit)
Jun 14, 2024, 8:57:41 AMJun 14
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Eric Seckler voted and added 2 comments![]( "Open in Gerrit")
Votes added by Eric Seckler
| Code-Review | +1 |
2 comments
Patchset-level comments
File content/browser/tracing/background_tracing_manager_impl.cc
Line 515, Patchset 3 (Latest):
enable_package_name_filter, false, this);Eric Seckler . unresolved
Maybe mention where startup tracing was already enabled in this case?
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 28, 2024, 10:40:37 AM (3 days ago) Jun 28
to Nate Fischer, Code Review Nudger, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Nate Fischer
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 6 (Latest):
Etienne Pierre-Doray . resolved
+ntfschr@ for android_webview/
File content/browser/tracing/background_tracing_manager_impl.cc
Maybe mention where startup tracing was already enabled in this case?
Attention is currently required from:
- Nate Fischer
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Nate Fischer (Gerrit)
Jun 28, 2024, 1:50:56 PM (3 days ago) Jun 28
to Etienne Pierre-Doray, Code Review Nudger, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Nate Fischer voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 28, 2024, 2:21:51 PM (3 days ago) Jun 28
to Nate Fischer, Code Review Nudger, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 28, 2024, 2:25:58 PM (3 days ago) Jun 28
to Etienne Pierre-Doray, Nate Fischer, Code Review Nudger, Eric Seckler, chromium...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Simplify startup field tracing
Moving away from legacy json config, this uses TracingScenario
to run field startup tracing behind FieldTracing.startup.
Bug: 40257548
Change-Id: I5ba1250399ce685ee8368753b3c0ce0f6683f72d
Reviewed-by: Eric Seckler <esec...@chromium.org>
Reviewed-by: Nate Fischer <ntf...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1321082}
Files:
- M android_webview/browser/aw_browser_main_parts.cc
- M android_webview/browser/tracing/background_tracing_field_trial.cc
- M chrome/browser/tracing/background_tracing_field_trial.cc
- M components/tracing/common/background_tracing_utils.cc
- M components/tracing/common/background_tracing_utils.h
- M content/browser/BUILD.gn
- D content/browser/tracing/background_startup_tracing_observer.cc
- D content/browser/tracing/background_startup_tracing_observer.h
- D content/browser/tracing/background_startup_tracing_observer_unittest.cc
- M content/browser/tracing/background_tracing_manager_browsertest.cc
- M content/browser/tracing/background_tracing_manager_impl.cc
- M content/browser/tracing/background_tracing_manager_impl.h
- M content/browser/tracing/tracing_scenario.cc
- M content/browser/tracing/tracing_scenario.h
- M content/browser/tracing/tracing_scenario_unittest.cc
- M content/test/BUILD.gn
- M services/tracing/public/cpp/trace_startup_config.cc
Change size: L
Delta: 17 files changed, 113 insertions(+), 469 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Nate Fischer, +1 by Eric Seckler
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages