etw-stackwalk: add inclusion policy and tests [chromium/src : main]
5 views
Skip to first unread message
Jesse McKenna (Gerrit)
Jun 11, 2026, 8:37:49 PMJun 11
to Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Jesse McKenna added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File components/tracing/common/etw_consumer_win_unittest.cc
Line 1118, Patchset 3:
TEST_F(EtwConsumerTest, StackWalkFiltering) {
// Stack thread ID is masked if it doesn't belong to Chrome.
ProcessStackWalkEvent(EncodeStackWalk(123456u, kOtherPid, kOtherTid, {}));
ASSERT_EQ(decoders().size(), 1u);
std::optional<perfetto::protos::pbzero::EtwTraceEvent::Decoder> event;
std::optional<perfetto::protos::pbzero::StackWalkEtwEvent::Decoder>
stack_walk;
ASSERT_NO_FATAL_FAILURE(
ValidateAndDecodeStackWalk(*decoders().back(), event, stack_walk));
EXPECT_FALSE(event->has_thread_id());
}Etienne Pierre-Doray . resolved
Jesse McKennaCome to think of it, we should exclude the entire stack walk events if the thread id is not chrome (we wouldn't be able to symbolize anyways), so the impl should follow the same pattern as ShouldRecordFileIoEvents.
Done
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jun 16, 2026, 10:22:51 AMJun 16
to Jesse McKenna, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Jesse McKenna
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Jesse McKenna
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jesse McKenna (Gerrit)
Jun 16, 2026, 3:04:25 PMJun 16
to Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Jesse McKenna voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jun 16, 2026, 4:28:54 PMJun 16
to Jesse McKenna, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
etw-stackwalk: add inclusion policy and tests
This change makes `StackWalk` ETW events, i.e., call stacks, only be
recorded for events from Chrome. It also adds unit tests for
`HandleStackWalkEvent`.
`StackWalk` events were added in crrev.com/c/7794326.
Bug: 400769265
Change-Id: Ia0c40a5dba45197eac41634a400394e3888ef55f
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Commit-Queue: Jesse McKenna <jessem...@google.com>
Cr-Commit-Position: refs/heads/main@{#1647853}
Files:
- M components/tracing/common/etw_consumer_win.cc
- M components/tracing/common/etw_consumer_win_unittest.cc
- M components/tracing/common/inclusion_policy_win.cc
- M components/tracing/common/inclusion_policy_win.h
Change size: M
Delta: 4 files changed, 113 insertions(+), 5 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages