[base/trace_event] Add AddScalar overload for ByteSize [chromium/src : main]

4 views
Skip to first unread message

Thiabaud Engelbrecht (Gerrit)

unread,
May 20, 2026, 4:02:32 PM (yesterday) May 20
to Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Etienne Pierre-Doray

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95a17953dea0f67031bc8932192e3574c9da4876
Gerrit-Change-Number: 7638443
Gerrit-PatchSet: 3
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 20 May 2026 20:02:27 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
May 20, 2026, 4:10:13 PM (yesterday) May 20
to Thiabaud Engelbrecht, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org
Attention needed from Thiabaud Engelbrecht

Etienne Pierre-Doray voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Thiabaud Engelbrecht
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95a17953dea0f67031bc8932192e3574c9da4876
Gerrit-Change-Number: 7638443
Gerrit-PatchSet: 3
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Comment-Date: Wed, 20 May 2026 20:10:06 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thiabaud Engelbrecht (Gerrit)

unread,
May 20, 2026, 4:17:15 PM (yesterday) May 20
to Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Thiabaud Engelbrecht voted Auto-Submit+1

Auto-Submit+1
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95a17953dea0f67031bc8932192e3574c9da4876
Gerrit-Change-Number: 7638443
Gerrit-PatchSet: 3
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Comment-Date: Wed, 20 May 2026 20:17:08 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Thiabaud Engelbrecht (Gerrit)

unread,
May 20, 2026, 4:17:18 PM (yesterday) May 20
to Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Thiabaud Engelbrecht voted Commit-Queue+2

Commit-Queue+2
Gerrit-Comment-Date: Wed, 20 May 2026 20:17:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
May 20, 2026, 9:29:10 PM (21 hours ago) May 20
to Thiabaud Engelbrecht, Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, Chromium Metrics Reviews, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, asvitkine...@chromium.org, blink-revie...@chromium.org, blink-...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[base/trace_event] Add AddScalar overload for ByteSize
Change-Id: I95a17953dea0f67031bc8932192e3574c9da4876
Commit-Queue: Thiabaud Engelbrecht <thia...@google.com>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Auto-Submit: Thiabaud Engelbrecht <thia...@google.com>
Cr-Commit-Position: refs/heads/main@{#1633978}
Files:
  • M base/trace_event/memory_allocator_dump.h
Change size: XS
Delta: 1 file changed, 4 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I95a17953dea0f67031bc8932192e3574c9da4876
Gerrit-Change-Number: 7638443
Gerrit-PatchSet: 4
Gerrit-Owner: Thiabaud Engelbrecht <thia...@google.com>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Thiabaud Engelbrecht <thia...@google.com>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages