Record metrics on MemoryDumpProvider results and runtime [chromium/src : main]

0 views
Skip to first unread message

Joe Mason (Gerrit)

unread,
Dec 9, 2025, 3:39:33 PM (11 days ago) Dec 9
to Etienne Pierre-Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Joe Mason voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id6b9c4ddbc7cc02fe5ceacae02c994a53aa5dd5f
Gerrit-Change-Number: 7243631
Gerrit-PatchSet: 2
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Tue, 09 Dec 2025 20:39:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Dec 11, 2025, 3:31:08 PM (9 days ago) Dec 11
to Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Joe Mason

Etienne Pierre-Doray voted and added 2 comments

Votes added by Etienne Pierre-Doray

Code-Review+1

2 comments

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Etienne Pierre-Doray . resolved

LGTM

File base/trace_event/memory_dump_manager.cc
Line 442, Patchset 4 (Latest): TRACE_EVENT1(kTraceCategory, "MemoryDumpManager::InvokeOnMemoryDump",
"dump_provider.name", mdpinfo->name.static_name());
Etienne Pierre-Doray . unresolved

Consider emitting name.static_name() as the trace event (this one or a nested one) so this can work in the field.
I think this is ok given static_name is known at compile time.

Open in Gerrit

Related details

Attention is currently required from:
  • Joe Mason
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id6b9c4ddbc7cc02fe5ceacae02c994a53aa5dd5f
Gerrit-Change-Number: 7243631
Gerrit-PatchSet: 4
Gerrit-Owner: Joe Mason <joenot...@google.com>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Joe Mason <joenot...@google.com>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-Attention: Joe Mason <joenot...@google.com>
Gerrit-Comment-Date: Thu, 11 Dec 2025 20:31:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Joe Mason (Gerrit)

unread,
Dec 11, 2025, 4:34:53 PM (9 days ago) Dec 11
to Etienne Pierre-Doray, Chromium LUCI CQ, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Joe Mason voted and added 1 comment

Votes added by Joe Mason

Commit-Queue+2

1 comment

File base/trace_event/memory_dump_manager.cc
Line 442, Patchset 4 (Latest): TRACE_EVENT1(kTraceCategory, "MemoryDumpManager::InvokeOnMemoryDump",
"dump_provider.name", mdpinfo->name.static_name());
Etienne Pierre-Doray . resolved

Consider emitting name.static_name() as the trace event (this one or a nested one) so this can work in the field.
I think this is ok given static_name is known at compile time.

Joe Mason

Good idea, I'll do that as a followup.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id6b9c4ddbc7cc02fe5ceacae02c994a53aa5dd5f
    Gerrit-Change-Number: 7243631
    Gerrit-PatchSet: 4
    Gerrit-Owner: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
    Gerrit-Comment-Date: Thu, 11 Dec 2025 21:34:44 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 11, 2025, 5:48:58 PM (9 days ago) Dec 11
    to Etienne Pierre-Doray, Chromium Metrics Reviews, chromium...@chromium.org, asvitkine...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Record metrics on MemoryDumpProvider results and runtime

    Adds a MeasuredMemoryDumpProviderInfo class that wraps each
    MemoryDumpProviderInfo queued during a memory dump. The wrapper measures
    the length of time the MemoryDumpProviderInfo is queued + running, and
    records the final status of the dump from that specific provider, and
    records these metrics to UMA in its destructor.
    Bug: 449150643
    Change-Id: Id6b9c4ddbc7cc02fe5ceacae02c994a53aa5dd5f
    Auto-Submit: Joe Mason <joenot...@google.com>
    Commit-Queue: Joe Mason <joenot...@google.com>
    Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1557702}
    Files:
    • M base/BUILD.gn
    • A base/trace_event/measured_memory_dump_provider_info.cc
    • A base/trace_event/measured_memory_dump_provider_info.h
    • M base/trace_event/memory_dump_manager.cc
    • M base/trace_event/memory_dump_manager.h
    • M base/trace_event/memory_dump_provider_info.cc
    • M base/trace_event/memory_dump_provider_info.h
    • M tools/metrics/histograms/metadata/memory/enums.xml
    • M tools/metrics/histograms/metadata/memory/histograms.xml
    Change size: L
    Delta: 9 files changed, 306 insertions(+), 25 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Id6b9c4ddbc7cc02fe5ceacae02c994a53aa5dd5f
    Gerrit-Change-Number: 7243631
    Gerrit-PatchSet: 5
    Gerrit-Owner: Joe Mason <joenot...@google.com>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Joe Mason <joenot...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages