Replace `std::unordered_map` with `absl::flat_hash_map`. [chromium/src : main]
0 views
Skip to first unread message
Maks Orlovich (Gerrit)
Feb 19, 2026, 2:48:36 PM (8 days ago) Feb 19
to Jeffrey Yu, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Jeffrey Yu
Maks Orlovich voted and added 1 comment![]( "Open in Gerrit")
Votes added by Maks Orlovich
| Code-Review | +1 |
1 comment
Patchset-level comments
File-level comment, Patchset 4 (Latest):
Maks Orlovich . resolved
Deja vu: https://chromium-review.googlesource.com/c/chromium/src/+/7499345
...I guess it's better to land it this time, so you don't do it a third time.
Related details
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Feb 19, 2026, 3:07:38 PM (8 days ago) Feb 19
to Maks Orlovich, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Jeffrey Yu added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Maks Orlovich . resolved
Deja vu: https://chromium-review.googlesource.com/c/chromium/src/+/7499345
...I guess it's better to land it this time, so you don't do it a third time.
Jeffrey Yu
Oh, sorry, I didn't realize I had a duplicate of a previous CL!
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Jeffrey Yu (Gerrit)
Feb 20, 2026, 7:42:20 PM (7 days ago) Feb 20
to Qingxin Wu, Maks Orlovich, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Qingxin Wu
Jeffrey Yu voted Auto-Submit+1![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Qingxin Wu (Gerrit)
Feb 20, 2026, 8:36:41 PM (7 days ago) Feb 20
to Jeffrey Yu, Maks Orlovich, AyeAye, Chromium LUCI CQ, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Attention needed from Jeffrey Yu
Qingxin Wu voted![]( "Open in Gerrit")
Attention is currently required from:
- Jeffrey Yu
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Feb 20, 2026, 9:25:41 PM (7 days ago) Feb 20
to Jeffrey Yu, Qingxin Wu, Maks Orlovich, AyeAye, wfh+...@chromium.org, spang...@chromium.org, tracing...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Replace `std::unordered_map` with `absl::flat_hash_map`.
The Chromium containers guide
(https://chromium.googlesource.com/chromium/src/+/HEAD/base/containers/README.md)
recommends using `absl::flat_hash_map` as a default map choice instead
of `std::unordered_map` when pointer stability isn't needed, and
`absl::node_hash_map` when it is. Both will still generally perform
better and require less overhead than `std::unordered_map`.
Bug: 473916362
Change-Id: I000633693df9fc98e4108a9e3b49c985f2aab366
Reviewed-by: Maks Orlovich <morl...@chromium.org>
Auto-Submit: Jeffrey Yu <yu...@chromium.org>
Reviewed-by: Qingxin Wu <qing...@google.com>
Commit-Queue: Qingxin Wu <qing...@google.com>
Cr-Commit-Position: refs/heads/main@{#1588228}
Files:
- M content/browser/interest_group/interest_group_storage.cc
Change size: S
Delta: 1 file changed, 3 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Maks Orlovich, +1 by Qingxin Wu
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages