Import perfetto changes to use ints for process and thread types [chromium/src : main]
0 views
Skip to first unread message
Joe Mason (Gerrit)
Aug 19, 2025, 6:47:31 PMAug 19
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Joe Mason added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 2 (Latest):
Joe Mason . resolved
This (along with https://github.com/google/perfetto/pull/2633) is the version that uses raw ints instead of extensions. Which do you prefer?
File DEPS
Line 2634, Patchset 2 (Latest):
'@' + '27acf8eee51191454a8898411beb75f9fe12f26c',Joe Mason . unresolved
This is the SHA of a draft upstream pull request (https://github.com/google/perfetto/pull/2633). Need to wait until that's approved and lands, then change this to the perfetto trunk SHA.
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Aug 20, 2025, 4:28:17 PMAug 20
to Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Joe Mason
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Aug 20, 2025, 4:53:19 PMAug 20
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Joe Mason added 1 comment![]( "Open in Gerrit")
File DEPS
This is the SHA of a draft upstream pull request (https://github.com/google/perfetto/pull/2633). Need to wait until that's approved and lands, then change this to the perfetto trunk SHA.
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 20, 2025, 7:26:16 PMAug 20
to Etienne Pierre-Doray, chromium...@chromium.org, ddrone...@google.com, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
5 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: third_party/perfetto
Insertions: 1, Deletions: 1.
The diff is too large to show. Please review the diff.
```
```
The name of the file: DEPS
Insertions: 1, Deletions: 2.
The diff is too large to show. Please review the diff.
```
Change information
Commit message:
Import perfetto changes to use ints for process and thread types
Imports 1 Perfetto revisions:
2025-08-20 joenot...@google.com Make process_type and thread_type into ints (#2633)
Upstream, the process_type and thread_type fields in
ChromeProcessDescriptor and ChromeThreadDescriptor are now specified as
integers, to avoid importing
"protos/third_party/chromium/chrome_enums.proto". To prevent duplicate
import errors, Chrome and everything linked from it needs to include the
protos from //base/tracing/protos, not
//third_party/perfetto/protos/third_party/chromium.
* Manually rolls perfetto deps to latest upstream.
* Copies the upstream protos/third_party/chromium/*.proto changes back
into base/tracing/protos. Usually this sync goes the other way, but
to untangle a dependency cycle upstream changes needed to be made
first.
* Updates //services/tracing to use the enum definitions from
base/tracing/protos, and cast to integer when writing them into
ChromeProcessDescriptor and ChromeThreadDescriptor.
* Adds an explicit proto_in_dir arg to :chrome_track_event_zero.
Without this protoc tries to start from //base/tracing/protos to
resolve "base/tracing/protos/chrome_enums.proto", instead of starting
from the root dir.
PERFETTO_TESTS=`autoninja -C out/Default perfetto_diff_tests && out/Default/bin/run_perfetto_diff_tests`
Bug: 429457813
Change-Id: I0a06e2b731e19204ac6bb166bd5604a288c86822
Commit-Queue: Joe Mason <joenot...@google.com>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1504265}
Files:
- M DEPS
- M base/tracing/protos/BUILD.gn
- M base/tracing/protos/chrome_enums.proto
- M services/tracing/public/cpp/perfetto/trace_string_lookup.cc
- M services/tracing/public/cpp/perfetto/trace_string_lookup.h
- M services/tracing/public/cpp/perfetto/track_name_recorder.cc
- M services/tracing/public/cpp/perfetto/track_name_recorder.h
- M services/tracing/public/cpp/perfetto/track_name_recorder_unittest.cc
- M third_party/perfetto
Change size: M
Delta: 9 files changed, 119 insertions(+), 100 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages