Cleanup: Remove histogram macros header includes in components [chromium/src : main]

0 views
Skip to first unread message

Colin Blundell (Gerrit)

unread,
Mar 30, 2026, 12:42:32 PM (3 days ago) Mar 30
to Alexei Svitkine, Colin Blundell, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Peter Beverloo, mar...@chromium.org, fgal...@chromium.org, jz...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gcasto+w...@chromium.org, harringt...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, martijn...@martijnc.be, mdjone...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, rsleev...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, thiabaud+watch-d...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org
Attention needed from Alexei Svitkine

Colin Blundell voted and added 1 comment

Votes added by Colin Blundell

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 21 (Latest):
Colin Blundell . resolved

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Alexei Svitkine
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8770359b3dac7afe911dc3def1887f21107cdc0d
Gerrit-Change-Number: 7701717
Gerrit-PatchSet: 21
Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Attention: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Mar 2026 16:42:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Alexei Svitkine (Gerrit)

unread,
Mar 30, 2026, 1:22:19 PM (3 days ago) Mar 30
to Colin Blundell, Mirko Bonadei, Jerome Jiang, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, Enterprise Policy Reviews, Peter Beverloo, mar...@chromium.org, fgal...@chromium.org, jz...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gcasto+w...@chromium.org, harringt...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, martijn...@martijnc.be, mdjone...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, rsleev...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, thiabaud+watch-d...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Alexei Svitkine voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8770359b3dac7afe911dc3def1887f21107cdc0d
Gerrit-Change-Number: 7701717
Gerrit-PatchSet: 21
Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
Gerrit-CC: Enterprise Policy Reviews <enterprise-p...@google.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: Peter Beverloo <pe...@chromium.org>
Gerrit-Comment-Date: Mon, 30 Mar 2026 17:22:12 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Mar 30, 2026, 1:33:16 PM (3 days ago) Mar 30
to Alexei Svitkine, Colin Blundell, Mirko Bonadei, Jerome Jiang, AyeAye, chromium...@chromium.org, Enterprise Policy Reviews, Peter Beverloo, mar...@chromium.org, fgal...@chromium.org, jz...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, devtools...@chromium.org, aixba+wat...@chromium.org, andysjl...@chromium.org, asvitki...@chromium.org, ayman...@chromium.org, bmcquad...@chromium.org, browser-comp...@chromium.org, cc-...@chromium.org, chili...@chromium.org, christia...@chromium.org, chrome-intell...@chromium.org, chrome-intelligence-te...@google.com, chromiumme...@microsoft.com, crostin...@chromium.org, csharris...@chromium.org, dfried...@chromium.org, dibyapal+wa...@chromium.org, dmurph+watchi...@chromium.org, dmurph+watching...@chromium.org, dmurph+watc...@chromium.org, dmurph+watch...@chromium.org, druber...@chromium.org, dullweb...@chromium.org, edgesto...@microsoft.com, estali...@chromium.org, feature-me...@chromium.org, fgorsk...@chromium.org, gcasto+w...@chromium.org, harringt...@chromium.org, ios-r...@chromium.org, iwells...@chromium.org, japhet+...@chromium.org, jdeblas...@chromium.org, jdonnel...@chromium.org, kuragin+web-ap...@chromium.org, language...@chromium.org, loading-rev...@chromium.org, loyso...@chromium.org, mac-r...@chromium.org, martijn...@martijnc.be, mdjone...@chromium.org, mek+w...@chromium.org, mgiuca...@chromium.org, msrame...@chromium.org, net-r...@chromium.org, ntp-dev...@chromium.org, nwoked...@chromium.org, omnibox-...@chromium.org, penghu...@chromium.org, performance-m...@chromium.org, petewi...@chromium.org, philli...@chromium.org, pkotwic...@chromium.org, rsleev...@chromium.org, sloboda...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, speed-metr...@chromium.org, storage...@chromium.org, subresource-f...@chromium.org, thiabaud+watch-d...@google.com, tracing...@chromium.org, vakh+safe_br...@chromium.org, vasilii+watchlis...@chromium.org, webapks-...@chromium.org, webap...@microsoft.com, wfh+...@chromium.org, xinghui...@chromium.org, yhanada+...@chromium.org, yuezhang...@chromium.org, zackha...@chromium.org, zelin+watch-we...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Cleanup: Remove histogram macros header includes in components
Bug: None
Change-Id: I8770359b3dac7afe911dc3def1887f21107cdc0d
Reviewed-by: Colin Blundell <blun...@chromium.org>
Commit-Queue: Alexei Svitkine <asvi...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1607214}
Files:
  • M components/affiliations/core/browser/hash_affiliation_fetcher.cc
  • M components/autofill/core/browser/crowdsourcing/autofill_crowdsourcing_manager.cc
  • M components/autofill/core/browser/crowdsourcing/randomized_encoder.cc
  • M components/autofill/core/browser/form_structure.cc
  • M components/autofill/core/browser/integrators/address_on_typing/address_on_typing_manager.cc
  • M components/autofill/core/browser/metrics/form_events/loyalty_card_form_event_logger.cc
  • M components/autofill/core/browser/metrics/payments/filled_card_information_bubble_metrics.cc
  • M components/autofill/core/browser/metrics/payments/iban_metrics.cc
  • M components/autofill/core/browser/metrics/payments/manage_cards_prompt_metrics.cc
  • M components/autofill/core/browser/metrics/payments/virtual_card_standalone_cvc_suggestion_metrics.cc
  • M components/autofill/core/browser/metrics/payments/wallet_usage_data_metrics.cc
  • M components/autofill/core/common/form_data.cc
  • M components/blocked_content/popup_tracker.cc
  • M components/browser_ui/photo_picker/android/photo_picker_sandbox_bridge.cc
  • M components/captive_portal/content/captive_portal_service.cc
  • M components/certificate_transparency/chrome_ct_policy_enforcer.cc
  • M components/commerce/core/shopping_service.cc
  • M components/content_settings/core/browser/content_settings_pref.cc
  • M components/content_settings/core/browser/cookie_settings.cc
  • M components/crash/content/browser/crash_memory_metrics_collector_android.cc
  • M components/cronet/android/cronet_context_adapter.cc
  • M components/cronet/cronet_prefs_manager.cc
  • M components/discardable_memory/common/discardable_shared_memory_heap.cc
  • M components/discardable_memory/service/discardable_shared_memory_manager.cc
  • M components/dom_distiller/content/browser/dom_distiller_viewer_source.cc
  • M components/dom_distiller/core/distiller_page.cc
  • M components/dom_distiller/core/viewer.cc
  • M components/domain_reliability/context.cc
  • M components/download/internal/common/download_item_impl.cc
  • M components/download/internal/common/parallel_download_job.cc
  • M components/exo/frame_timing_history.cc
  • M components/facilitated_payments/core/metrics/facilitated_payments_metrics.cc
  • M components/favicon/core/favicon_handler.cc
  • M components/feed/core/v2/feed_stream.cc
  • M components/gcm_driver/crypto/gcm_key_store.cc
  • M components/gcm_driver/gcm_driver_desktop.cc
  • M components/history/core/browser/browsing_history_service.cc
  • M components/history/core/browser/expire_history_backend.cc
  • M components/history/core/browser/top_sites_backend.cc
  • M components/image_fetcher/core/cached_image_fetcher.cc
  • M components/input/input_router_impl.cc
  • M components/input/render_input_router_latency_tracker.cc
  • M components/input/render_widget_host_input_event_router.cc
  • M components/input/render_widget_targeter.cc
  • M components/input/web_input_event_builders_mac.mm
  • M components/javascript_dialogs/android/app_modal_dialog_view_android.cc
  • M components/javascript_dialogs/android/tab_modal_dialog_view_android.cc
  • M components/javascript_dialogs/app_modal_dialog_manager.cc
  • M components/javascript_dialogs/tab_modal_dialog_manager.cc
  • M components/language/core/browser/accept_languages_service.cc
  • M components/language/ios/browser/ios_language_detection_tab_helper.mm
  • M components/language_detection/content/renderer/language_detection_model_manager.cc
  • M components/memory_pressure/multi_source_memory_pressure_monitor.cc
  • M components/metrics/clean_exit_beacon.cc
  • M components/metrics/histogram_controller.cc
  • M components/metrics/library_support/histogram_manager.cc
  • M components/metrics/metrics_upload_scheduler.cc
  • M components/metrics/net/net_metrics_log_uploader.cc
  • M components/metrics/net/network_metrics_provider.cc
  • M components/metrics/structured/structured_metrics_recorder.cc
  • M components/metrics/unsent_log_store.cc
  • M components/metrics_services_manager/metrics_services_manager.cc
  • M components/no_state_prefetch/browser/no_state_prefetch_histograms.cc
  • M components/no_state_prefetch/browser/no_state_prefetch_link_manager.cc
  • M components/no_state_prefetch/browser/no_state_prefetch_utils.cc
  • M components/no_state_prefetch/common/no_state_prefetch_origin.cc
  • M components/no_state_prefetch/common/no_state_prefetch_utils.cc
  • M components/no_state_prefetch/renderer/no_state_prefetch_helper.cc
  • M components/ntp_tiles/icon_cacher_impl.cc
  • M components/offline_pages/core/archive_manager.cc
  • M components/offline_pages/core/background/request_coordinator.cc
  • M components/offline_pages/core/downloads/download_ui_adapter.cc
  • M components/offline_pages/core/model/cleanup_visuals_task.cc
  • M components/offline_pages/core/model/clear_storage_task.cc
  • M components/offline_pages/core/model/offline_page_model_taskified.cc
  • M components/offline_pages/core/model/persistent_page_consistency_check_task.cc
  • M components/offline_pages/core/model/startup_maintenance_task.cc
  • M components/offline_pages/core/offline_page_metadata_store.cc
  • M components/omnibox/browser/history_url_provider.cc
  • M components/omnibox/browser/in_memory_url_index.cc
  • M components/omnibox/browser/on_device_head_provider.cc
  • M components/omnibox/browser/shortcuts_provider.cc
  • M components/optimization_guide/core/delivery/prediction_model_download_manager.cc
  • M components/optimization_guide/core/hints/optimization_guide_navigation_data.cc
  • M components/page_load_metrics/browser/metrics_web_contents_observer.cc
  • M components/page_load_metrics/browser/observers/ad_metrics/page_ad_density_tracker.cc
  • M components/page_load_metrics/browser/observers/zstd_page_load_metrics_observer.cc
  • M components/page_load_metrics/browser/page_load_tracker.cc
  • M components/page_load_metrics/google/browser/gws_page_load_metrics_observer.cc
  • M components/password_manager/core/browser/export/password_manager_exporter.cc
  • M components/password_manager/core/browser/leak_detection/bulk_leak_check_service.cc
  • M components/payments/content/installable_payment_app_crawler.cc
  • M components/payments/content/manifest_verifier.cc
  • M components/payments/core/journey_logger.cc
  • M components/performance_manager/worker_watcher.cc
  • M components/plugins/renderer/webview_plugin.cc
  • M components/policy/core/common/cloud/user_cloud_policy_store.cc
  • M components/reading_list/core/reading_list_entry.cc
  • M components/safe_browsing/android/safe_browsing_api_handler_bridge.cc
  • M components/safe_browsing/android/safe_browsing_api_handler_util.cc
  • M components/safe_browsing/content/browser/client_side_detection_host.cc
  • M components/safe_browsing/content/browser/client_side_detection_service.cc
  • M components/safe_browsing/content/browser/client_side_phishing_model.cc
  • M components/safe_browsing/content/browser/password_protection/password_protection_service.cc
  • M components/safe_browsing/content/browser/threat_details.cc
  • M components/safe_browsing/content/browser/ui_manager.cc
  • M components/safe_browsing/content/renderer/phishing_classifier/features.cc
  • M components/safe_browsing/content/renderer/phishing_classifier/phishing_classifier.cc
  • M components/safe_browsing/content/renderer/phishing_classifier/phishing_classifier_delegate.cc
  • M components/safe_browsing/content/renderer/phishing_classifier/scorer.cc
  • M components/safe_browsing/content/renderer/threat_dom_details.cc
  • M components/safe_browsing/core/browser/db/database_manager.cc
  • M components/safe_browsing/core/browser/password_protection/password_protection_service_base.cc
  • M components/safe_browsing/core/browser/realtime/policy_engine.cc
  • M components/safe_browsing/core/browser/realtime/url_lookup_service.cc
  • M components/safe_browsing/core/browser/realtime/url_lookup_service_base.cc
  • M components/safe_browsing/core/browser/url_realtime_mechanism.cc
  • M components/safe_browsing/core/common/utils.cc
  • M components/safe_search_api/url_checker.cc
  • M components/security_interstitials/content/captive_portal_blocking_page.cc
  • M components/security_interstitials/content/security_interstitial_page.cc
  • M components/security_interstitials/core/safe_browsing_quiet_error_ui.cc
  • M components/security_state/core/security_state.cc
  • M components/services/storage/dom_storage/session_storage_area_impl.cc
  • M components/signin/core/browser/dice_account_reconcilor_delegate.cc
  • M components/signin/internal/identity_manager/mutable_profile_oauth2_token_service_delegate.cc
  • M components/signin/internal/identity_manager/primary_account_manager.cc
  • M components/signin/internal/identity_manager/profile_oauth2_token_service_delegate_android.cc
  • M components/spellcheck/renderer/spellcheck_provider.cc
  • M components/subresource_filter/content/browser/child_frame_navigation_filtering_throttle.cc
  • M components/subresource_filter/content/browser/page_load_statistics.cc
  • M components/subresource_filter/content/browser/ruleset_service.cc
  • M components/sync/engine/bookmark_update_preprocessing.cc
  • M components/sync/engine/data_type_registry.cc
  • M components/sync/engine/sync_manager_impl.cc
  • M components/sync/service/sync_service_utils.cc
  • M components/sync_bookmarks/bookmark_remote_updates_handler.cc
  • M components/sync_bookmarks/synced_bookmark_tracker_entity.cc
  • M components/sync_sessions/session_store.cc
  • M components/tracing/common/background_tracing_metrics_provider.cc
  • M components/translate/content/android/translate_message.cc
  • M components/translate/core/browser/translate_infobar_delegate.cc
  • M components/translate/core/browser/translate_ranker_impl.cc
  • M components/translate/core/browser/translate_ui_languages_manager.cc
  • M components/user_education/common/ntp_promo/ntp_promo_controller.cc
  • M components/user_education/common/tutorial/tutorial.cc
  • M components/user_manager/known_user.cc
  • M components/viz/host/gpu_client.cc
  • M components/viz/host/gpu_host_impl.cc
  • M components/viz/service/display/overlay_combination_cache.cc
  • M components/viz/service/display/overlay_processor_delegated.cc
  • M components/viz/service/frame_sinks/compositor_frame_sink_support.cc
  • M components/viz/service/surfaces/surface_manager.cc
  • M components/webapps/browser/android/add_to_homescreen_mediator.cc
  • M components/webapps/browser/banners/app_banner_manager.cc
  • M components/webapps/browser/installable/installable_metrics.cc
Change size: M
Delta: 156 files changed, 53 insertions(+), 156 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Colin Blundell
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8770359b3dac7afe911dc3def1887f21107cdc0d
Gerrit-Change-Number: 7701717
Gerrit-PatchSet: 22
Gerrit-Owner: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Alexei Svitkine <asvi...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Colin Blundell <blun...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages