Remove unnecessary std::string <-> C-string conversions in tracing code [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Sep 5, 2025, 11:04:12 AM (4 days ago) Sep 5
to Lei Zhang, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Lei Zhang
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Lei Zhang (Gerrit)
Sep 5, 2025, 4:10:26 PM (4 days ago) Sep 5
to Lei Zhang, Michal Mocny, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Etienne Pierre-Doray and Michal Mocny
Lei Zhang voted Auto-Submit+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- Michal Mocny
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Michal Mocny (Gerrit)
Sep 8, 2025, 10:41:53 AM (yesterday) Sep 8
to Lei Zhang, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Attention needed from Etienne Pierre-Doray and Lei Zhang
Michal Mocny voted![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
- Lei Zhang
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Sep 8, 2025, 11:33:41 AM (yesterday) Sep 8
to Lei Zhang, Michal Mocny, Etienne Pierre-Doray, chromium...@chromium.org, agriev...@chromium.org, blink-...@chromium.org, core-timi...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, spang...@chromium.org, speed-metrics...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove unnecessary std::string <-> C-string conversions in tracing code
Pass std::string instances directly into functions that take
std::string, instead of calling std::string::c_str() and passing that
in.
Change-Id: I1d52643df2ae20a6e65a4498a99fc1911733eec1
Auto-Submit: Lei Zhang <the...@chromium.org>
Reviewed-by: Michal Mocny <mmo...@chromium.org>
Commit-Queue: Michal Mocny <mmo...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1512438}
Files:
- M base/android/early_trace_event_binding.cc
- M services/tracing/public/cpp/perfetto/metadata_data_source.cc
- M third_party/blink/renderer/core/timing/performance_user_timing.cc
Change size: S
Delta: 3 files changed, 8 insertions(+), 9 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Michal Mocny
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages