base: Replace circular_deque with vector in traced_value.cc [chromium/src : main]
2 views
Skip to first unread message
Andrew Paseltiner (Gerrit)
Apr 1, 2026, 1:07:25 PM (yesterday) Apr 1
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng
Andrew Paseltiner voted Commit-Queue+1![]( "Open in Gerrit")
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Apr 1, 2026, 1:14:31 PM (yesterday) Apr 1
to Andrew Paseltiner, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Andrew Paseltiner
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Attention is currently required from:
- Andrew Paseltiner
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Andrew Paseltiner (Gerrit)
Apr 1, 2026, 1:40:37 PM (yesterday) Apr 1
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Andrew Paseltiner voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Apr 1, 2026, 1:48:28 PM (yesterday) Apr 1
to Andrew Paseltiner, Daniel Cheng, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
base: Replace circular_deque with vector in traced_value.cc
This change replaces base::circular_deque with std::vector for the
state_stack in TracedValue::AppendAsTraceFormat, where the container is
used as a local stack. std::vector has lower overhead and better memory
locality, and while base::circular_deque can shrink capacity after
elements are deleted, this seems like unnecessary overhead for no
benefit, as the stack's lifetime is limited to the AppendAsTraceFormat
call, which is not interruptible; it's simpler and more efficient to
just free all the memory on method return.
This alignment matches TracedValue::ToBaseValue, which also uses a
std::vector for its internal stack.
Change-Id: I34b44c0d56fd74c1e3c9a45c6f1f64544b1b7640
Commit-Queue: Andrew Paseltiner <apase...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1608652}
Files:
- M base/trace_event/traced_value.cc
Change size: XS
Delta: 1 file changed, 2 insertions(+), 2 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages