[ppm] Emit the AudioOutputDevice::GetOutputDeviceInfo trace event in "latency" category. [chromium/src : main]

0 views
Skip to first unread message

Francois Pierre Doray (Gerrit)

unread,
Jan 16, 2026, 12:21:49 PMJan 16
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Francois Pierre Doray voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ia65626731b4411184e736470a5b6036267224bd0
Gerrit-Change-Number: 7487955
Gerrit-PatchSet: 2
Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Fri, 16 Jan 2026 17:21:44 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jan 20, 2026, 4:10:15 PMJan 20
to Francois Pierre Doray, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Francois Pierre Doray

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review+1

1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Etienne Pierre-Doray . resolved

LGTM

Open in Gerrit

Related details

Attention is currently required from:
  • Francois Pierre Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia65626731b4411184e736470a5b6036267224bd0
    Gerrit-Change-Number: 7487955
    Gerrit-PatchSet: 2
    Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Comment-Date: Tue, 20 Jan 2026 21:10:08 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Francois Pierre Doray (Gerrit)

    unread,
    Jan 21, 2026, 9:33:27 AMJan 21
    to Tomas Gunnarsson, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
    Attention needed from Tomas Gunnarsson

    Francois Pierre Doray voted Auto-Submit+1

    Auto-Submit+1
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Tomas Gunnarsson
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia65626731b4411184e736470a5b6036267224bd0
    Gerrit-Change-Number: 7487955
    Gerrit-PatchSet: 2
    Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-Attention: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-Comment-Date: Wed, 21 Jan 2026 14:33:20 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Tomas Gunnarsson (Gerrit)

    unread,
    Jan 21, 2026, 2:07:38 PMJan 21
    to Francois Pierre Doray, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, feature-me...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
    Attention needed from Francois Pierre Doray

    Tomas Gunnarsson voted

    Code-Review+1
    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention is currently required from:
    • Francois Pierre Doray
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia65626731b4411184e736470a5b6036267224bd0
    Gerrit-Change-Number: 7487955
    Gerrit-PatchSet: 2
    Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    Gerrit-Attention: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Comment-Date: Wed, 21 Jan 2026 19:07:22 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 21, 2026, 4:41:10 PMJan 21
    to Francois Pierre Doray, Tomas Gunnarsson, Etienne Pierre-Doray, chromium...@chromium.org, feature-me...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [ppm] Emit the AudioOutputDevice::GetOutputDeviceInfo trace event in "latency" category.

    The wait in this method is a known source of high input latency. Use the
    "latency" category to ensure it's visible in general performance traces,
    not just audio-specific ones. This will facilitate identification of
    high input latency causes in traces.
    Bug: 476408124
    Change-Id: Ia65626731b4411184e736470a5b6036267224bd0
    Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
    Reviewed-by: Tomas Gunnarsson <to...@chromium.org>
    Commit-Queue: Tomas Gunnarsson <to...@chromium.org>
    Auto-Submit: Francois Pierre Doray <fdo...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1572545}
    Files:
    • M base/trace_event/builtin_categories.h
    • M media/audio/audio_output_device.cc
    Change size: XS
    Delta: 2 files changed, 5 insertions(+), 1 deletion(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray, +1 by Tomas Gunnarsson
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ia65626731b4411184e736470a5b6036267224bd0
    Gerrit-Change-Number: 7487955
    Gerrit-PatchSet: 3
    Gerrit-Owner: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Francois Pierre Doray <fdo...@chromium.org>
    Gerrit-Reviewer: Tomas Gunnarsson <to...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages