Allow compiler to deduce base::span for UNSAFE_TODO fix [chromium/src : main]

0 views
Skip to first unread message

David Bienvenu (Gerrit)

unread,
Jan 8, 2026, 4:46:12 PM (3 days ago) Jan 8
to Tom Sepez, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Tom Sepez

David Bienvenu added 1 comment

Patchset-level comments
File-level comment, Patchset 1 (Latest):
David Bienvenu . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Tom Sepez
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8cd7e6f27f78ca382f2360d624caa2c4147ed4c7
Gerrit-Change-Number: 7417226
Gerrit-PatchSet: 1
Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
Gerrit-Attention: Tom Sepez <tse...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 21:45:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Tom Sepez (Gerrit)

unread,
Jan 8, 2026, 4:46:55 PM (3 days ago) Jan 8
to David Bienvenu, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from David Bienvenu

Tom Sepez voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • David Bienvenu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8cd7e6f27f78ca382f2360d624caa2c4147ed4c7
    Gerrit-Change-Number: 7417226
    Gerrit-PatchSet: 1
    Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Attention: David Bienvenu <davidb...@chromium.org>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 21:46:45 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    David Bienvenu (Gerrit)

    unread,
    Jan 8, 2026, 5:41:30 PM (3 days ago) Jan 8
    to Tom Sepez, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    David Bienvenu voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8cd7e6f27f78ca382f2360d624caa2c4147ed4c7
    Gerrit-Change-Number: 7417226
    Gerrit-PatchSet: 1
    Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    Gerrit-Comment-Date: Thu, 08 Jan 2026 22:41:15 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 8, 2026, 5:46:02 PM (3 days ago) Jan 8
    to David Bienvenu, Tom Sepez, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    Allow compiler to deduce base::span for UNSAFE_TODO fix
    Bug: 42271176
    Change-Id: I8cd7e6f27f78ca382f2360d624caa2c4147ed4c7
    Commit-Queue: David Bienvenu <davidb...@chromium.org>
    Reviewed-by: Tom Sepez <tse...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1566564}
    Files:
    • M base/trace_event/etw_interceptor_win.cc
    Change size: XS
    Delta: 1 file changed, 1 insertion(+), 2 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Tom Sepez
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I8cd7e6f27f78ca382f2360d624caa2c4147ed4c7
    Gerrit-Change-Number: 7417226
    Gerrit-PatchSet: 2
    Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: Tom Sepez <tse...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages