Add Flt file i/o opcodes support for tracing [chromium/src : main]

0 views
Skip to first unread message

David Bienvenu (Gerrit)

unread,
Apr 21, 2026, 7:38:49 PM (5 days ago) Apr 21
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

David Bienvenu voted and added 1 comment

Votes added by David Bienvenu

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
David Bienvenu . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie934d73fdb177c073a206135607f90ed1229bfd2
Gerrit-Change-Number: 7773660
Gerrit-PatchSet: 3
Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Tue, 21 Apr 2026 23:38:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Apr 22, 2026, 11:57:57 AM (4 days ago) Apr 22
to David Bienvenu, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from David Bienvenu

Etienne Pierre-Doray added 3 comments

File components/tracing/common/etw_consumer_win.cc
Line 318, Patchset 3 (Latest): case 79: // FileIo_V2_QueryFullSizeInfo
case 80: // QuerySetVolumeInfo
break;
Etienne Pierre-Doray . unresolved

Should we still log the "unhandled file op code", or it this changing because we intentionally ignore them?

Line 790, Patchset 3 (Latest): // Size of `FileIo_Info` event: 3 pointers + 4 `uint32`s.
Etienne Pierre-Doray . unresolved

In decoding below I see 4 * pointer_size and 3 * uint32_t?
Although in the test, `extra_info` (pointer_size) seems to match operation_status (uint32_t)

File components/tracing/common/etw_consumer_win_unittest.cc
Line 784, Patchset 3 (Latest):#if defined(ARCH_CPU_64_BITS)
static constexpr uint16_t kEventHeaderFlags = EVENT_HEADER_FLAG_64_BIT_HEADER;
#else
static constexpr uint16_t kEventHeaderFlags = EVENT_HEADER_FLAG_32_BIT_HEADER;
#endif
Etienne Pierre-Doray . resolved

Both should work on either 64bit or 32 bit target really, but I guess it's a good change to at least exercise each.

Open in Gerrit

Related details

Attention is currently required from:
  • David Bienvenu
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement is not satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement is not satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ie934d73fdb177c073a206135607f90ed1229bfd2
    Gerrit-Change-Number: 7773660
    Gerrit-PatchSet: 3
    Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Attention: David Bienvenu <davidb...@chromium.org>
    Gerrit-Comment-Date: Wed, 22 Apr 2026 15:57:48 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    David Bienvenu (Gerrit)

    unread,
    Apr 22, 2026, 12:48:25 PM (4 days ago) Apr 22
    to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
    Attention needed from Etienne Pierre-Doray

    David Bienvenu added 4 comments

    Patchset-level comments
    David Bienvenu . resolved

    PTAL

    File components/tracing/common/etw_consumer_win.cc
    Line 318, Patchset 3: case 79: // FileIo_V2_QueryFullSizeInfo

    case 80: // QuerySetVolumeInfo
    break;
    Etienne Pierre-Doray . resolved

    Should we still log the "unhandled file op code", or it this changing because we intentionally ignore them?

    David Bienvenu

    We previously weren't logging unhandled file op codes - I intended the logging to check for op codes we didn't know about. I've added a TODO to handle the Query op codes. I don't think they're used that often so they shouldn't cause many unmatched end events, but we should handle them for completeness.

    Line 790, Patchset 3: // Size of `FileIo_Info` event: 3 pointers + 4 `uint32`s.
    Etienne Pierre-Doray . resolved

    In decoding below I see 4 * pointer_size and 3 * uint32_t?
    Although in the test, `extra_info` (pointer_size) seems to match operation_status (uint32_t)

    David Bienvenu

    Good point - Gemini suggested storing the status in the extra_info field. I've switched the status to 32 bits and stuck it in the 64 bit extra_info field.

    File components/tracing/common/etw_consumer_win_unittest.cc
    Line 784, Patchset 3:#if defined(ARCH_CPU_64_BITS)

    static constexpr uint16_t kEventHeaderFlags = EVENT_HEADER_FLAG_64_BIT_HEADER;
    #else
    static constexpr uint16_t kEventHeaderFlags = EVENT_HEADER_FLAG_32_BIT_HEADER;
    #endif
    Etienne Pierre-Doray . resolved

    Both should work on either 64bit or 32 bit target really, but I guess it's a good change to at least exercise each.

    David Bienvenu

    This is just to stop the CHECK_EQ check above from firing.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Etienne Pierre-Doray
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement is not satisfiedCode-Review
      • requirement is not satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie934d73fdb177c073a206135607f90ed1229bfd2
      Gerrit-Change-Number: 7773660
      Gerrit-PatchSet: 4
      Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
      Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Comment-Date: Wed, 22 Apr 2026 16:48:15 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Etienne Pierre-Doray (Gerrit)

      unread,
      Apr 22, 2026, 1:49:48 PM (4 days ago) Apr 22
      to David Bienvenu, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
      Attention needed from David Bienvenu

      Etienne Pierre-Doray voted and added 1 comment

      Votes added by Etienne Pierre-Doray

      Code-Review+1

      1 comment

      Patchset-level comments
      File-level comment, Patchset 4 (Latest):
      Etienne Pierre-Doray . resolved

      LGTM, thanks!

      Open in Gerrit

      Related details

      Attention is currently required from:
      • David Bienvenu
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie934d73fdb177c073a206135607f90ed1229bfd2
      Gerrit-Change-Number: 7773660
      Gerrit-PatchSet: 4
      Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
      Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Attention: David Bienvenu <davidb...@chromium.org>
      Gerrit-Comment-Date: Wed, 22 Apr 2026 17:49:42 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      David Bienvenu (Gerrit)

      unread,
      Apr 22, 2026, 4:11:44 PM (4 days ago) Apr 22
      to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

      David Bienvenu voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie934d73fdb177c073a206135607f90ed1229bfd2
      Gerrit-Change-Number: 7773660
      Gerrit-PatchSet: 4
      Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
      Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Comment-Date: Wed, 22 Apr 2026 20:11:40 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 22, 2026, 4:15:45 PM (4 days ago) Apr 22
      to David Bienvenu, Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Add Flt file i/o opcodes support for tracing

      I've landed Perfetto support for the Flt file i/o opcodes. This CL
      adds trace recording for these opcodes.

      gemini-cli wrote the additional tests. This CL also fixes the ETW
      tests on x86 builds.
      Bug: 400769108
      Change-Id: Ie934d73fdb177c073a206135607f90ed1229bfd2
      Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
      Commit-Queue: David Bienvenu <davidb...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1619040}
      Files:
      • M components/tracing/common/etw_consumer_win.cc
      • M components/tracing/common/etw_consumer_win.h
      • M components/tracing/common/etw_consumer_win_unittest.cc
      Change size: M
      Delta: 3 files changed, 140 insertions(+), 4 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Etienne Pierre-Doray
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: Ie934d73fdb177c073a206135607f90ed1229bfd2
      Gerrit-Change-Number: 7773660
      Gerrit-PatchSet: 5
      Gerrit-Owner: David Bienvenu <davidb...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: David Bienvenu <davidb...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages