[Merge 7846][tracing] Fix TracingAgentObserverManager null check [chromium/src : refs/branch-heads/7846]

1 view

Skip to first unread message

Srinivas Sista (Gerrit)

unread,

May 20, 2026, 6:05:46 PM (23 hours ago) May 20

to Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org

Attention needed from Etienne Pierre-Doray

Srinivas Sista voted Code-Review+1

Code-Review

Open in Gerrit

Related details

Attention is currently required from:

Etienne Pierre-Doray

Submit Requirements:

Code-Owners
Code-Review
Lint
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Srinivas Sista (Gerrit)

unread,

May 20, 2026, 6:06:04 PM (23 hours ago) May 20

to Etienne Pierre-Doray, android-bu...@system.gserviceaccount.com, spang...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org

Srinivas Sista submitted the change

Change information

Commit message:

[Merge 7846][tracing] Fix TracingAgentObserverManager null check

Bug in https://crrev.com/c/7837871,
TracingAgentObserverManager::GetInstace() can be called
after it's destroyed.

(cherry picked from commit fb5e0e329e7f87be7b1ec04a8c60c07327e22c26)

Bug: 513698528

Change-Id: I2a0ea5c1e8b3941dc61ac7b8007320c6b95357e6

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7853845

Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>

Reviewed-by: Mikhail Khokhlov <khok...@google.com>

Cr-Original-Commit-Position: refs/heads/main@{#1632562}

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7862917

Reviewed-by: Srinivas Sista <sriniv...@chromium.org>

Cr-Commit-Position: refs/branch-heads/7846@{#6}

Cr-Branched-From: e1538838a1667995def253cb4744a25edb68db53-refs/heads/main@{#1632247}

Files:

M services/tracing/public/cpp/background_tracing/background_tracing_rule.cc
M services/tracing/public/cpp/background_tracing/tracing_agent_observer_manager.cc

Change size: XS

Delta: 2 files changed, 6 insertions(+), 3 deletions(-)

Branch: refs/branch-heads/7846

Submit Requirements:

Code-Review: +1 by Srinivas Sista

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages