WIP: Prevent crashes if Perfetto is not initialized [chromium/src : main]

0 views

Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,

Jan 23, 2026, 2:59:11 PMJan 23

to Peter Birk Pakkenberg, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Attention needed from Peter Birk Pakkenberg

Etienne Pierre-Doray added 1 comment

File components/tracing/common/background_tracing_utils.cc

Line 59, Patchset 1: if (!perfetto::Tracing::IsInitialized()) {

Eric Seckler . unresolved

Wondering a bit weather we need this many entry points from WebView/Chrome into SetupBackgroundTracing.. calls. Maybe we can unify this somehow into one entry point that calls the right Setup.. functions in the right order, based on some params to enable certain features? i.e.
```
bool SetupBackgroundTracing(bool a) {
  Setup..();
  Setup..();
  if (a) Setup..();
}
```
@etie...@chromium.org for ideas

Etienne Pierre-Doray

There's really 2 entry points:
1: initialization in PostCreateThreads (though this could probably happen earlier):

```
tracing::SetupSystemTracingFromFieldTrial();
tracing::SetupBackgroundTracingFromCommandLine();
tracing::SetupPresetTracingFromFieldTrial();
base::trace_event::EmitNamedTrigger(
  base::trace_event::kStartupTracingTriggerName);
```

2: initialization in BackgroundTracingMetricsProvider::Init (guarded behind metric collection):

```
tracing::TraceStartupConfig::GetInstance().SetBackgroundStartupTracingEnabled(tracing::kStartupFieldTracing.Get());
  SetupFieldTracingFromFieldTrial();
```

Open in Gerrit

Related details

Attention is currently required from:

Peter Birk Pakkenberg

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

unsatisfied_requirement

open

diffy

Reply all

Reply to author

Forward

0 new messages