[tracing] Fix TracingAgentObserverManager null check [chromium/src : main]
2 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
May 18, 2026, 9:15:13 AM (3 days ago) May 18
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
May 18, 2026, 10:17:59 AM (3 days ago) May 18
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 18, 2026, 8:29:58 PM (3 days ago) May 18
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 18, 2026, 9:55:16 PM (3 days ago) May 18
to Etienne Pierre-Doray, Mikhail Khokhlov, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Fix TracingAgentObserverManager null check
Bug in https://crrev.com/c/7837871,
TracingAgentObserverManager::GetInstace() can be called
after it's destroyed.
Bug: 513698528
Change-Id: I2a0ea5c1e8b3941dc61ac7b8007320c6b95357e6
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Cr-Commit-Position: refs/heads/main@{#1632562}
Files:
- M services/tracing/public/cpp/background_tracing/background_tracing_rule.cc
- M services/tracing/public/cpp/background_tracing/tracing_agent_observer_manager.cc
Change size: XS
Delta: 2 files changed, 6 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Mikhail Khokhlov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages