[tracing] Fix TracingAgentObserverManager null check [chromium/src : main]

2 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
May 18, 2026, 9:15:13 AM (3 days ago) May 18
to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Mikhail Khokhlov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I2a0ea5c1e8b3941dc61ac7b8007320c6b95357e6
Gerrit-Change-Number: 7853845
Gerrit-PatchSet: 3
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
Gerrit-Attention: Mikhail Khokhlov <khok...@google.com>
Gerrit-Comment-Date: Mon, 18 May 2026 13:15:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Mikhail Khokhlov (Gerrit)

unread,
May 18, 2026, 10:17:59 AM (3 days ago) May 18
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Mikhail Khokhlov voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2a0ea5c1e8b3941dc61ac7b8007320c6b95357e6
    Gerrit-Change-Number: 7853845
    Gerrit-PatchSet: 3
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Comment-Date: Mon, 18 May 2026 14:17:44 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    May 18, 2026, 8:29:58 PM (3 days ago) May 18
    to Mikhail Khokhlov, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Etienne Pierre-Doray voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2a0ea5c1e8b3941dc61ac7b8007320c6b95357e6
    Gerrit-Change-Number: 7853845
    Gerrit-PatchSet: 3
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    Gerrit-Comment-Date: Tue, 19 May 2026 00:29:52 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    May 18, 2026, 9:55:16 PM (3 days ago) May 18
    to Etienne Pierre-Doray, Mikhail Khokhlov, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [tracing] Fix TracingAgentObserverManager null check

    Bug in https://crrev.com/c/7837871,
    TracingAgentObserverManager::GetInstace() can be called
    after it's destroyed.
    Bug: 513698528
    Change-Id: I2a0ea5c1e8b3941dc61ac7b8007320c6b95357e6
    Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
    Reviewed-by: Mikhail Khokhlov <khok...@google.com>
    Cr-Commit-Position: refs/heads/main@{#1632562}
    Files:
    • M services/tracing/public/cpp/background_tracing/background_tracing_rule.cc
    • M services/tracing/public/cpp/background_tracing/tracing_agent_observer_manager.cc
    Change size: XS
    Delta: 2 files changed, 6 insertions(+), 3 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Mikhail Khokhlov
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I2a0ea5c1e8b3941dc61ac7b8007320c6b95357e6
    Gerrit-Change-Number: 7853845
    Gerrit-PatchSet: 4
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages