WebUI: Leverage the new WebUIDataSourceImpl#SetDefaultResource(), part2. [chromium/src : main]

0 views
Skip to first unread message

Demetrios Papadopoulos (Gerrit)

unread,
Jan 26, 2026, 7:14:12 PM (12 days ago) Jan 26
to Rebekah Potter, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, dmurph+wa...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-v...@chromium.org, nwoked...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Rebekah Potter

New activity on the change

Open in Gerrit

Related details

Attention is currently required from:
  • Rebekah Potter
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ieb4d5ab486f9b87b5d259f2108ef79b97ff25680
Gerrit-Change-Number: 7516414
Gerrit-PatchSet: 1
Gerrit-Owner: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
Gerrit-Attention: Rebekah Potter <rbpo...@chromium.org>
Gerrit-Comment-Date: Tue, 27 Jan 2026 00:14:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Rebekah Potter (Gerrit)

unread,
Jan 27, 2026, 12:07:33 AM (12 days ago) Jan 27
to Demetrios Papadopoulos, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, dmurph+wa...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-v...@chromium.org, nwoked...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org
Attention needed from Demetrios Papadopoulos

Rebekah Potter voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Demetrios Papadopoulos
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieb4d5ab486f9b87b5d259f2108ef79b97ff25680
    Gerrit-Change-Number: 7516414
    Gerrit-PatchSet: 1
    Gerrit-Owner: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-Attention: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Comment-Date: Tue, 27 Jan 2026 05:07:23 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Demetrios Papadopoulos (Gerrit)

    unread,
    Jan 28, 2026, 2:47:43 PM (10 days ago) Jan 28
    to Rebekah Potter, Chromium LUCI CQ, chromium...@chromium.org, andysjl...@chromium.org, dmurph+wa...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-v...@chromium.org, nwoked...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

    Demetrios Papadopoulos voted Commit-Queue+2

    Commit-Queue+2
    Open in Gerrit

    Related details

    Attention set is empty
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieb4d5ab486f9b87b5d259f2108ef79b97ff25680
    Gerrit-Change-Number: 7516414
    Gerrit-PatchSet: 1
    Gerrit-Owner: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
    Gerrit-Comment-Date: Wed, 28 Jan 2026 19:47:33 +0000
    Gerrit-HasComments: No
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Jan 28, 2026, 4:05:11 PM (10 days ago) Jan 28
    to Demetrios Papadopoulos, Rebekah Potter, chromium...@chromium.org, andysjl...@chromium.org, dmurph+wa...@chromium.org, druber...@chromium.org, edgesto...@microsoft.com, enne...@chromium.org, feature-v...@chromium.org, nwoked...@chromium.org, spang...@chromium.org, storage...@chromium.org, tracing...@chromium.org, vakh+safe_br...@chromium.org, wfh+...@chromium.org, xinghui...@chromium.org, zackha...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    WebUI: Leverage the new WebUIDataSourceImpl#SetDefaultResource(), part2.

    SetDefaultResource() semantics were recently changed and it can now be
    deployed in all places that were previously intentionally bypassing it,
    meaning places that were calling `source->AddResourcePath("", ...)`
    Bug: 415304334
    Change-Id: Ieb4d5ab486f9b87b5d259f2108ef79b97ff25680
    Reviewed-by: Rebekah Potter <rbpo...@chromium.org>
    Commit-Queue: Demetrios Papadopoulos <dpa...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1576154}
    Files:
    • M components/safe_browsing/content/browser/web_ui/safe_browsing_ui.cc
    • M content/browser/gpu/gpu_internals_ui.cc
    • M content/browser/indexed_db/indexed_db_internals_ui.cc
    • M content/browser/tracing/traces_internals/traces_internals_ui.cc
    • M content/browser/xr/webxr_internals/webxr_internals_ui.cc
    Change size: S
    Delta: 5 files changed, 5 insertions(+), 5 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Rebekah Potter
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: Ieb4d5ab486f9b87b5d259f2108ef79b97ff25680
    Gerrit-Change-Number: 7516414
    Gerrit-PatchSet: 2
    Gerrit-Owner: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Demetrios Papadopoulos <dpa...@chromium.org>
    Gerrit-Reviewer: Rebekah Potter <rbpo...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages