Remove base::trace_event::TraceEventHandle [chromium/src : main]

0 views
Skip to first unread message

Kai Ninomiya (Gerrit)

unread,
Jan 8, 2026, 6:54:26 PM (3 days ago) Jan 8
to AyeAye, Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, tracing...@chromium.org, spang...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Kai Ninomiya added 3 comments

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Kai Ninomiya . resolved

Thanks for the suggestions, PTAL!

File gpu/command_buffer/service/dawn_platform.cc
Line 177, Patchset 1: base::trace_event::TraceEventHandle handle =
Etienne Pierre-Doray . resolved

I think we can further simplify and

  • Remove return param from TRACE_EVENT_API_ADD_TRACE_EVENT_WITH_THREAD_ID_AND_TIMESTAMP (AddTraceEventWithThreadIdAndTimestamp)
  • Return 0 from this function
Kai Ninomiya

Done

File skia/ext/event_tracer_impl.cc
Line 68, Patchset 1: static_assert(sizeof(handle) == sizeof(uint64_t),
"Following code assumes TraceEventHandle is just a uint64_t.");
base::trace_event::TraceEventHandle traceEventHandle{handle};
TRACE_EVENT_API_UPDATE_TRACE_EVENT_DURATION(categoryEnabledFlag, name,
traceEventHandle);
Etienne Pierre-Doray . resolved

I think we can further simplify and remove traceEventHandle param from TRACE_EVENT_API_UPDATE_TRACE_EVENT_DURATION (UpdateTraceEventDuration)

Kai Ninomiya

Done

Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I56dc703a0287fe88b25fc63c8dfafdcd4348a201
Gerrit-Change-Number: 7394195
Gerrit-PatchSet: 2
Gerrit-Owner: Kai Ninomiya <kai...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Thu, 08 Jan 2026 23:54:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Etienne Pierre-Doray <etie...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jan 9, 2026, 7:16:40 AM (3 days ago) Jan 9
to Kai Ninomiya, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tracing...@chromium.org, spang...@chromium.org, wfh+...@chromium.org
Attention needed from Kai Ninomiya

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Code-Review+1

1 comment

Patchset-level comments
Etienne Pierre-Doray . resolved

LGTM thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Kai Ninomiya
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I56dc703a0287fe88b25fc63c8dfafdcd4348a201
    Gerrit-Change-Number: 7394195
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kai Ninomiya <kai...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
    Gerrit-Attention: Kai Ninomiya <kai...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 12:16:31 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Kai Ninomiya (Gerrit)

    unread,
    Jan 9, 2026, 4:56:07 PM (2 days ago) Jan 9
    to Florin Malita, Geoff Lang, Etienne Pierre-Doray, AyeAye, Chromium LUCI CQ, chromium...@chromium.org, tracing...@chromium.org, spang...@chromium.org, wfh+...@chromium.org
    Attention needed from Florin Malita and Geoff Lang

    Kai Ninomiya added 1 comment

    Patchset-level comments
    Kai Ninomiya . resolved

    Owners PTAL skia/ext and ui/gl!

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Florin Malita
    • Geoff Lang
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I56dc703a0287fe88b25fc63c8dfafdcd4348a201
    Gerrit-Change-Number: 7394195
    Gerrit-PatchSet: 2
    Gerrit-Owner: Kai Ninomiya <kai...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Florin Malita <fma...@chromium.org>
    Gerrit-Reviewer: Geoff Lang <geof...@chromium.org>
    Gerrit-Reviewer: Kai Ninomiya <kai...@chromium.org>
    Gerrit-Attention: Geoff Lang <geof...@chromium.org>
    Gerrit-Attention: Florin Malita <fma...@chromium.org>
    Gerrit-Comment-Date: Fri, 09 Jan 2026 21:55:54 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: No
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy
    Reply all
    Reply to author
    Forward
    0 new messages