[tracing] Move trace_startup_config to services/tracing/ [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Jun 11, 2024, 12:21:15 PMJun 11
to Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Eric Seckler

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 4 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Eric Seckler
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Gerrit-Change-Number: 5622351
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Eric Seckler <esec...@chromium.org>
Gerrit-Comment-Date: Tue, 11 Jun 2024 16:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Eric Seckler (Gerrit)

unread,
Jun 11, 2024, 12:24:52 PMJun 11
to Etienne Pierre-Doray, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Eric Seckler voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Gerrit-Change-Number: 5622351
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Tue, 11 Jun 2024 16:24:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jun 11, 2024, 1:14:15 PMJun 11
to Dave Tapuska, Nate Fischer, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Dave Tapuska, Eric Seckler and Nate Fischer

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Etienne Pierre-Doray . resolved

+ntfschr@ for android_webview
+dtapuska@ for content/

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Eric Seckler
  • Nate Fischer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Gerrit-Change-Number: 5622351
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Attention: Nate Fischer <ntf...@chromium.org>
Gerrit-Attention: Eric Seckler <esec...@chromium.org>
Gerrit-Comment-Date: Tue, 11 Jun 2024 17:14:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Dave Tapuska (Gerrit)

unread,
Jun 11, 2024, 1:16:28 PMJun 11
to Etienne Pierre-Doray, Nate Fischer, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Eric Seckler, Etienne Pierre-Doray and Nate Fischer

Dave Tapuska voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Eric Seckler
  • Etienne Pierre-Doray
  • Nate Fischer
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Gerrit-Change-Number: 5622351
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
Gerrit-Attention: Nate Fischer <ntf...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Eric Seckler <esec...@chromium.org>
Gerrit-Comment-Date: Tue, 11 Jun 2024 17:16:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Nate Fischer (Gerrit)

unread,
Jun 12, 2024, 2:41:40 AMJun 12
to Etienne Pierre-Doray, Dave Tapuska, Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Eric Seckler and Etienne Pierre-Doray

Nate Fischer voted and added 1 comment

Votes added by Nate Fischer

Code-Review+1

1 comment

Patchset-level comments
Nate Fischer . resolved

aw lgtm

Open in Gerrit

Related details

Attention is currently required from:
  • Eric Seckler
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Gerrit-Change-Number: 5622351
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Eric Seckler <esec...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 06:41:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Eric Seckler (Gerrit)

unread,
Jun 12, 2024, 4:32:09 AMJun 12
to Etienne Pierre-Doray, Nate Fischer, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray

Eric Seckler voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Gerrit-Change-Number: 5622351
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 08:31:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jun 12, 2024, 12:35:18 PMJun 12
to Eric Seckler, Nate Fischer, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Etienne Pierre-Doray voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Review
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Gerrit-Change-Number: 5622351
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
Gerrit-Comment-Date: Wed, 12 Jun 2024 16:35:03 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Jun 12, 2024, 12:40:57 PMJun 12
to Etienne Pierre-Doray, Eric Seckler, Nate Fischer, Dave Tapuska, chromium...@chromium.org, devtools...@chromium.org, android-web...@chromium.org, blundell+...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
[tracing] Move trace_startup_config to services/tracing/

In follow up, trace_startup_config needs to depend on
services/tracing/public/cpp/perfetto/perfetto_config.h
https://chromium-review.googlesource.com/c/chromium/src/+/5581006
Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Nate Fischer <ntf...@chromium.org>
Reviewed-by: Eric Seckler <esec...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1314065}
Files:
  • M android_webview/browser/tracing/aw_background_tracing_metrics_provider_unittest.cc
  • M chrome/browser/tracing/chrome_background_tracing_metrics_provider_unittest.cc
  • M chrome/browser/tracing/chrome_tracing_delegate_browsertest.cc
  • M components/tracing/BUILD.gn
  • M content/browser/browser_child_process_host_impl.cc
  • M content/browser/browser_main_loop.cc
  • M content/browser/browser_main_runner_impl.cc
  • M content/browser/devtools/protocol/tracing_handler.cc
  • M content/browser/tracing/background_startup_tracing_observer.cc
  • M content/browser/tracing/background_startup_tracing_observer_unittest.cc
  • M content/browser/tracing/background_tracing_config_impl.cc
  • M content/browser/tracing/background_tracing_manager_browsertest.cc
  • M content/browser/tracing/background_tracing_manager_impl.cc
  • M content/browser/tracing/startup_tracing_browsertest.cc
  • M content/browser/tracing/startup_tracing_controller.cc
  • M services/tracing/BUILD.gn
  • M services/tracing/public/cpp/BUILD.gn
  • M services/tracing/public/cpp/trace_startup.cc
  • R services/tracing/public/cpp/trace_startup_config.cc
  • R services/tracing/public/cpp/trace_startup_config.h
  • R services/tracing/public/cpp/trace_startup_config_unittest.cc
Change size: M
Delta: 21 files changed, 53 insertions(+), 48 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Dave Tapuska, +1 by Eric Seckler, +1 by Nate Fischer
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Ie45079bb868e945a562733b6d0445652ccc8362b
Gerrit-Change-Number: 5622351
Gerrit-PatchSet: 6
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages