[identifiability] Remove leftover perfetto categories and proto message [chromium/src : main]

0 views
Skip to first unread message

Antonio Sartori (Gerrit)

unread,
Dec 5, 2025, 2:16:47 AMDec 5
to Eric Seckler, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, ddrone...@google.com, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Eric Seckler

Antonio Sartori added 1 comment

Patchset-level comments
File-level comment, Patchset 3 (Latest):
Antonio Sartori . unresolved

Hey Eric, I have a couple of questions:

1) Are we supposed to delete unused perfetto categories and proto messages or leave them around?

2) I haven't been able to run the presubmit tests, see https://issues.chromium.org/issues/465939788. Do they also run on the CQ or can you help me run them?

Thanks!

Open in Gerrit

Related details

Attention is currently required from:
  • Eric Seckler
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a8c7d4057fe62bce7df938d0ec890c445a15374
Gerrit-Change-Number: 7224054
Gerrit-PatchSet: 3
Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Eric Seckler <esec...@chromium.org>
Gerrit-Comment-Date: Fri, 05 Dec 2025 07:16:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Eric Seckler (Gerrit)

unread,
Dec 8, 2025, 4:17:25 AM (13 days ago) Dec 8
to Antonio Sartori, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, ddrone...@google.com, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Antonio Sartori

Eric Seckler voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Antonio Sartori
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement is not satisfiedNo-Unresolved-Comments
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I7a8c7d4057fe62bce7df938d0ec890c445a15374
Gerrit-Change-Number: 7224054
Gerrit-PatchSet: 3
Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-CC: Kentaro Hara <har...@chromium.org>
Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
Gerrit-Comment-Date: Mon, 08 Dec 2025 09:17:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Antonio Sartori (Gerrit)

unread,
Dec 8, 2025, 7:14:30 AM (13 days ago) Dec 8
to Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, ddrone...@google.com, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Antonio Sartori voted and added 1 comment

Votes added by Antonio Sartori

Commit-Queue+2

1 comment

Patchset-level comments
File-level comment, Patchset 3:
Antonio Sartori . resolved

Hey Eric, I have a couple of questions:

1) Are we supposed to delete unused perfetto categories and proto messages or leave them around?

2) I haven't been able to run the presubmit tests, see https://issues.chromium.org/issues/465939788. Do they also run on the CQ or can you help me run them?

Thanks!

Antonio Sartori

I will ack and try to submit.

Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a8c7d4057fe62bce7df938d0ec890c445a15374
    Gerrit-Change-Number: 7224054
    Gerrit-PatchSet: 4
    Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Comment-Date: Mon, 08 Dec 2025 12:14:09 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    Comment-In-Reply-To: Antonio Sartori <antonio...@chromium.org>
    satisfied_requirement
    open
    diffy

    Eric Seckler (Gerrit)

    unread,
    Dec 8, 2025, 7:40:42 AM (13 days ago) Dec 8
    to Antonio Sartori, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, ddrone...@google.com, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
    Attention needed from Antonio Sartori

    Eric Seckler voted and added 1 comment

    Votes added by Eric Seckler

    Code-Review+1

    1 comment

    Patchset-level comments
    Antonio Sartori . resolved

    Hey Eric, I have a couple of questions:

    1) Are we supposed to delete unused perfetto categories and proto messages or leave them around?

    2) I haven't been able to run the presubmit tests, see https://issues.chromium.org/issues/465939788. Do they also run on the CQ or can you help me run them?

    Thanks!

    Antonio Sartori

    I will ack and try to submit.

    Eric Seckler

    Ah sorry, didn't see these 😊

    I believe the diff tests are broken for some reason, yes. We'll look at fixing these. Deleting the messages is probably fine, as long as nobody needs to look at (old) traces with this data anymore -- which I assume is no longer needed.

    The arguments in existing old traces will simply no longer to be read by Perfetto tooling when this makes its way to trace processor / Perfetto UI builds -- but the traces themselves can still be opened.

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Antonio Sartori
    Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a8c7d4057fe62bce7df938d0ec890c445a15374
    Gerrit-Change-Number: 7224054
    Gerrit-PatchSet: 4
    Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    Gerrit-CC: Kentaro Hara <har...@chromium.org>
    Gerrit-CC: Raphael Kubo da Costa <ku...@igalia.com>
    Gerrit-Attention: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Comment-Date: Mon, 08 Dec 2025 12:40:22 +0000
    satisfied_requirement
    open
    diffy

    Chromium LUCI CQ (Gerrit)

    unread,
    Dec 8, 2025, 8:50:05 AM (12 days ago) Dec 8
    to Antonio Sartori, Eric Seckler, chromium...@chromium.org, Kentaro Hara, Raphael Kubo da Costa, blink-revie...@chromium.org, blink-...@chromium.org, ddrone...@google.com, kinuko...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

    Chromium LUCI CQ submitted the change

    Change information

    Commit message:
    [identifiability] Remove leftover perfetto categories and proto message

    These perfetto categories and the proto messages are no longer used.
    Bug: 451512746
    Change-Id: I7a8c7d4057fe62bce7df938d0ec890c445a15374
    Reviewed-by: Eric Seckler <esec...@chromium.org>
    Commit-Queue: Antonio Sartori <antonio...@chromium.org>
    Cr-Commit-Position: refs/heads/main@{#1555425}
    Files:
    • M base/trace_event/builtin_categories.h
    • M base/tracing/protos/chrome_track_event.proto
    Change size: M
    Delta: 2 files changed, 2 insertions(+), 123 deletions(-)
    Branch: refs/heads/main
    Submit Requirements:
    • requirement satisfiedCode-Review: +1 by Eric Seckler
    Open in Gerrit
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: merged
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: I7a8c7d4057fe62bce7df938d0ec890c445a15374
    Gerrit-Change-Number: 7224054
    Gerrit-PatchSet: 5
    Gerrit-Owner: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Antonio Sartori <antonio...@chromium.org>
    Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
    Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
    open
    diffy
    satisfied_requirement
    Reply all
    Reply to author
    Forward
    0 new messages