Fix Linux arm64 failures in interactive_ui_tests and browser_tests [chromium/src : main]

0 views
Skip to first unread message

Thomas Anderson (Gerrit)

unread,
Apr 17, 2026, 6:01:08 PM (9 days ago) Apr 17
to Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, network-ser...@chromium.org, steimel+...@chromium.org, feature-me...@chromium.org, mek+w...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, philli...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, zelin+watch-we...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, abigailbk...@google.com, cfredri...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, spang...@chromium.org, tracing...@chromium.org, trewin...@google.com, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Lei Zhang and Nasko Oskov

Thomas Anderson voted and added 1 comment

Votes added by Thomas Anderson

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 10 (Latest):
Thomas Anderson . resolved

reviewers ptal. With this change, the linux-arm64-rel-fyi bot is green.
thestig: //chrome
nasko: //content

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
  • Nasko Oskov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e3f242981a9d5d8f9fe455cd849b851604eb4aa
Gerrit-Change-Number: 7770067
Gerrit-PatchSet: 10
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Nasko Oskov <na...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Apr 2026 22:00:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Lei Zhang (Gerrit)

unread,
Apr 17, 2026, 6:10:26 PM (9 days ago) Apr 17
to Thomas Anderson, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, network-ser...@chromium.org, steimel+...@chromium.org, feature-me...@chromium.org, mek+w...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, philli...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, zelin+watch-we...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, abigailbk...@google.com, cfredri...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, spang...@chromium.org, tracing...@chromium.org, trewin...@google.com, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Nasko Oskov and Thomas Anderson

Lei Zhang added 1 comment

Patchset-level comments
Lei Zhang . resolved

It would be better to split this up and let the reviewers most familiar with the tests take a look.

Open in Gerrit

Related details

Attention is currently required from:
  • Nasko Oskov
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e3f242981a9d5d8f9fe455cd849b851604eb4aa
Gerrit-Change-Number: 7770067
Gerrit-PatchSet: 10
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Nasko Oskov <na...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Apr 2026 22:10:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Apr 17, 2026, 7:38:48 PM (9 days ago) Apr 17
to Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, network-ser...@chromium.org, steimel+...@chromium.org, feature-me...@chromium.org, mek+w...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, philli...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, zelin+watch-we...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, abigailbk...@google.com, cfredri...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, spang...@chromium.org, tracing...@chromium.org, trewin...@google.com, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Lei Zhang and Nasko Oskov

Thomas Anderson added 1 comment

Patchset-level comments
Lei Zhang . resolved

It would be better to split this up and let the reviewers most familiar with the tests take a look.

Thomas Anderson

done

Open in Gerrit

Related details

Attention is currently required from:
  • Lei Zhang
  • Nasko Oskov
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e3f242981a9d5d8f9fe455cd849b851604eb4aa
Gerrit-Change-Number: 7770067
Gerrit-PatchSet: 11
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Lei Zhang <the...@chromium.org>
Gerrit-Attention: Nasko Oskov <na...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Apr 2026 23:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lei Zhang <the...@chromium.org>
satisfied_requirement
unsatisfied_requirement
open
diffy

Thomas Anderson (Gerrit)

unread,
Apr 17, 2026, 7:38:55 PM (9 days ago) Apr 17
to Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, network-ser...@chromium.org, steimel+...@chromium.org, feature-me...@chromium.org, mek+w...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, philli...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, zelin+watch-we...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, abigailbk...@google.com, cfredri...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, spang...@chromium.org, tracing...@chromium.org, trewin...@google.com, wfh+...@chromium.org, yuzo+...@chromium.org

Thomas Anderson abandoned this change.

View Change

Abandoned

Thomas Anderson abandoned this change

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: abandon
satisfied_requirement
unsatisfied_requirement
open
diffy

Nasko Oskov (Gerrit)

unread,
Apr 20, 2026, 4:53:34 PM (6 days ago) Apr 20
to Thomas Anderson, Lei Zhang, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, (Julie)Jeongeun Kim, network-ser...@chromium.org, steimel+...@chromium.org, feature-me...@chromium.org, mek+w...@chromium.org, dmurph+watc...@chromium.org, japhet+...@chromium.org, philli...@chromium.org, webap...@microsoft.com, dibyapal+wa...@chromium.org, kuragin+web-ap...@chromium.org, loyso...@chromium.org, zelin+watch-we...@chromium.org, aixba+wat...@chromium.org, mgiuca...@chromium.org, abigailbk...@google.com, cfredri...@chromium.org, dtseng...@chromium.org, francisjp...@google.com, jatapiaro+wat...@google.com, josiah...@chromium.org, kyungjunle...@google.com, lwinston+watc...@google.com, nektar...@chromium.org, spang...@chromium.org, tracing...@chromium.org, trewin...@google.com, wfh+...@chromium.org, yuzo+...@chromium.org
Attention needed from Thomas Anderson

Nasko Oskov added 4 comments

File chrome/browser/ui/views/global_media_controls/media_dialog_view_interactive_browsertest.cc
Line 816, Patchset 11 (Latest):// TODO(crbug.com/40898509): Renable on WinArm64 or Linux Arm64 when live
Nasko Oskov . unresolved

Please fix this WARNING reported by Spellchecker: "Renable" is a possible misspelling of "Re-enable".

To bypass Spellchecker, add...

"Renable" is a possible misspelling of "Re-enable".

To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER

Line 884, Patchset 11 (Latest):// TODO(crbug.com/40898509): Renable on WinArm64 or Linux Arm64 when live
Nasko Oskov . unresolved

Please fix this WARNING reported by Spellchecker: "Renable" is a possible misspelling of "Re-enable".

To bypass Spellchecker, add...

"Renable" is a possible misspelling of "Re-enable".

To bypass Spellchecker, add a footer with DISABLE_SPELLCHECKER

File chrome/browser/ui/views/toolbar/forward_button_accessibility_interactive_uitest.cc
Line 123, Patchset 11 (Latest): Log("Opening context menu..."),
Nasko Oskov . unresolved

Is this logging necessary?

File chrome/browser/web_applications/web_app_navigation_capturing_browsertest_base.cc
Line 83, Patchset 11 (Latest): base::RunLoop().RunUntilIdle();
Nasko Oskov . unresolved

These look like the tests aren't well structured and we are working around that instead of waiting for the right events.

Open in Gerrit

Related details

Attention is currently required from:
  • Thomas Anderson
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I8e3f242981a9d5d8f9fe455cd849b851604eb4aa
Gerrit-Change-Number: 7770067
Gerrit-PatchSet: 11
Gerrit-Owner: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Reviewer: Lei Zhang <the...@chromium.org>
Gerrit-Reviewer: Nasko Oskov <na...@chromium.org>
Gerrit-Reviewer: Thomas Anderson <thomasa...@chromium.org>
Gerrit-CC: (Julie)Jeongeun Kim <je_jul...@chromium.org>
Gerrit-CC: Akihiro Ota <akihi...@chromium.org>
Gerrit-Attention: Thomas Anderson <thomasa...@chromium.org>
Gerrit-Comment-Date: Mon, 20 Apr 2026 20:53:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy
Reply all
Reply to author
Forward
0 new messages