Migrate off legacy MOCK_METHODn macros [chromium/src : main]
0 views
Skip to first unread message
Patrick Monette (Gerrit)
Jan 7, 2026, 2:11:14 PM (5 days ago) Jan 7
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Sean Maher, Thiabaud Engelbrecht, Zijie He, bartek...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, lize...@chromium.org, lizeb...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng
Patrick Monette added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Jan 7, 2026, 2:13:00 PM (5 days ago) Jan 7
to Patrick Monette, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Sean Maher, Thiabaud Engelbrecht, Zijie He, bartek...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, lize...@chromium.org, lizeb...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Patrick Monette
Daniel Cheng voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
Jan 7, 2026, 2:23:39 PM (5 days ago) Jan 7
to Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, Kentaro Hara, Sean Maher, Thiabaud Engelbrecht, Zijie He, bartek...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, lize...@chromium.org, lizeb...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Patrick Monette voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Monette
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jan 7, 2026, 2:26:44 PM (5 days ago) Jan 7
to Patrick Monette, Daniel Cheng, chromium...@chromium.org, Kentaro Hara, Sean Maher, Thiabaud Engelbrecht, Zijie He, bartek...@chromium.org, fdoray...@chromium.org, fuchsia...@chromium.org, gab+...@chromium.org, grt+...@chromium.org, jessemcke...@google.com, lize...@chromium.org, lizeb...@chromium.org, roblia...@chromium.org, scheduler...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Migrate off legacy MOCK_METHODn macros
It would be nice to get rid of the mock_callback.h.pump file but
there is an issue with variadic template arguments and the usage of
MOCK_METHOD().
Bug: 474044029
Change-Id: Ic1730b234d4dd1856f79877c6f65f7ba7cc115fa
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Patrick Monette <pmon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1565807}
Files:
- M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/fuchsia/fuchsia_logging_pa_unittest.cc
- M base/allocator/partition_allocator/src/partition_alloc/partition_alloc_base/logging_pa_unittest.cc
- M base/files/file_descriptor_watcher_posix_unittest.cc
- M base/fuchsia/fuchsia_logging_unittest.cc
- M base/functional/bind_unittest.cc
- M base/logging_unittest.cc
- M base/observer_list_unittest.cc
- M base/profiler/thread_group_profiler_unittest.cc
- M base/run_loop_unittest.cc
- M base/task/sequence_manager/sequence_manager_impl_unittest.cc
- M base/task/sequence_manager/task_queue_selector_unittest.cc
- M base/task/sequence_manager/test/mock_time_message_pump_unittest.cc
- M base/task/sequence_manager/thread_controller_with_message_pump_impl_unittest.cc
- M base/task/sequence_manager/wake_up_queue_unittest.cc
- M base/task/sequence_manager/work_queue_sets_unittest.cc
- M base/task/sequence_manager/work_queue_unittest.cc
- M base/task/thread_pool/delayed_task_manager_unittest.cc
- M base/task/thread_pool/job_task_source_unittest.cc
- M base/task/thread_pool/sequence_unittest.cc
- M base/task/thread_pool/test_utils.h
- M base/task/thread_pool/worker_thread_unittest.cc
- M base/test/launcher/test_launcher_unittest.cc
- M base/test/mock_callback.h
- M base/test/mock_callback.h.pump
- M base/test/mock_devices_changed_observer.h
- M base/test/mock_log.h
- M base/threading/post_task_and_reply_impl_unittest.cc
- M base/threading/scoped_blocking_call_unittest.cc
- M base/trace_event/memory_dump_manager_unittest.cc
- M base/trace_event/memory_dump_scheduler_unittest.cc
- M base/win/pe_image_reader_unittest.cc
Change size: L
Delta: 31 files changed, 181 insertions(+), 143 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages