[tracing] Fix chrome_config forwarding [chromium/src : main]
0 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
Jul 29, 2026, 3:28:54 PM (8 days ago) Jul 29
to chromium...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Joe Mason
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Joe Mason
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Joe Mason (Gerrit)
Jul 29, 2026, 5:34:38 PM (7 days ago) Jul 29
to Etienne Pierre-Doray, chromium...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Joe Mason voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
Jul 29, 2026, 5:58:47 PM (7 days ago) Jul 29
to chromium...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Jul 29, 2026, 8:47:46 PM (7 days ago) Jul 29
to Etienne Pierre-Doray, chromium...@chromium.org, ipc-securi...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
[tracing] Fix chrome_config forwarding
Absent `config` proto field gets converted into an empty string
through mojo traits.
This results in config mismatch when trying to adopt startup config
in perfetto.
This CL fixes this by always converting empty config back to
absent proto field.
Why not optional: there's semantically no difference between empty
string and missing proto field, we just need to encode it
in a consistent way.
Change-Id: I4a83839586da482b959a461e3fad951433fe0d7c
Reviewed-by: Joe Mason <joenot...@google.com>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1670723}
Files:
- M services/tracing/public/mojom/chrome_config_mojom_traits.cc
Change size: XS
Delta: 1 file changed, 4 insertions(+), 1 deletion(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Joe Mason
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages