Apply modernize-use-ranges clang-tidy fixes in //base [chromium/src : main]

1 view

Skip to first unread message

Gabriel Charette (Gerrit)

unread,

Mar 23, 2026, 4:22:25 PM (10 days ago) Mar 23

to Victor Vianna, Gabriel Charette, Chromium LUCI CQ, chromium...@chromium.org, Sadrul Chowdhury, agriev...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, grt+...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Attention needed from Victor Vianna

Gabriel Charette voted

Code-Review	+1
Commit-Queue	+2

Open in Gerrit

Related details

Attention is currently required from:

Victor Vianna

Submit Requirements:

Code-Coverage
Code-Owners
Code-Review
Review-Enforcement

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

satisfied_requirement

open

diffy

Chromium LUCI CQ (Gerrit)

unread,

Mar 23, 2026, 6:05:41 PM (10 days ago) Mar 23

to Victor Vianna, Gabriel Charette, chromium...@chromium.org, Sadrul Chowdhury, agriev...@chromium.org, asvitki...@chromium.org, chromiumme...@microsoft.com, grt+...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, lizeb...@chromium.org, nyquis...@chromium.org, pasko...@chromium.org, roblia...@chromium.org, spang...@chromium.org, torne...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, yfriedm...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:

Apply modernize-use-ranges clang-tidy fixes in //base

Plus manual fixes in:
- base/containers/span_unittest.cc -> Use base::Reversed() instead of
  std::views::reverse()
- base/metrics/statistics_recorder.cc -> clang-tidy tries to use
  std::ranges::search() which returns a subrange instead of an iterator.
  Use std::contains_subrange() instead.
- base/win/embedded_i18n/language_selector.cc -> The ranges version
  is more opinionated about the comparator. So rely on a projector
  instead.

Change-Id: Iba51468172c37d8991ddf362878c17bffa5f48f7

Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7693694

Auto-Submit: Victor Vianna <victor...@google.com>

Commit-Queue: Victor Vianna <victor...@google.com>

Commit-Queue: Gabriel Charette <g...@chromium.org>

Reviewed-by: Gabriel Charette <g...@chromium.org>

Cr-Commit-Position: refs/heads/main@{#1603725}

Files:

M base/android/pre_freeze_background_memory_trimmer.cc
M base/containers/span_unittest.cc
M base/files/file_path.cc
M base/files/scoped_file_linux.cc
M base/message_loop/message_pump_epoll.cc
M base/metrics/bucket_ranges.cc
M base/metrics/statistics_recorder.cc
M base/strings/escape.cc
M base/strings/string_util_impl_helpers.h
M base/substring_set_matcher/substring_set_matcher.cc
M base/system/sys_info_posix.cc
M base/system/sys_info_unittest.cc
M base/trace_event/memory_dump_manager.cc
M base/win/embedded_i18n/language_selector.cc

Change size: M

Delta: 14 files changed, 32 insertions(+), 40 deletions(-)

Branch: refs/heads/main

Submit Requirements:

Code-Review: +1 by Gabriel Charette

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages