Remove base::AlwaysFalse<> [chromium/src : main]
0 views
Skip to first unread message
Avi Drissman (Gerrit)
Aug 27, 2025, 3:59:08 PM (13 days ago) Aug 27
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, roblia...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Daniel Cheng
Avi Drissman added 1 comment![]( "Open in Gerrit")
Patchset-level comments
Related details
Attention is currently required from:
- Daniel Cheng
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Daniel Cheng (Gerrit)
Aug 27, 2025, 5:39:41 PM (13 days ago) Aug 27
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, roblia...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman
Daniel Cheng voted and added 1 comment![]( "Open in Gerrit")
Votes added by Daniel Cheng
| Code-Review | +1 |
| Owners-Override | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Avi Drissman
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
Aug 27, 2025, 5:51:32 PM (13 days ago) Aug 27
to Avi Drissman, Daniel Cheng, Chromium LUCI CQ, chromium...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, roblia...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Avi Drissman voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
Aug 27, 2025, 5:54:36 PM (13 days ago) Aug 27
to Avi Drissman, Daniel Cheng, chromium...@chromium.org, grt+...@chromium.org, ipc-securi...@chromium.org, jessemcke...@google.com, jshin...@chromium.org, roblia...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
Remove base::AlwaysFalse<>
Since its introduction in 2011, `static_assert(false)` could not be used
in templates because it caused the code to be ill-formed. However,
sometimes you want to prohibit instantiation of a template with a
default parameter value, and force users to create specializations. The
usual workaround was to define an "always false" template. Chromium
followed that pattern with `base/types/always_false.h`.
Because this issue was one that widely affected the C++ community, in
2023 the C++ committee accepted P2593R1 to fix this problem. Later in
2023, a note about this fix was added to `always_false.h`.
However, the author of this note in `always_false.h` was mistaken. The
author believed that P2593R1 was accepted as part of C++23 (and thus
`base::AlwaysFalse<>` would need to be kept until Chromium adopted
C++23), but in fact the C++ committee had accepted and incorporated
P2593R1 as errata all the way back to C++11.
Because this errata has been widely implemented (Clang 17, GCC 13, and
MSVC 19.40), it is safe to remove the Chromium workaround.
See https://en.cppreference.com/w/cpp/language/static_assert.html and
its "defect reports" section.
Bug: none
Change-Id: Ic0c9378483c9ad5cceb08bbb20a348a818ec5bd1
Owners-Override: Daniel Cheng <dch...@chromium.org>
Reviewed-by: Daniel Cheng <dch...@chromium.org>
Commit-Queue: Avi Drissman <a...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1507382}
Files:
- M base/BUILD.gn
- M base/apple/bridging.h
- M base/functional/bind_internal.h
- M base/functional/callback.h
- M base/strings/utf_string_conversions.h
- M base/trace_event/memory_usage_estimator.h
- D base/types/always_false.h
- M base/types/variant_util.h
- M base/win/scoped_gdi_object.h
- M components/reporting/util/status_macros.h
- M ipc/ipc_param_traits.h
- M mojo/public/cpp/bindings/array_traits.h
- M mojo/public/cpp/bindings/clone_traits.h
- M mojo/public/cpp/bindings/enum_traits.h
- M mojo/public/cpp/bindings/lib/template_util.h
- M mojo/public/cpp/bindings/map_traits.h
- M mojo/public/cpp/bindings/string_traits.h
- M mojo/public/cpp/bindings/struct_traits.h
- M mojo/public/cpp/bindings/union_traits.h
- M ui/base/interaction/interactive_test_definitions.h
Change size: M
Delta: 20 files changed, 24 insertions(+), 97 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Daniel Cheng
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages