Reland "[tracing] Fill typed fields in chrome metadata" [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Apr 17, 2026, 10:26:40 AM (9 days ago) Apr 17
to Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Robert Kaplow, Mikhail Khokhlov, Dave Tapuska, Nate Fischer, chromium...@chromium.org, Chromium Metrics Reviews, fgal...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dewitt...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, android-web...@chromium.org
Attention needed from Dave Tapuska, Mikhail Khokhlov, Nate Fischer and Robert Kaplow

Etienne Pierre-Doray voted and added 1 comment

Votes added by Etienne Pierre-Doray

Commit-Queue+1

1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Etienne Pierre-Doray . resolved

PTAL

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Mikhail Khokhlov
  • Nate Fischer
  • Robert Kaplow
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: I605102b94c189f6de0c55a83e3b291ba06ee384c
Gerrit-Change-Number: 7770189
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
Gerrit-Reviewer: Robert Kaplow <rka...@chromium.org>
Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
Gerrit-CC: Jerome Jiang <ji...@chromium.org>
Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
Gerrit-CC: gwsq
Gerrit-Attention: Mikhail Khokhlov <khok...@google.com>
Gerrit-Attention: Robert Kaplow <rka...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Attention: Nate Fischer <ntf...@chromium.org>
Gerrit-Comment-Date: Fri, 17 Apr 2026 14:26:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Dave Tapuska (Gerrit)

unread,
Apr 17, 2026, 10:27:48 AM (9 days ago) Apr 17
to Etienne Pierre-Doray, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Robert Kaplow, Mikhail Khokhlov, Nate Fischer, chromium...@chromium.org, Chromium Metrics Reviews, fgal...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dewitt...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, android-web...@chromium.org
Attention needed from Etienne Pierre-Doray, Mikhail Khokhlov, Nate Fischer and Robert Kaplow

Dave Tapuska voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Etienne Pierre-Doray
  • Mikhail Khokhlov
  • Nate Fischer
  • Robert Kaplow
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I605102b94c189f6de0c55a83e3b291ba06ee384c
      Gerrit-Change-Number: 7770189
      Gerrit-PatchSet: 5
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
      Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
      Gerrit-Reviewer: Robert Kaplow <rka...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-CC: gwsq
      Gerrit-Attention: Mikhail Khokhlov <khok...@google.com>
      Gerrit-Attention: Robert Kaplow <rka...@chromium.org>
      Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Attention: Nate Fischer <ntf...@chromium.org>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 14:27:36 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Mikhail Khokhlov (Gerrit)

      unread,
      Apr 17, 2026, 10:32:56 AM (9 days ago) Apr 17
      to Etienne Pierre-Doray, Dave Tapuska, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Robert Kaplow, Nate Fischer, chromium...@chromium.org, Chromium Metrics Reviews, fgal...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dewitt...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, android-web...@chromium.org
      Attention needed from Etienne Pierre-Doray, Nate Fischer and Robert Kaplow

      Mikhail Khokhlov voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Etienne Pierre-Doray
      • Nate Fischer
      • Robert Kaplow
      Gerrit-Attention: Robert Kaplow <rka...@chromium.org>
      Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Attention: Nate Fischer <ntf...@chromium.org>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 14:32:37 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Robert Kaplow (Gerrit)

      unread,
      Apr 17, 2026, 10:34:21 AM (9 days ago) Apr 17
      to Etienne Pierre-Doray, Mikhail Khokhlov, Dave Tapuska, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, Nate Fischer, chromium...@chromium.org, Chromium Metrics Reviews, fgal...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dewitt...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, android-web...@chromium.org
      Attention needed from Etienne Pierre-Doray and Nate Fischer

      Robert Kaplow voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Etienne Pierre-Doray
      • Nate Fischer
      Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Attention: Nate Fischer <ntf...@chromium.org>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 14:34:07 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Nate Fischer (Gerrit)

      unread,
      Apr 17, 2026, 4:17:10 PM (9 days ago) Apr 17
      to Etienne Pierre-Doray, Robert Kaplow, Mikhail Khokhlov, Dave Tapuska, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, fgal...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dewitt...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, android-web...@chromium.org
      Attention needed from Etienne Pierre-Doray

      Nate Fischer voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Etienne Pierre-Doray
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I605102b94c189f6de0c55a83e3b291ba06ee384c
      Gerrit-Change-Number: 7770189
      Gerrit-PatchSet: 5
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Mikhail Khokhlov <khok...@google.com>
      Gerrit-Reviewer: Nate Fischer <ntf...@chromium.org>
      Gerrit-Reviewer: Robert Kaplow <rka...@chromium.org>
      Gerrit-CC: Chromium Metrics Reviews <chromium-met...@google.com>
      Gerrit-CC: Jerome Jiang <ji...@chromium.org>
      Gerrit-CC: Mirko Bonadei <mbon...@chromium.org>
      Gerrit-CC: gwsq
      Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Comment-Date: Fri, 17 Apr 2026 20:16:57 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Etienne Pierre-Doray (Gerrit)

      unread,
      Apr 17, 2026, 4:22:12 PM (9 days ago) Apr 17
      to Nate Fischer, Robert Kaplow, Mikhail Khokhlov, Dave Tapuska, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, Chromium LUCI CQ, chromium...@chromium.org, Chromium Metrics Reviews, fgal...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dewitt...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, android-web...@chromium.org

      Etienne Pierre-Doray voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Gerrit-Comment-Date: Fri, 17 Apr 2026 20:22:02 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Apr 17, 2026, 4:25:09 PM (9 days ago) Apr 17
      to Etienne Pierre-Doray, Nate Fischer, Robert Kaplow, Mikhail Khokhlov, Dave Tapuska, Jerome Jiang, Mirko Bonadei, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, Chromium Metrics Reviews, fgal...@chromium.org, mar...@chromium.org, feature-me...@chromium.org, devtools...@chromium.org, dewitt...@chromium.org, chrome-intelligence-te...@google.com, jz...@chromium.org, chrome-intell...@chromium.org, cblume...@chromium.org, penghuan...@chromium.org, wfh+...@chromium.org, tracing...@chromium.org, spang...@chromium.org, chromiumme...@microsoft.com, asvitki...@chromium.org, android-web...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      Reland "[tracing] Fill typed fields in chrome metadata"

      This is a reland of commit 853791da0a00051fb3c92ca2a720a613afde647e

      Reason for revert: This cl has caused multiple builders to fail, failing builders: android-arm-tests, android-14-arm64-rel-tests. First failing build": https://ci.chromium.org/ui/p/chrome/builders/ci/android-arm-tests/37173/overview

      Fix: Revert moving set_chrome_version_code out of content

      Original change's description:
      > [tracing] Fill typed fields in chrome metadata
      >
      > This CL fills a few typed fields in ChromeMetadataPack that we added in
      > https://github.com/google/perfetto/commit/fe9b2f932a1cf9d104e6b49ee3acbf173997062c
      >
      > Bug: b/432275929
      > Change-Id: I5ab8251de147d6126d2b2e2ea869d17496ae9beb
      > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/7748943
      > Reviewed-by: Dave Tapuska <dtap...@chromium.org>
      > Reviewed-by: Robert Kaplow <rka...@chromium.org>
      > Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
      > Reviewed-by: Mikhail Khokhlov <khok...@google.com>
      > Reviewed-by: Nate Fischer <ntf...@chromium.org>
      > Cr-Commit-Position: refs/heads/main@{#1615992}
      Bug: b/432275929
      Change-Id: I605102b94c189f6de0c55a83e3b291ba06ee384c
      Reviewed-by: Mikhail Khokhlov <khok...@google.com>
      Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
      Reviewed-by: Nate Fischer <ntf...@chromium.org>
      Reviewed-by: Dave Tapuska <dtap...@chromium.org>
      Reviewed-by: Robert Kaplow <rka...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1616815}
      Files:
      • M android_webview/browser/tracing/aw_tracing_delegate.cc
      • M android_webview/browser/tracing/aw_tracing_delegate.h
      • M chrome/browser/tracing/chrome_tracing_delegate.cc
      • M chrome/browser/tracing/chrome_tracing_delegate.h
      • M components/metrics/metrics_log.cc
      • M components/metrics/version_utils.cc
      • M components/metrics/version_utils.h
      • M components/tracing/common/system_profile_metadata_recorder.cc
      • M components/tracing/common/system_profile_metadata_recorder.h
      • M content/browser/tracing/tracing_controller_impl.cc
      • M content/public/browser/tracing_delegate.cc
      • M content/public/browser/tracing_delegate.h
      • M services/tracing/public/cpp/perfetto/metadata_data_source.cc
      • M services/tracing/public/cpp/perfetto/metadata_data_source.h
      Change size: M
      Delta: 14 files changed, 90 insertions(+), 39 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Mikhail Khokhlov, +1 by Dave Tapuska, +1 by Nate Fischer, +1 by Robert Kaplow
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: I605102b94c189f6de0c55a83e3b291ba06ee384c
      Gerrit-Change-Number: 7770189
      Gerrit-PatchSet: 6
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages