[tracing] Move BackgroundTracingManager to services [chromium/src : main]
5 views
Skip to first unread message
Etienne Pierre-Doray (Gerrit)
May 13, 2026, 11:11:09 AM (8 days ago) May 13
to Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Mikhail Khokhlov
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Commit-Queue | +1 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Mikhail Khokhlov
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Mikhail Khokhlov (Gerrit)
May 14, 2026, 6:34:05 AM (7 days ago) May 14
to Etienne Pierre-Doray, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Mikhail Khokhlov voted Code-Review+1![]( "Open in Gerrit")
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 14, 2026, 6:41:09 AM (7 days ago) May 14
to Dave Tapuska, Avi Drissman, Nate Fischer, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman, Dave Tapuska and Nate Fischer
Etienne Pierre-Doray added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 17 (Latest):
Etienne Pierre-Doray . resolved
+avi@ for chrome/
+dtapuska@ for content/
+ntfschr@ for android_webview/
Related details
Attention is currently required from:
- Avi Drissman
- Dave Tapuska
- Nate Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Dave Tapuska (Gerrit)
May 14, 2026, 10:27:46 AM (7 days ago) May 14
to Etienne Pierre-Doray, Avi Drissman, Nate Fischer, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Avi Drissman, Etienne Pierre-Doray and Nate Fischer
Dave Tapuska voted and added 1 comment![]( "Open in Gerrit")
Votes added by Dave Tapuska
| Code-Review | +1 |
1 comment
File content/browser/browser_main_loop.cc
Line 770, Patchset 17 (Latest):
background_tracing_manager_ = std::make_unique<BackgroundTracingManagerImpl>(Dave Tapuska . unresolved
Why wouldn't we use CreateBackgroundTracingManager here? Do we actually need something from the Impl definition?
Related details
Attention is currently required from:
- Avi Drissman
- Etienne Pierre-Doray
- Nate Fischer
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Avi Drissman (Gerrit)
May 14, 2026, 10:59:30 AM (7 days ago) May 14
to Etienne Pierre-Doray, Avi Drissman, Dave Tapuska, Nate Fischer, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray and Nate Fischer
Avi Drissman voted and added 1 comment![]( "Open in Gerrit")
Votes added by Avi Drissman
| Code-Review | +1 |
1 comment
Patchset-level comments
Attention is currently required from:
- Etienne Pierre-Doray
- Nate Fischer
Nate Fischer (Gerrit)
May 14, 2026, 12:23:22 PM (7 days ago) May 14
to Etienne Pierre-Doray, Avi Drissman, Dave Tapuska, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Nate Fischer voted Code-Review+1![]( "Open in Gerrit")
| Code-Review | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
No-Unresolved-Comments
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 14, 2026, 1:02:09 PM (7 days ago) May 14
to Patrick Monette, Nate Fischer, Avi Drissman, Dave Tapuska, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Patrick Monette
Etienne Pierre-Doray added 2 comments![]( "Open in Gerrit")
Patchset-level comments
File content/browser/browser_main_loop.cc
Line 770, Patchset 17:
background_tracing_manager_ = std::make_unique<BackgroundTracingManagerImpl>(Dave Tapuska . resolved
Why wouldn't we use CreateBackgroundTracingManager here? Do we actually need something from the Impl definition?
Etienne Pierre-Doray
Good point, done.
The only reason I hadn't done this is that I added CreateBackgroundTracingManager later on when I realized it was needed outside of content/
Related details
Attention is currently required from:
- Patrick Monette
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Patrick Monette (Gerrit)
May 14, 2026, 1:04:58 PM (7 days ago) May 14
to Etienne Pierre-Doray, Nate Fischer, Avi Drissman, Dave Tapuska, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Patrick Monette voted and added 1 comment![]( "Open in Gerrit")
Votes added by Patrick Monette
| Code-Review | +1 |
1 comment
Patchset-level comments
Patrick Monette . resolved
components/performance_manager/graph/process_node_impl.h lgtm
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 14, 2026, 1:22:01 PM (7 days ago) May 14
to Patrick Monette, Nate Fischer, Avi Drissman, Dave Tapuska, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 14, 2026, 2:16:10 PM (7 days ago) May 14
to Patrick Monette, Nate Fischer, Avi Drissman, Dave Tapuska, Mikhail Khokhlov, Chromium LUCI CQ, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Etienne Pierre-Doray voted Commit-Queue+2![]( "Open in Gerrit")
| Commit-Queue | +2 |
Related details
Attention set is empty
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 14, 2026, 6:18:03 PM (7 days ago) May 14
to Etienne Pierre-Doray, Patrick Monette, Nate Fischer, Avi Drissman, Dave Tapuska, Mikhail Khokhlov, android-bu...@system.gserviceaccount.com, chromium...@chromium.org, android-web...@chromium.org, droger+w...@chromium.org, dullweb...@chromium.org, msrame...@chromium.org, performance-m...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change with unreviewed changes![]( "Open in Gerrit")
Unreviewed changes
18 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:
```
The name of the file: content/browser/browser_main_loop.cc
Insertions: 1, Deletions: 0.
@@ -149,6 +149,7 @@
#include "services/network/public/cpp/network_switches.h"
#include "services/network/public/mojom/network_service.mojom.h"
#include "services/network/transitional_url_loader_factory_owner.h"
+#include "services/tracing/public/cpp/background_tracing/background_tracing_manager.h"
#include "services/tracing/public/cpp/startup_tracing_controller.h"
#include "services/tracing/public/cpp/trace_startup_config.h"
#include "services/video_capture/public/cpp/features.h"
```
Change information
Commit message:
[tracing] Move BackgroundTracingManager to services
This CL moves BackgroundTracingManager from content/ to services/ so
that it can be reused for iOS without content/. This extracts part of
BackgroundTracingManager that are content specific, and keeps it in a
derived content::BackgroundTracingManagerImpl.
I tried to make it as mechanical as possible. Gerrit doesn't recognize
services/tracing/public/cpp/background_tracing/background_tracing_manager.h/.cc
as moved, so here's the manual diff:
background_tracing_manager_impl.h.diff
https://paste.googleplex.com/6256732864118784
background_tracing_manager_impl.cc.diff
https://paste.googleplex.com/4528916879507456
Bypass-Check-License: Moved files
Bug: 495937056
Change-Id: Id2a79aa0522570c3460802d1dc480507cd73d741
Reviewed-by: Mikhail Khokhlov <khok...@google.com>
Reviewed-by: Dave Tapuska <dtap...@chromium.org>
Reviewed-by: Nate Fischer <ntf...@chromium.org>
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Avi Drissman <a...@chromium.org>
Reviewed-by: Patrick Monette <pmon...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1630800}
Files:
- M android_webview/browser/tracing/aw_background_tracing_metrics_provider_unittest.cc
- M android_webview/test/BUILD.gn
- M chrome/browser/browsing_data/BUILD.gn
- M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
- M chrome/browser/browsing_data/chrome_browsing_data_remover_delegate_unittest.cc
- M chrome/browser/signin/android/signin_manager_android_unittest.cc
- M chrome/browser/tracing/BUILD.gn
- M chrome/browser/tracing/chrome_background_tracing_metrics_provider_unittest.cc
- M chrome/browser/tracing/chrome_tracing_delegate_browsertest.cc
- M chrome/test/BUILD.gn
- M components/performance_manager/graph/process_node_impl.h
- M components/tracing/BUILD.gn
- M components/tracing/DEPS
- M components/tracing/common/background_tracing_metrics_provider.cc
- M components/tracing/common/background_tracing_utils.cc
- M components/tracing/common/background_tracing_utils_unittest.cc
- M content/browser/BUILD.gn
- M content/browser/browser_main_loop.cc
- M content/browser/browser_main_loop.h
- M content/browser/tracing/background_tracing_manager_browsertest.cc
- M content/browser/tracing/background_tracing_manager_impl.cc
- M content/browser/tracing/background_tracing_manager_impl.h
- M content/browser/tracing/traces_internals/traces_internals_handler.cc
- M content/browser/tracing/traces_internals/traces_internals_handler.h
- M content/browser/tracing/traces_internals/traces_internals_handler_unittest.cc
- M content/public/browser/BUILD.gn
- A content/public/browser/background_tracing.h
- D content/public/browser/background_tracing_manager.h
- D content/public/test/background_tracing_test_support.cc
- D content/public/test/background_tracing_test_support.h
- M content/test/BUILD.gn
- M services/tracing/public/cpp/background_tracing/BUILD.gn
- M services/tracing/public/cpp/background_tracing/DEPS
- A services/tracing/public/cpp/background_tracing/background_tracing_manager.cc
- A services/tracing/public/cpp/background_tracing/background_tracing_manager.h
- R services/tracing/public/cpp/background_tracing/background_tracing_manager_unittest.cc
- R services/tracing/public/cpp/background_tracing/trace_upload_list.h
Change size: XL
Delta: 37 files changed, 1661 insertions(+), 1621 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Avi Drissman, +1 by Nate Fischer, +1 by Patrick Monette, +1 by Dave Tapuska, +1 by Mikhail Khokhlov
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages