Add package_name to metadata data source [chromium/src : main]

0 views
Skip to first unread message

Sayed Elabady (Gerrit)

unread,
Feb 18, 2026, 9:45:01 AM (10 days ago) Feb 18
to Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Eric Seckler

Sayed Elabady added 1 comment

Patchset-level comments
File-level comment, Patchset 2 (Latest):
Sayed Elabady . resolved

Hi Eric,

Please let me know if there's any other place that I should change.

Open in Gerrit

Related details

Attention is currently required from:
  • Eric Seckler
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id29bff3dacadef7fb18122d2ee9fb890d5e4e335
Gerrit-Change-Number: 7588494
Gerrit-PatchSet: 2
Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
Gerrit-Attention: Eric Seckler <esec...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Feb 2026 14:44:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Eric Seckler (Gerrit)

unread,
Feb 18, 2026, 9:53:53 AM (10 days ago) Feb 18
to Sayed Elabady, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Sayed Elabady

Eric Seckler voted Code-Review+1

Code-Review+1
Open in Gerrit

Related details

Attention is currently required from:
  • Sayed Elabady
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id29bff3dacadef7fb18122d2ee9fb890d5e4e335
Gerrit-Change-Number: 7588494
Gerrit-PatchSet: 2
Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
Gerrit-Attention: Sayed Elabady <elabad...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Feb 2026 14:53:40 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Sayed Elabady (Gerrit)

unread,
Feb 18, 2026, 10:03:41 AM (10 days ago) Feb 18
to Eric Seckler, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Sayed Elabady voted Commit-Queue+2

Commit-Queue+2
Open in Gerrit

Related details

Attention set is empty
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement satisfiedCode-Owners
  • requirement satisfiedCode-Review
  • requirement satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id29bff3dacadef7fb18122d2ee9fb890d5e4e335
Gerrit-Change-Number: 7588494
Gerrit-PatchSet: 2
Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
Gerrit-Comment-Date: Wed, 18 Feb 2026 15:03:28 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
open
diffy

Chromium LUCI CQ (Gerrit)

unread,
Feb 18, 2026, 10:07:19 AM (10 days ago) Feb 18
to Sayed Elabady, Eric Seckler, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org

Chromium LUCI CQ submitted the change

Change information

Commit message:
Add package_name to metadata data source

This allows distinguishing Finch hashes reported by different apps
using WebView.
Bug: b:465694294
Change-Id: Id29bff3dacadef7fb18122d2ee9fb890d5e4e335
Reviewed-by: Eric Seckler <esec...@chromium.org>
Commit-Queue: Sayed Elabady <elabad...@chromium.org>
Cr-Commit-Position: refs/heads/main@{#1586411}
Files:
  • M services/tracing/public/cpp/perfetto/metadata_data_source.cc
Change size: S
Delta: 1 file changed, 10 insertions(+), 3 deletions(-)
Branch: refs/heads/main
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Eric Seckler
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: Id29bff3dacadef7fb18122d2ee9fb890d5e4e335
Gerrit-Change-Number: 7588494
Gerrit-PatchSet: 3
Gerrit-Owner: Sayed Elabady <elabad...@chromium.org>
Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
Gerrit-Reviewer: Eric Seckler <esec...@chromium.org>
Gerrit-Reviewer: Sayed Elabady <elabad...@chromium.org>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages