[tracing] Introduce persistent trace event categories [chromium/src : main]

0 views
Skip to first unread message

Etienne Pierre-Doray (Gerrit)

unread,
Jun 29, 2026, 3:54:11 PM (4 days ago) Jun 29
to Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gavinp...@chromium.org, navigation...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
Attention needed from Dave Tapuska

Etienne Pierre-Doray voted Commit-Queue+1

Commit-Queue+1
Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If4809b756985557a506becef3aedfaa59d8e1617
Gerrit-Change-Number: 8013209
Gerrit-PatchSet: 4
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Jun 2026 19:54:04 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
satisfied_requirement
unsatisfied_requirement
open
diffy

Etienne Pierre-Doray (Gerrit)

unread,
Jun 29, 2026, 6:08:57 PM (4 days ago) Jun 29
to Patrick Monette, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gavinp...@chromium.org, navigation...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
Attention needed from Dave Tapuska and Patrick Monette

Etienne Pierre-Doray added 1 comment

Patchset-level comments
File-level comment, Patchset 5 (Latest):
Etienne Pierre-Doray . resolved

+pmonette@ for memory_pressure

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Patrick Monette
Submit Requirements:
  • requirement satisfiedCode-Coverage
  • requirement is not satisfiedCode-Owners
  • requirement is not satisfiedCode-Review
  • requirement is not satisfiedReview-Enforcement
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: comment
Gerrit-Project: chromium/src
Gerrit-Branch: main
Gerrit-Change-Id: If4809b756985557a506becef3aedfaa59d8e1617
Gerrit-Change-Number: 8013209
Gerrit-PatchSet: 5
Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
Gerrit-Attention: Patrick Monette <pmon...@chromium.org>
Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
Gerrit-Comment-Date: Mon, 29 Jun 2026 22:08:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
satisfied_requirement
unsatisfied_requirement
open
diffy

Patrick Monette (Gerrit)

unread,
Jun 29, 2026, 8:32:39 PM (4 days ago) Jun 29
to Etienne Pierre-Doray, Dave Tapuska, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gavinp...@chromium.org, navigation...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
Attention needed from Dave Tapuska and Etienne Pierre-Doray

Patrick Monette voted and added 2 comments

Votes added by Patrick Monette

Code-Review+1

2 comments

Patchset-level comments
Patrick Monette . resolved

lgtm

Commit Message
Line 15, Patchset 5 (Latest):
Patrick Monette . unresolved

Bug id? Just to get some context.

Open in Gerrit

Related details

Attention is currently required from:
  • Dave Tapuska
  • Etienne Pierre-Doray
Submit Requirements:
    • requirement satisfiedCode-Coverage
    • requirement is not satisfiedCode-Owners
    • requirement satisfiedCode-Review
    • requirement is not satisfiedNo-Unresolved-Comments
    • requirement satisfiedReview-Enforcement
    Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
    Gerrit-MessageType: comment
    Gerrit-Project: chromium/src
    Gerrit-Branch: main
    Gerrit-Change-Id: If4809b756985557a506becef3aedfaa59d8e1617
    Gerrit-Change-Number: 8013209
    Gerrit-PatchSet: 5
    Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
    Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
    Gerrit-Attention: Dave Tapuska <dtap...@chromium.org>
    Gerrit-Comment-Date: Tue, 30 Jun 2026 00:32:27 +0000
    Gerrit-HasComments: Yes
    Gerrit-Has-Labels: Yes
    satisfied_requirement
    unsatisfied_requirement
    open
    diffy

    Etienne Pierre-Doray (Gerrit)

    unread,
    Jul 1, 2026, 7:43:58 AM (2 days ago) Jul 1
    to Rakina Zata Amni, Patrick Monette, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gavinp...@chromium.org, navigation...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
    Attention needed from Rakina Zata Amni

    Etienne Pierre-Doray added 2 comments

    Patchset-level comments
    File-level comment, Patchset 8 (Latest):
    Etienne Pierre-Doray . resolved

    -dtapuska@ is OOO, +rakina@ for content/

    Commit Message
    Line 15, Patchset 5:
    Patrick Monette . resolved

    Bug id? Just to get some context.

    Etienne Pierre-Doray

    Done

    Open in Gerrit

    Related details

    Attention is currently required from:
    • Rakina Zata Amni
    Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement is not satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If4809b756985557a506becef3aedfaa59d8e1617
      Gerrit-Change-Number: 8013209
      Gerrit-PatchSet: 8
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Attention: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Comment-Date: Wed, 01 Jul 2026 11:43:46 +0000
      Gerrit-HasComments: Yes
      Gerrit-Has-Labels: No
      Comment-In-Reply-To: Patrick Monette <pmon...@chromium.org>
      satisfied_requirement
      unsatisfied_requirement
      open
      diffy

      Rakina Zata Amni (Gerrit)

      unread,
      Jul 2, 2026, 6:34:55 AM (yesterday) Jul 2
      to Etienne Pierre-Doray, Patrick Monette, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gavinp...@chromium.org, navigation...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org
      Attention needed from Etienne Pierre-Doray

      Rakina Zata Amni voted Code-Review+1

      Code-Review+1
      Open in Gerrit

      Related details

      Attention is currently required from:
      • Etienne Pierre-Doray
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If4809b756985557a506becef3aedfaa59d8e1617
      Gerrit-Change-Number: 8013209
      Gerrit-PatchSet: 8
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Attention: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Jul 2026 10:34:23 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Etienne Pierre-Doray (Gerrit)

      unread,
      Jul 2, 2026, 8:13:12 AM (yesterday) Jul 2
      to Rakina Zata Amni, Patrick Monette, Chromium LUCI CQ, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gavinp...@chromium.org, navigation...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org

      Etienne Pierre-Doray voted Commit-Queue+2

      Commit-Queue+2
      Open in Gerrit

      Related details

      Attention set is empty
      Submit Requirements:
      • requirement satisfiedCode-Coverage
      • requirement satisfiedCode-Owners
      • requirement satisfiedCode-Review
      • requirement satisfiedReview-Enforcement
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: comment
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If4809b756985557a506becef3aedfaa59d8e1617
      Gerrit-Change-Number: 8013209
      Gerrit-PatchSet: 8
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      Gerrit-Comment-Date: Thu, 02 Jul 2026 12:13:00 +0000
      Gerrit-HasComments: No
      Gerrit-Has-Labels: Yes
      satisfied_requirement
      open
      diffy

      Chromium LUCI CQ (Gerrit)

      unread,
      Jul 2, 2026, 9:40:46 AM (yesterday) Jul 2
      to Etienne Pierre-Doray, Rakina Zata Amni, Patrick Monette, chromium...@chromium.org, android-bu...@system.gserviceaccount.com, gavinp...@chromium.org, navigation...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org, creis...@chromium.org, kinuko...@chromium.org, alexmo...@chromium.org, chikamu...@chromium.org, blink-...@chromium.org, scheduler-...@chromium.org

      Chromium LUCI CQ submitted the change

      Change information

      Commit message:
      [tracing] Introduce persistent trace event categories

      - isolate a few persistent events and categories that describe high level state (not exhaustive) and are low throughput.
      - Add "persistent" tag to those categories (reused or new)

      This lets us create trace configs that write those events to a separate
      buffer and are kept more consistently instead of being overwritten
      in the main ring buffer.
      Bug: 530102282
      Change-Id: If4809b756985557a506becef3aedfaa59d8e1617
      Reviewed-by: Rakina Zata Amni <rak...@chromium.org>
      Reviewed-by: Patrick Monette <pmon...@chromium.org>
      Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
      Cr-Commit-Position: refs/heads/main@{#1656059}
      Files:
      • M base/memory/memory_pressure_listener_registry.cc
      • M base/trace_event/builtin_categories.h
      • M components/memory_pressure/memory_pressure_voter.cc
      • M content/browser/renderer_host/render_frame_host_impl.cc
      • M content/browser/web_contents/web_contents_impl.cc
      • M third_party/blink/renderer/platform/scheduler/common/back_forward_cache_disabling_feature_tracker.cc
      • M third_party/blink/renderer/platform/scheduler/common/back_forward_cache_disabling_feature_tracker.h
      • M third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.cc
      • M third_party/blink/renderer/platform/scheduler/main_thread/frame_scheduler_impl.h
      Change size: M
      Delta: 9 files changed, 55 insertions(+), 48 deletions(-)
      Branch: refs/heads/main
      Submit Requirements:
      • requirement satisfiedCode-Review: +1 by Patrick Monette, +1 by Rakina Zata Amni
      Open in Gerrit
      Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
      Gerrit-MessageType: merged
      Gerrit-Project: chromium/src
      Gerrit-Branch: main
      Gerrit-Change-Id: If4809b756985557a506becef3aedfaa59d8e1617
      Gerrit-Change-Number: 8013209
      Gerrit-PatchSet: 9
      Gerrit-Owner: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Chromium LUCI CQ <chromiu...@luci-project-accounts.iam.gserviceaccount.com>
      Gerrit-Reviewer: Etienne Pierre-Doray <etie...@chromium.org>
      Gerrit-Reviewer: Patrick Monette <pmon...@chromium.org>
      Gerrit-Reviewer: Rakina Zata Amni <rak...@chromium.org>
      open
      diffy
      satisfied_requirement
      Reply all
      Reply to author
      Forward
      0 new messages