tracing: Fix browser shutdown crash in BackgroundTracingManagerImpl [chromium/src : main]
2 views
Skip to first unread message
Justin Cohen (Gerrit)
May 18, 2026, 12:12:22 PM (3 days ago) May 18
to Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Justin Cohen added 1 comment![]( "Open in Gerrit")
Patchset-level comments
File-level comment, Patchset 1 (Latest):
Justin Cohen . resolved
Will add a test too, just a heads up since they marked this p0
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Justin Cohen (Gerrit)
May 18, 2026, 12:25:40 PM (3 days ago) May 18
to Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Etienne Pierre-Doray
Justin Cohen voted![]( "Open in Gerrit")
| Auto-Submit | +1 |
| Commit-Queue | +1 |
Related details
Attention is currently required from:
- Etienne Pierre-Doray
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Etienne Pierre-Doray (Gerrit)
May 19, 2026, 9:20:02 AM (2 days ago) May 19
to Justin Cohen, Chromium LUCI CQ, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Attention needed from Justin Cohen
Etienne Pierre-Doray voted and added 1 comment![]( "Open in Gerrit")
Votes added by Etienne Pierre-Doray
| Code-Review | +1 |
| Commit-Queue | +2 |
1 comment
Patchset-level comments
Related details
Attention is currently required from:
- Justin Cohen
Submit Requirements:
Code-Coverage
Code-Owners
Code-Review
Review-Enforcement
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Chromium LUCI CQ (Gerrit)
May 19, 2026, 9:32:06 AM (2 days ago) May 19
to Justin Cohen, Etienne Pierre-Doray, chromium...@chromium.org, spang...@chromium.org, tracing...@chromium.org, wfh+...@chromium.org
Chromium LUCI CQ submitted the change![]( "Open in Gerrit")
Change information
Commit message:
tracing: Fix browser shutdown crash in BackgroundTracingManagerImpl
Call DisableScenarios() in BackgroundTracingManagerImpl destructor
before setting TracingAgentObserverManager to nullptr.
BackgroundTracingManagerImpl inherits from BackgroundTracingManager and
implements TracingAgentObserverManager. During shutdown, the derived
class destructor unregisters the observer manager instance, but the
base class destructor is the one that calls DisableScenarios() to
abort and uninstall trigger rules (such as HistogramRule). This
triggers a CHECK failure when HistogramRule's uninstallation logic
attempts to access the now-null TracingAgentObserverManager instance.
Explicitly calling DisableScenarios() in the derived class destructor
ensures that scenarios and rules are uninstalled while the observer
manager instance is still valid.
Fixed: 513698528, 514264102
Change-Id: I06bfc4f877ead6146e8d5dadc9d79ef8a0a7dbfb
Commit-Queue: Etienne Pierre-Doray <etie...@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etie...@chromium.org>
Auto-Submit: Justin Cohen <justi...@google.com>
Cr-Commit-Position: refs/heads/main@{#1632812}
Files:
- M content/browser/tracing/background_tracing_manager_browsertest.cc
- M content/browser/tracing/background_tracing_manager_impl.cc
Change size: S
Delta: 2 files changed, 25 insertions(+), 0 deletions(-)
Branch: refs/heads/main
Submit Requirements:
Code-Review: +1 by Etienne Pierre-Doray
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages